Skip to content

[Alerts table] Unskipped pagination test #227486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cesco-f merged 3 commits into from
Jul 15, 2025
Merged

[Alerts table] Unskipped pagination test #227486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3078bb8
test(fix): fixed pagination of the alerts table test
cesco-f Jul 10, 2025
cbd2cf5
fix(test): removed alertDataIsBeingLoaded because it's flaky
cesco-f Jul 11, 2025
000519f
fix(files): files have been moved
cesco-f Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions x-pack/solutions/observability/test/functional/services/observability/alerts/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,14 +306,16 @@ export function ObservabilityAlertsCommonProvider({
await testSubjects.click(buttonSubject);
};

const alertDataIsBeingLoaded = async () => {
return testSubjects.existOrFail('events-container-loading-true');
const selectAlertStatusFilter = async (alertStatus: AlertStatus) => {
await testSubjects.click('optionsList-control-0');
await testSubjects.click(`optionsList-control-selection-${alertStatus}`);
await testSubjects.click('optionsList-control-0');
};

const alertDataHasLoaded = async () => {
await retry.waitFor(
'Alert Table is loaded',
async () => await testSubjects.exists('events-container-loading-false', { timeout: 2500 })
async () => await testSubjects.exists('alertsTableIsLoaded', { timeout: 2500 })
);
};

Expand Down Expand Up @@ -439,7 +441,6 @@ export function ObservabilityAlertsCommonProvider({
setWorkflowStatusFilter,
getWorkflowStatusFilterValue,
setAlertStatusFilter,
alertDataIsBeingLoaded,
alertDataHasLoaded,
submitQuery,
typeInQueryBar,
Expand All @@ -457,5 +458,6 @@ export function ObservabilityAlertsCommonProvider({
navigateToAlertDetails,
createDataView,
deleteDataView,
selectAlertStatusFilter,
};
}
13 changes: 6 additions & 7 deletions ...observability/test/observability_functional/apps/observability/pages/alerts/pagination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,13 @@ export default ({ getService }: FtrProviderContext) => {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/120440
describe.skip('Pagination controls', () => {
describe('Pagination controls', () => {
before(async () => {
await (await observability.alerts.pagination.getPageSizeSelector()).click();
await (await observability.alerts.pagination.getTenRowsPageSelector()).click();
await observability.alerts.common.selectAlertStatusFilter('recovered');
await retry.try(async () => {
await (await observability.alerts.pagination.getPageSizeSelector()).click();
await (await observability.alerts.pagination.getTenRowsPageSelector()).click();
});
await observability.alerts.pagination.goToFirstPage();
});

Expand All @@ -113,23 +115,20 @@ export default ({ getService }: FtrProviderContext) => {

it('Goes to nth page', async () => {
await observability.alerts.pagination.goToNthPage(3);
await observability.alerts.common.alertDataIsBeingLoaded();
await observability.alerts.common.alertDataHasLoaded();
const tableRows = await observability.alerts.common.getTableCellsInRows();
expect(tableRows.length).to.be(10);
});

it('Goes to next page', async () => {
await observability.alerts.pagination.goToNextPage();
await observability.alerts.common.alertDataIsBeingLoaded();
await observability.alerts.common.alertDataHasLoaded();
const tableRows = await observability.alerts.common.getTableCellsInRows();
expect(tableRows.length).to.be(10);
});

it('Goes to previous page', async () => {
await observability.alerts.pagination.goToPrevPage();
await observability.alerts.common.alertDataIsBeingLoaded();
await observability.alerts.common.alertDataHasLoaded();
const tableRows = await observability.alerts.common.getTableCellsInRows();
expect(tableRows.length).to.be(10);
Expand Down