Skip to content

Comments

[8.19] [Alerts table] Unskipped pagination test (#227486)#227917

Merged
cesco-f merged 4 commits intoelastic:8.19from
cesco-f:backport/8.19/pr-227486
Jul 16, 2025
Merged

[8.19] [Alerts table] Unskipped pagination test (#227486)#227917
cesco-f merged 4 commits intoelastic:8.19from
cesco-f:backport/8.19/pr-227486

Conversation

@cesco-f
Copy link
Contributor

@cesco-f cesco-f commented Jul 15, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

This PR closes elastic#120440 .

This test was skipped a long time ago and several things changed since
then.
The main thing is that the container that shows the alerts changed, now
it's a component that shows a `data-test-subj` equal to
`internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when
the alerts have been loaded.

The component shown when alerts are being loaded is not always shown,
probably for some caching, so I removed the `alertDataIsBeingLodaded`
check.

I also had to add a function to include the `recovered` alerts because
the `active` alerts in the test data are only 10 and the pagination
cannot work with just 10 alerts.

(cherry picked from commit ca9a70b)

# Conflicts:
#	x-pack/solutions/observability/test/functional/services/observability/alerts/common.ts
@cesco-f cesco-f requested a review from kibanamachine as a code owner July 15, 2025 06:02
@cesco-f cesco-f added the backport This PR is a backport of another PR label Jul 15, 2025
@cesco-f cesco-f enabled auto-merge (squash) July 15, 2025 06:02
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 15, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 15, 2025

💚 Build Succeeded

  • Buildkite Build
  • Commit: 5c937de
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-227917-5c937de5cb3a

Metrics [docs]

✅ unchanged

History

@cesco-f cesco-f merged commit c9a3a19 into elastic:8.19 Jul 16, 2025
7 of 8 checks passed
@cesco-f cesco-f deleted the backport/8.19/pr-227486 branch July 16, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants