[8.19] [Alerts table] Unskipped pagination test (#227486)#227917
Merged
cesco-f merged 4 commits intoelastic:8.19from Jul 16, 2025
Merged
[8.19] [Alerts table] Unskipped pagination test (#227486)#227917cesco-f merged 4 commits intoelastic:8.19from
cesco-f merged 4 commits intoelastic:8.19from
Conversation
This PR closes elastic#120440 . This test was skipped a long time ago and several things changed since then. The main thing is that the container that shows the alerts changed, now it's a component that shows a `data-test-subj` equal to `internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when the alerts have been loaded. The component shown when alerts are being loaded is not always shown, probably for some caching, so I removed the `alertDataIsBeingLodaded` check. I also had to add a function to include the `recovered` alerts because the `active` alerts in the test data are only 10 and the pagination cannot work with just 10 alerts. (cherry picked from commit ca9a70b) # Conflicts: # x-pack/solutions/observability/test/functional/services/observability/alerts/common.ts
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
fkanout
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation