[Lens] Fix secondary metric styles to prevent wrapping#227234
Merged
mariairiartef merged 7 commits intoelastic:mainfrom Jul 14, 2025
Merged
[Lens] Fix secondary metric styles to prevent wrapping#227234mariairiartef merged 7 commits intoelastic:mainfrom
mariairiartef merged 7 commits intoelastic:mainfrom
Conversation
mariairiartef
added
Feature:Lens
v9.1.0
v8.19.0
v9.2.0
bug
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
reviewed
Jul 10, 2025
...orm/plugins/shared/chart_expressions/expression_metric/public/components/metric_vis.test.tsx
Outdated
Show resolved
Hide resolved
...orm/plugins/shared/chart_expressions/expression_metric/public/components/metric_vis.test.tsx
Outdated
Show resolved
Hide resolved
markov00
added
release_note:fix
and removed
release_note:skip
|
From the purely design/visual perspective everything seems to work fine! |
markov00
approved these changes
Jul 10, 2025
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Tested locally works great!
gvnmagni
approved these changes
Jul 10, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16262151325 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2025
Closes elastic#226208 ## Summary The secondary metric component stays on a single line with proper text overflow handling, while giving priority to the value/badge over the prefix when space is limited. <img width="1080" alt="Screenshot 2025-07-09 at 14 20 20" src="https://github.com/user-attachments/assets/dc6cc536-eb74-411d-9237-16ae6713e33e" /> #### The value/badge can take the whole width <img width="316" alt="Screenshot 2025-07-09 at 14 16 38" src="https://github.com/user-attachments/assets/1257b677-0983-43c3-a39f-ae038716651b" /> ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit c238ede)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mariairiartef
added a commit
to mariairiartef/kibana
that referenced
this pull request
Jul 16, 2025
Closes elastic#226208 ## Summary The secondary metric component stays on a single line with proper text overflow handling, while giving priority to the value/badge over the prefix when space is limited. <img width="1080" alt="Screenshot 2025-07-09 at 14 20 20" src="https://github.com/user-attachments/assets/dc6cc536-eb74-411d-9237-16ae6713e33e" /> #### The value/badge can take the whole width <img width="316" alt="Screenshot 2025-07-09 at 14 16 38" src="https://github.com/user-attachments/assets/1257b677-0983-43c3-a39f-ae038716651b" /> ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit c238ede) # Conflicts: # src/platform/plugins/shared/chart_expressions/expression_metric/public/components/secondary_metric.test.tsx
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
2 similar comments
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
mariairiartef
added a commit
that referenced
this pull request
Jul 22, 2025
… (#228188) # Backport This will backport the following commits from `main` to `8.19`: - [[Lens] Fix secondary metric styles to prevent wrapping (#227234)](#227234) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maria Iriarte","email":"106958839+mariairiartef@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-14T08:39:53Z","message":"[Lens] Fix secondary metric styles to prevent wrapping (#227234)\n\nCloses https://github.com/elastic/kibana/issues/226208\n\n## Summary\n\nThe secondary metric component stays on a single line with proper text\noverflow handling, while giving priority to the value/badge over the\nprefix when space is limited.\n\n<img width=\"1080\" alt=\"Screenshot 2025-07-09 at 14 20 20\"\nsrc=\"https://github.com/user-attachments/assets/dc6cc536-eb74-411d-9237-16ae6713e33e\"\n/>\n\n#### The value/badge can take the whole width\n\n<img width=\"316\" alt=\"Screenshot 2025-07-09 at 14 16 38\"\nsrc=\"https://github.com/user-attachments/assets/1257b677-0983-43c3-a39f-ae038716651b\"\n/>\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"c238ede3d4ac816fce88d6c96ecc1f5445a6414a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Visualizations","Feature:Lens","backport missing","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Lens] Fix secondary metric styles to prevent wrapping","number":227234,"url":"https://github.com/elastic/kibana/pull/227234","mergeCommit":{"message":"[Lens] Fix secondary metric styles to prevent wrapping (#227234)\n\nCloses https://github.com/elastic/kibana/issues/226208\n\n## Summary\n\nThe secondary metric component stays on a single line with proper text\noverflow handling, while giving priority to the value/badge over the\nprefix when space is limited.\n\n<img width=\"1080\" alt=\"Screenshot 2025-07-09 at 14 20 20\"\nsrc=\"https://github.com/user-attachments/assets/dc6cc536-eb74-411d-9237-16ae6713e33e\"\n/>\n\n#### The value/badge can take the whole width\n\n<img width=\"316\" alt=\"Screenshot 2025-07-09 at 14 16 38\"\nsrc=\"https://github.com/user-attachments/assets/1257b677-0983-43c3-a39f-ae038716651b\"\n/>\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"c238ede3d4ac816fce88d6c96ecc1f5445a6414a"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/227767","number":227767,"state":"OPEN"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227234","number":227234,"mergeCommit":{"message":"[Lens] Fix secondary metric styles to prevent wrapping (#227234)\n\nCloses https://github.com/elastic/kibana/issues/226208\n\n## Summary\n\nThe secondary metric component stays on a single line with proper text\noverflow handling, while giving priority to the value/badge over the\nprefix when space is limited.\n\n<img width=\"1080\" alt=\"Screenshot 2025-07-09 at 14 20 20\"\nsrc=\"https://github.com/user-attachments/assets/dc6cc536-eb74-411d-9237-16ae6713e33e\"\n/>\n\n#### The value/badge can take the whole width\n\n<img width=\"316\" alt=\"Screenshot 2025-07-09 at 14 16 38\"\nsrc=\"https://github.com/user-attachments/assets/1257b677-0983-43c3-a39f-ae038716651b\"\n/>\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"c238ede3d4ac816fce88d6c96ecc1f5445a6414a"}}]}] BACKPORT-->
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
2 similar comments
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
Closes elastic#226208 ## Summary The secondary metric component stays on a single line with proper text overflow handling, while giving priority to the value/badge over the prefix when space is limited. <img width="1080" alt="Screenshot 2025-07-09 at 14 20 20" src="https://github.com/user-attachments/assets/dc6cc536-eb74-411d-9237-16ae6713e33e" /> #### The value/badge can take the whole width <img width="316" alt="Screenshot 2025-07-09 at 14 16 38" src="https://github.com/user-attachments/assets/1257b677-0983-43c3-a39f-ae038716651b" /> ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mariairiartef
added a commit
to mariairiartef/kibana
that referenced
this pull request
Jul 28, 2025
Closes elastic#226208 ## Summary The secondary metric component stays on a single line with proper text overflow handling, while giving priority to the value/badge over the prefix when space is limited. <img width="1080" alt="Screenshot 2025-07-09 at 14 20 20" src="https://github.com/user-attachments/assets/dc6cc536-eb74-411d-9237-16ae6713e33e" /> #### The value/badge can take the whole width <img width="316" alt="Screenshot 2025-07-09 at 14 16 38" src="https://github.com/user-attachments/assets/1257b677-0983-43c3-a39f-ae038716651b" /> ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit c238ede)
mariairiartef
added a commit
that referenced
this pull request
Jul 28, 2025
#229564) # Backport This will backport the following commits from `main` to `9.1`: - [[Lens] Fix secondary metric styles to prevent wrapping (#227234)](#227234) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maria Iriarte","email":"106958839+mariairiartef@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-14T08:39:53Z","message":"[Lens] Fix secondary metric styles to prevent wrapping (#227234)\n\nCloses https://github.com/elastic/kibana/issues/226208\n\n## Summary\n\nThe secondary metric component stays on a single line with proper text\noverflow handling, while giving priority to the value/badge over the\nprefix when space is limited.\n\n<img width=\"1080\" alt=\"Screenshot 2025-07-09 at 14 20 20\"\nsrc=\"https://github.com/user-attachments/assets/dc6cc536-eb74-411d-9237-16ae6713e33e\"\n/>\n\n#### The value/badge can take the whole width\n\n<img width=\"316\" alt=\"Screenshot 2025-07-09 at 14 16 38\"\nsrc=\"https://github.com/user-attachments/assets/1257b677-0983-43c3-a39f-ae038716651b\"\n/>\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"c238ede3d4ac816fce88d6c96ecc1f5445a6414a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Visualizations","Feature:Lens","backport missing","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Lens] Fix secondary metric styles to prevent wrapping","number":227234,"url":"https://github.com/elastic/kibana/pull/227234","mergeCommit":{"message":"[Lens] Fix secondary metric styles to prevent wrapping (#227234)\n\nCloses https://github.com/elastic/kibana/issues/226208\n\n## Summary\n\nThe secondary metric component stays on a single line with proper text\noverflow handling, while giving priority to the value/badge over the\nprefix when space is limited.\n\n<img width=\"1080\" alt=\"Screenshot 2025-07-09 at 14 20 20\"\nsrc=\"https://github.com/user-attachments/assets/dc6cc536-eb74-411d-9237-16ae6713e33e\"\n/>\n\n#### The value/badge can take the whole width\n\n<img width=\"316\" alt=\"Screenshot 2025-07-09 at 14 16 38\"\nsrc=\"https://github.com/user-attachments/assets/1257b677-0983-43c3-a39f-ae038716651b\"\n/>\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"c238ede3d4ac816fce88d6c96ecc1f5445a6414a"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/228188","number":228188,"state":"MERGED","mergeCommit":{"sha":"be0f29268950f326aeef95ff3d1ecc612ac7c750","message":"[8.19] [Lens] Fix secondary metric styles to prevent wrapping (#227234) (#228188)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Lens] Fix secondary metric styles to prevent wrapping\n(#227234)](https://github.com/elastic/kibana/pull/227234)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227234","number":227234,"mergeCommit":{"message":"[Lens] Fix secondary metric styles to prevent wrapping (#227234)\n\nCloses https://github.com/elastic/kibana/issues/226208\n\n## Summary\n\nThe secondary metric component stays on a single line with proper text\noverflow handling, while giving priority to the value/badge over the\nprefix when space is limited.\n\n<img width=\"1080\" alt=\"Screenshot 2025-07-09 at 14 20 20\"\nsrc=\"https://github.com/user-attachments/assets/dc6cc536-eb74-411d-9237-16ae6713e33e\"\n/>\n\n#### The value/badge can take the whole width\n\n<img width=\"316\" alt=\"Screenshot 2025-07-09 at 14 16 38\"\nsrc=\"https://github.com/user-attachments/assets/1257b677-0983-43c3-a39f-ae038716651b\"\n/>\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"c238ede3d4ac816fce88d6c96ecc1f5445a6414a"}}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #226208
Summary
The secondary metric component stays on a single line with proper text overflow handling, while giving priority to the value/badge over the prefix when space is limited.
The value/badge can take the whole width
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.