Skip to content

Comments

[ska] relocate functional platform tests#226470

Merged
dmlemeshko merged 6 commits intoelastic:mainfrom
dmlemeshko:ska/relocate-functional-tests
Jul 4, 2025
Merged

[ska] relocate functional platform tests#226470
dmlemeshko merged 6 commits intoelastic:mainfrom
dmlemeshko:ska/relocate-functional-tests

Conversation

@dmlemeshko
Copy link
Contributor

@dmlemeshko dmlemeshko commented Jul 3, 2025

Summary

Part of https://github.com/elastic/kibana-team/issues/1503

This PR is mostly about moving platform tests from x-pack/test

x-pack/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/

After:

x-pack/platform/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/

@dmlemeshko dmlemeshko self-assigned this Jul 3, 2025
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v8.19.0 v9.2.0 labels Jul 3, 2025
@dmlemeshko dmlemeshko marked this pull request as ready for review July 3, 2025 19:55
@dmlemeshko dmlemeshko requested review from a team as code owners July 3, 2025 19:55
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack 182 164 -18
@kbn/test-suites-xpack-platform 505 523 +18
total -0

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack 196 178 -18
@kbn/test-suites-xpack-platform 512 530 +18
total -0

History

cc @dmlemeshko

@csr csr self-requested a review July 4, 2025 08:31
Copy link
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dmlemeshko dmlemeshko merged commit ab965f5 into elastic:main Jul 4, 2025
15 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16077872587

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 4, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving platform tests from x-pack/test

```
x-pack/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/
```

After:
```
x-pack/platform/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit ab965f5)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [ska] relocate platform security & localization tests (#226465)
- [ska][x-pack] Move saved_objects_management, saved_query_management and snapshot_restore to platform
- [ska][x-pack] relocate spaces_api_integration tests (#225377)
- [ska] remove 'test-suites-xpack-observability' imports in x-pack/test (#226174)
- [ska][x-pack] Move canvas, watcher and dev_tools functional tests
- [ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)
- [ska] relocate api_integration_basic & defend_workflows_cypress tests (#225374)
- Move apps/security and apps/spaces tests under platform
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 226470

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 4, 2025
# Backport

This will backport the following commits from `main` to `9.1`:
- [[ska] relocate functional platform tests
(#226470)](#226470)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-04T16:33:33Z","message":"[ska]
relocate functional platform tests (#226470)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving platform tests from x-pack/test\n\n```\nx-pack/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\nAfter: \n```\nx-pack/platform/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ab965f53604cf5cd94a4f282c5e832964abfec39","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ska]
relocate functional platform
tests","number":226470,"url":"https://github.com/elastic/kibana/pull/226470","mergeCommit":{"message":"[ska]
relocate functional platform tests (#226470)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving platform tests from x-pack/test\n\n```\nx-pack/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\nAfter: \n```\nx-pack/platform/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ab965f53604cf5cd94a4f282c5e832964abfec39"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226470","number":226470,"mergeCommit":{"message":"[ska]
relocate functional platform tests (#226470)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving platform tests from x-pack/test\n\n```\nx-pack/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\nAfter: \n```\nx-pack/platform/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ab965f53604cf5cd94a4f282c5e832964abfec39"}}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
adcoelho pushed a commit to adcoelho/kibana that referenced this pull request Jul 7, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving platform tests from x-pack/test

```
x-pack/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/
```

After: 
```
x-pack/platform/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@dmlemeshko dmlemeshko added backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Jul 8, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16142801518

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [ska][x-pack] Move saved_objects_management, saved_query_management and snapshot_restore to platform
- [ska][x-pack] relocate spaces_api_integration tests (#225377)
- Move test utils from legacy api to agnostic (#224381)
- [ska][x-pack] Move canvas, watcher and dev_tools functional tests
- Move apps/security and apps/spaces tests under platform
9.1 Cherrypick failed because the selected commit (ab965f5) is empty. It looks like the commit was already backported in #226621

Manual backport

To create the backport manually run:

node scripts/backport --pr 226470

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 8, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving platform tests from x-pack/test

```
x-pack/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/
```

After:
```
x-pack/platform/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit ab965f5)

# Conflicts:
#	.github/CODEOWNERS
@dmlemeshko
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 9, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @dmlemeshko

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @dmlemeshko

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 10, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving platform tests from x-pack/test

```
x-pack/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/
```

After:
```
x-pack/platform/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit ab965f5)

# Conflicts:
#	.buildkite/ftr_platform_stateful_configs.yml
#	.github/CODEOWNERS
@dmlemeshko
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@dmlemeshko dmlemeshko removed the v9.2.0 label Jul 10, 2025
dmlemeshko added a commit that referenced this pull request Jul 11, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[ska] relocate functional platform tests
(#226470)](#226470)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-04T16:33:33Z","message":"[ska]
relocate functional platform tests (#226470)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving platform tests from x-pack/test\n\n```\nx-pack/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\nAfter: \n```\nx-pack/platform/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ab965f53604cf5cd94a4f282c5e832964abfec39","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ska]
relocate functional platform
tests","number":226470,"url":"https://github.com/elastic/kibana/pull/226470","mergeCommit":{"message":"[ska]
relocate functional platform tests (#226470)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving platform tests from x-pack/test\n\n```\nx-pack/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\nAfter: \n```\nx-pack/platform/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ab965f53604cf5cd94a4f282c5e832964abfec39"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226621","number":226621,"state":"MERGED","mergeCommit":{"sha":"68aceada5f42231ec1d4e8dd29e411e259c9bbb9","message":"[9.1]
[ska] relocate functional platform tests (#226470) (#226621)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`9.1`:\n- [[ska] relocate functional platform
tests\n(#226470)](https://github.com/elastic/kibana/pull/226470)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Dzmitry Lemechko
<dzmitry.lemechko@elastic.co>"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226470","number":226470,"mergeCommit":{"message":"[ska]
relocate functional platform tests (#226470)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving platform tests from x-pack/test\n\n```\nx-pack/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\nAfter: \n```\nx-pack/platform/test/\n | -
examples/\n | - functional_cors/\n | -
functional_embedded/\n```\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ab965f53604cf5cd94a4f282c5e832964abfec39"}}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 11, 2025
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving platform tests from x-pack/test

```
x-pack/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/
```

After: 
```
x-pack/platform/test/
     | - examples/
     | - functional_cors/
     | - functional_embedded/
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.