[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir#225438
Merged
pheyos merged 6 commits intoelastic:mainfrom Jun 27, 2025
Merged
Conversation
dmlemeshko
commented
Jun 26, 2025
| this.tags(['failsOnMKI']); | ||
| before(async () => { | ||
| await PageObjects.svlCommonPage.loginWithRole(ServerlessRoleName.PLATFORM_ENGINEER); | ||
| await PageObjects.svlCommonPage.loginWithRole('platform_engineer'); |
Contributor
Author
There was a problem hiding this comment.
I think we are safe with hardcoded value to avoid extra imports
Contributor
There was a problem hiding this comment.
was it causing a circular dependency issue?
Contributor
Author
There was a problem hiding this comment.
yes, importing from kbn/test-suites-serverless is the only obvious reason to face this:
Project references may not form a circular graph. Cycle detected: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1750917190110240407/elastic/kibana-pull-request/kibana/tsconfig.refs.json
--
kibana/x-pack/platform/plugins/shared/osquery/cypress/tsconfig.type_check.json
kibana/x-pack/test_serverless/tsconfig.type_check.json
kibana/x-pack/test/tsconfig.type_check.json
kibana/x-pack/solutions/observability/test/tsconfig.type_check.json
kibana/x-pack/platform/test/tsconfig.type_check.json
dmlemeshko
added
release_note:skip
PhilippeOberti
approved these changes
Jun 27, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
cc @dmlemeshko |
This was referenced Jun 27, 2025
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 7, 2025
…elastic#225438) ## Summary This PR removes `kbn/test-suites-serverless` as kbn reference for osquery/cypress test-helper module in order to fix circular dependency I faced in elastic#225377 Since the main consumer of that `shared/lib/security` code is `osquery/cypress` test module, I believe it is a resonable change in order to unblock us relocating tests from `x-pack/test` dir. (cherry picked from commit 10cc7b3)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 7, 2025
…elastic#225438) ## Summary This PR removes `kbn/test-suites-serverless` as kbn reference for osquery/cypress test-helper module in order to fix circular dependency I faced in elastic#225377 Since the main consumer of that `shared/lib/security` code is `osquery/cypress` test module, I believe it is a resonable change in order to unblock us relocating tests from `x-pack/test` dir. (cherry picked from commit 10cc7b3)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 8, 2025
…elastic#225438) ## Summary This PR removes `kbn/test-suites-serverless` as kbn reference for osquery/cypress test-helper module in order to fix circular dependency I faced in elastic#225377 Since the main consumer of that `shared/lib/security` code is `osquery/cypress` test module, I believe it is a resonable change in order to unblock us relocating tests from `x-pack/test` dir. (cherry picked from commit 10cc7b3)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
that referenced
this pull request
Jul 8, 2025
…s' dir (#225438) (#226802) # Backport This will backport the following commits from `main` to `9.1`: - [[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)](#225438) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-06-27T12:50:52Z","message":"[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)\n\n## Summary\n\nThis PR removes `kbn/test-suites-serverless` as kbn reference for\nosquery/cypress test-helper module in order to fix circular dependency I\nfaced in https://github.com/elastic/kibana/pull/225377\n\nSince the main consumer of that `shared/lib/security` code is\n`osquery/cypress` test module, I believe it is a resonable change in\norder to unblock us relocating tests from `x-pack/test` dir.","sha":"10cc7b3c62cdd4346792fefa2d403d3ddf759e6a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.1.0","v8.19.0","v9.2.0"],"title":"[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir","number":225438,"url":"https://github.com/elastic/kibana/pull/225438","mergeCommit":{"message":"[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)\n\n## Summary\n\nThis PR removes `kbn/test-suites-serverless` as kbn reference for\nosquery/cypress test-helper module in order to fix circular dependency I\nfaced in https://github.com/elastic/kibana/pull/225377\n\nSince the main consumer of that `shared/lib/security` code is\n`osquery/cypress` test module, I believe it is a resonable change in\norder to unblock us relocating tests from `x-pack/test` dir.","sha":"10cc7b3c62cdd4346792fefa2d403d3ddf759e6a"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225438","number":225438,"mergeCommit":{"message":"[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)\n\n## Summary\n\nThis PR removes `kbn/test-suites-serverless` as kbn reference for\nosquery/cypress test-helper module in order to fix circular dependency I\nfaced in https://github.com/elastic/kibana/pull/225377\n\nSince the main consumer of that `shared/lib/security` code is\n`osquery/cypress` test module, I believe it is a resonable change in\norder to unblock us relocating tests from `x-pack/test` dir.","sha":"10cc7b3c62cdd4346792fefa2d403d3ddf759e6a"}}]}] BACKPORT-->
dmlemeshko
added a commit
that referenced
this pull request
Jul 8, 2025
…ss' dir (#225438) (#226803) # Backport This will backport the following commits from `main` to `8.19`: - [[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)](#225438) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-06-27T12:50:52Z","message":"[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)\n\n## Summary\n\nThis PR removes `kbn/test-suites-serverless` as kbn reference for\nosquery/cypress test-helper module in order to fix circular dependency I\nfaced in https://github.com/elastic/kibana/pull/225377\n\nSince the main consumer of that `shared/lib/security` code is\n`osquery/cypress` test module, I believe it is a resonable change in\norder to unblock us relocating tests from `x-pack/test` dir.","sha":"10cc7b3c62cdd4346792fefa2d403d3ddf759e6a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.1.0","v8.19.0","v9.2.0"],"title":"[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir","number":225438,"url":"https://github.com/elastic/kibana/pull/225438","mergeCommit":{"message":"[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)\n\n## Summary\n\nThis PR removes `kbn/test-suites-serverless` as kbn reference for\nosquery/cypress test-helper module in order to fix circular dependency I\nfaced in https://github.com/elastic/kibana/pull/225377\n\nSince the main consumer of that `shared/lib/security` code is\n`osquery/cypress` test module, I believe it is a resonable change in\norder to unblock us relocating tests from `x-pack/test` dir.","sha":"10cc7b3c62cdd4346792fefa2d403d3ddf759e6a"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226802","number":226802,"state":"OPEN"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225438","number":225438,"mergeCommit":{"message":"[ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)\n\n## Summary\n\nThis PR removes `kbn/test-suites-serverless` as kbn reference for\nosquery/cypress test-helper module in order to fix circular dependency I\nfaced in https://github.com/elastic/kibana/pull/225377\n\nSince the main consumer of that `shared/lib/security` code is\n`osquery/cypress` test module, I believe it is a resonable change in\norder to unblock us relocating tests from `x-pack/test` dir.","sha":"10cc7b3c62cdd4346792fefa2d403d3ddf759e6a"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
kbn/test-suites-serverlessas kbn reference for osquery/cypress test-helper module in order to fix circular dependency I faced in #225377Since the main consumer of that
shared/lib/securitycode isosquery/cypresstest module, I believe it is a resonable change in order to unblock us relocating tests fromx-pack/testdir.