Skip to content

[ska][x-pack] relocate spaces_api_integration tests#225377

Merged
dmlemeshko merged 24 commits intoelastic:mainfrom
dmlemeshko:ska/relocate-spaces_api_integration
Jul 3, 2025
Merged

[ska][x-pack] relocate spaces_api_integration tests#225377
dmlemeshko merged 24 commits intoelastic:mainfrom
dmlemeshko:ska/relocate-spaces_api_integration

Conversation

@dmlemeshko
Copy link
Contributor

@dmlemeshko dmlemeshko commented Jun 25, 2025

Summary

Part of https://github.com/elastic/kibana-team/issues/1503

This PR is mostly about moving tests from x-pack/test/

Before:

x-pack/test/
     | - spaces_api_integration/

After:

x-pack/platform/test/
     | - spaces_api_integration/

deployment-agnostic base configs were relocated together with serverless base config in order to resolve circular dependency. We will remove duplicates as soon as we finish relocation

@dmlemeshko dmlemeshko self-assigned this Jun 26, 2025
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.1.0 v8.19.0 labels Jun 26, 2025
@dmlemeshko dmlemeshko marked this pull request as ready for review June 26, 2025 05:47
@dmlemeshko dmlemeshko requested review from a team as code owners June 26, 2025 05:47
@dmlemeshko dmlemeshko marked this pull request as draft June 26, 2025 05:59
…m:dmlemeshko/kibana into ska/relocate-spaces_api_integration
pheyos pushed a commit that referenced this pull request Jun 27, 2025
…#225438)

## Summary

This PR removes `kbn/test-suites-serverless` as kbn reference for
osquery/cypress test-helper module in order to fix circular dependency I
faced in #225377

Since the main consumer of that `shared/lib/security` code is
`osquery/cypress` test module, I believe it is a resonable change in
order to unblock us relocating tests from `x-pack/test` dir.
@dmlemeshko dmlemeshko enabled auto-merge (squash) July 3, 2025 10:25
@dmlemeshko dmlemeshko merged commit 8c14476 into elastic:main Jul 3, 2025
13 checks passed
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 7, 2025
…elastic#225438)

## Summary

This PR removes `kbn/test-suites-serverless` as kbn reference for
osquery/cypress test-helper module in order to fix circular dependency I
faced in elastic#225377

Since the main consumer of that `shared/lib/security` code is
`osquery/cypress` test module, I believe it is a resonable change in
order to unblock us relocating tests from `x-pack/test` dir.

(cherry picked from commit 10cc7b3)
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 7, 2025
…elastic#225438)

## Summary

This PR removes `kbn/test-suites-serverless` as kbn reference for
osquery/cypress test-helper module in order to fix circular dependency I
faced in elastic#225377

Since the main consumer of that `shared/lib/security` code is
`osquery/cypress` test module, I believe it is a resonable change in
order to unblock us relocating tests from `x-pack/test` dir.

(cherry picked from commit 10cc7b3)
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 8, 2025
…elastic#225438)

## Summary

This PR removes `kbn/test-suites-serverless` as kbn reference for
osquery/cypress test-helper module in order to fix circular dependency I
faced in elastic#225377

Since the main consumer of that `shared/lib/security` code is
`osquery/cypress` test module, I believe it is a resonable change in
order to unblock us relocating tests from `x-pack/test` dir.

(cherry picked from commit 10cc7b3)
@dmlemeshko dmlemeshko added v9.1.0 backport:version Backport to applied version labels and removed backport:skip This PR does not require backporting labels Jul 9, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16170532625

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16170532628

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 225377

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 225377

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 9, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving tests from x-pack/test/

Before:

```
x-pack/test/
     | - spaces_api_integration/
```

After:
```
x-pack/platform/test/
     | - spaces_api_integration/
```

deployment-agnostic base configs were relocated together with serverless
base config in order to resolve circular dependency. We will remove
duplicates as soon as we finish relocation

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8c14476)

# Conflicts:
#	.github/CODEOWNERS
@dmlemeshko
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit that referenced this pull request Jul 9, 2025
…227260)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[ska][x-pack] relocate spaces_api_integration tests
(#225377)](#225377)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-03T11:53:36Z","message":"[ska][x-pack]
relocate spaces_api_integration tests (#225377)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving tests from x-pack/test/\n\nBefore:\n\n```\nx-pack/test/\n |
- spaces_api_integration/\n```\n\nAfter: \n```\nx-pack/platform/test/\n
| - spaces_api_integration/\n```\n\ndeployment-agnostic base configs
were relocated together with serverless\nbase config in order to resolve
circular dependency. We will remove\nduplicates as soon as we finish
relocation\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8c144762dbdd8c64034a46fb012f8e56f233efa7","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ska][x-pack]
relocate spaces_api_integration
tests","number":225377,"url":"https://github.com/elastic/kibana/pull/225377","mergeCommit":{"message":"[ska][x-pack]
relocate spaces_api_integration tests (#225377)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving tests from x-pack/test/\n\nBefore:\n\n```\nx-pack/test/\n |
- spaces_api_integration/\n```\n\nAfter: \n```\nx-pack/platform/test/\n
| - spaces_api_integration/\n```\n\ndeployment-agnostic base configs
were relocated together with serverless\nbase config in order to resolve
circular dependency. We will remove\nduplicates as soon as we finish
relocation\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8c144762dbdd8c64034a46fb012f8e56f233efa7"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225377","number":225377,"mergeCommit":{"message":"[ska][x-pack]
relocate spaces_api_integration tests (#225377)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving tests from x-pack/test/\n\nBefore:\n\n```\nx-pack/test/\n |
- spaces_api_integration/\n```\n\nAfter: \n```\nx-pack/platform/test/\n
| - spaces_api_integration/\n```\n\ndeployment-agnostic base configs
were relocated together with serverless\nbase config in order to resolve
circular dependency. We will remove\nduplicates as soon as we finish
relocation\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8c144762dbdd8c64034a46fb012f8e56f233efa7"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko added a commit that referenced this pull request Jul 15, 2025
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving tests from x-pack/test/

Before:

```
x-pack/test/
     | - spaces_api_integration/
```

After: 
```
x-pack/platform/test/
     | - spaces_api_integration/
```

deployment-agnostic base configs were relocated together with serverless
base config in order to resolve circular dependency. We will remove
duplicates as soon as we finish relocation

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants