[ska] remove 'test-suites-xpack-observability' imports in x-pack/test#226174
Merged
dmlemeshko merged 2 commits intoelastic:mainfrom Jul 2, 2025
Merged
Conversation
dmlemeshko
added
release_note:skip
botelastic
bot
added
ci:project-deploy-observability
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
fake-haris
approved these changes
Jul 2, 2025
jennypavlova
approved these changes
Jul 2, 2025
Member
jennypavlova
left a comment
jennypavlova
left a comment
There was a problem hiding this comment.
Obs UX infra and services changes LGTM 🚀
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
cc @dmlemeshko |
This was referenced Jul 3, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 7, 2025
…elastic#226174) ## Summary PR is a temporarily workaround to unblock us with SKA test relocation. In one of my previous PRs to avoid code duplication I updated imports to use newly created `@kbn/test-suites-xpack-observability` module, sadly it led to circular dependency issue in test modules. Here I copy some helpers back to x-pack/test to unblock us, will be removed when we done with tests relocation. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 9426c26) # Conflicts: # .github/CODEOWNERS
dmlemeshko
added a commit
that referenced
this pull request
Jul 7, 2025
…ck/test (#226174) (#226772) # Backport This will backport the following commits from `main` to `8.19`: - [[ska] remove 'test-suites-xpack-observability' imports in x-pack/test (#226174)](#226174) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T14:22:56Z","message":"[ska] remove 'test-suites-xpack-observability' imports in x-pack/test (#226174)\n\n## Summary\n\nPR is a temporarily workaround to unblock us with SKA test relocation.\n\nIn one of my previous PRs to avoid code duplication I updated imports to\nuse newly created `@kbn/test-suites-xpack-observability` module, sadly\nit led to circular dependency issue in test modules. Here I copy some\nhelpers back to x-pack/test to unblock us, will be removed when we done\nwith tests relocation.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"9426c26e285c66c1d3254ff6365dbf2e5917ff04","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","8.0 candidate","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.19.0","v9.2.0"],"title":"[ska] remove 'test-suites-xpack-observability' imports in x-pack/test","number":226174,"url":"https://github.com/elastic/kibana/pull/226174","mergeCommit":{"message":"[ska] remove 'test-suites-xpack-observability' imports in x-pack/test (#226174)\n\n## Summary\n\nPR is a temporarily workaround to unblock us with SKA test relocation.\n\nIn one of my previous PRs to avoid code duplication I updated imports to\nuse newly created `@kbn/test-suites-xpack-observability` module, sadly\nit led to circular dependency issue in test modules. Here I copy some\nhelpers back to x-pack/test to unblock us, will be removed when we done\nwith tests relocation.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"9426c26e285c66c1d3254ff6365dbf2e5917ff04"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226174","number":226174,"mergeCommit":{"message":"[ska] remove 'test-suites-xpack-observability' imports in x-pack/test (#226174)\n\n## Summary\n\nPR is a temporarily workaround to unblock us with SKA test relocation.\n\nIn one of my previous PRs to avoid code duplication I updated imports to\nuse newly created `@kbn/test-suites-xpack-observability` module, sadly\nit led to circular dependency issue in test modules. Here I copy some\nhelpers back to x-pack/test to unblock us, will be removed when we done\nwith tests relocation.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"9426c26e285c66c1d3254ff6365dbf2e5917ff04"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko
added
v9.1.0
backport:version
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16215901708 |
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16215902314 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Jul 15, 2025
dmlemeshko
added
backport:version
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16319493160 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…elastic#226174) ## Summary PR is a temporarily workaround to unblock us with SKA test relocation. In one of my previous PRs to avoid code duplication I updated imports to use newly created `@kbn/test-suites-xpack-observability` module, sadly it led to circular dependency issue in test modules. Here I copy some helpers back to x-pack/test to unblock us, will be removed when we done with tests relocation. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR is a temporarily workaround to unblock us with SKA test relocation.
In one of my previous PRs to avoid code duplication I updated imports to use newly created
@kbn/test-suites-xpack-observabilitymodule, sadly it led to circular dependency issue in test modules. Here I copy some helpers back to x-pack/test to unblock us, will be removed when we done with tests relocation.