Skip to content

Comments

chore(security, tests): Add testCategory to cookie and shard missing tests#226786

Merged
SiddharthMantri merged 1 commit intoelastic:mainfrom
SiddharthMantri:chore-security-update-test-categories
Jul 7, 2025
Merged

chore(security, tests): Add testCategory to cookie and shard missing tests#226786
SiddharthMantri merged 1 commit intoelastic:mainfrom
SiddharthMantri:chore-security-update-test-categories

Conversation

@SiddharthMantri
Copy link
Contributor

@SiddharthMantri SiddharthMantri commented Jul 7, 2025 •
edited by kibanamachine
Loading

Summary

Add testCategory for Session Cookies and Session Index shard missing FTR tests to improve visibility into test runs.

@SiddharthMantri SiddharthMantri requested a review from a team as a code owner July 7, 2025 11:46
@SiddharthMantri SiddharthMantri added test chore Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// backport:prev-major labels Jul 7, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 7, 2025

Pinging @elastic/kibana-security (Team:Security)

@SiddharthMantri SiddharthMantri added the release_note:skip Skip the PR/issue when compiling release notes label Jul 7, 2025
@SiddharthMantri SiddharthMantri changed the title chore(security,tests): Added testCategory to cookie and shard missing tests chore(security, tests): Add testCategory to cookie and shard missing tests Jul 7, 2025
csr
csr approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@csr csr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the missing categories to these two configs! 🎉 lgtm

azasypkin
azasypkin approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SiddharthMantri SiddharthMantri enabled auto-merge (squash) July 7, 2025 13:28
@SiddharthMantri SiddharthMantri merged commit 9e8d447 into elastic:main Jul 7, 2025
24 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 7, 2025

Starting backport for target branches: 8.17, 8.18, 8.19

https://github.com/elastic/kibana/actions/runs/16119211794

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 7, 2025

💔 All backports failed

Status Branch Result
❌ 8.17 Backport failed because of merge conflicts
❌ 8.18 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.18:
- [APM] Fix Advanced Settings query parameter (#226731)
- chore(security, tests): log a warning in tests if deprecated feature privilege is replaced with more privileges than necessary (#226473)
- [Obs AI Assistant] Collapse *query tool calls (#226078)
❌ 8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [APM] Fix Advanced Settings query parameter (#226731)
- [Synthetics] Add multispace monitor API test suite in private location (#226042)
- chore(security, tests): log a warning in tests if deprecated feature privilege is replaced with more privileges than necessary (#226473)
- [Streams] Significant events view (#220197)
- [Obs AI Assistant] Migrate anonymization to inference (#225539)
- [SecuritySolution][Endpoint][ResponseActions] Update tests to keep it consistent across 8.19/9.1 branches (#226541)
- [Obs AI Assistant] Collapse *query tool calls (#226078)
- [ska] relocate disable_ems, functional_execution_context, ui_capabilties tests (#226513)
- [ska] relocate functional platform tests (#226470)
- [ska] relocate platform security & localization tests (#226465)

Manual backport

To create the backport manually run:

node scripts/backport --pr 226786

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 8, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 8, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226786 locally
cc: @SiddharthMantri

2 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 9, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226786 locally
cc: @SiddharthMantri

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 10, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226786 locally
cc: @SiddharthMantri

@SiddharthMantri SiddharthMantri added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-major labels Jul 11, 2025
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
@SiddharthMantri @kertal
chore(security, tests): Add testCategory to cookie and shard missing …
3b9473c 
…tests (elastic#226786)

## Summary

Add testCategory for Session Cookies and Session Index shard missing FTR
tests to improve visibility into test runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azasypkin azasypkin azasypkin approved these changes

@csr csr csr approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// test v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SiddharthMantri @elasticmachine @kibanamachine @azasypkin @csr