[8.19] [ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)#226803
Merged
dmlemeshko merged 2 commits intoelastic:8.19from Jul 8, 2025
Merged
Conversation
fake-haris
reviewed
Jul 7, 2025
| import * as path from 'path'; | ||
| import { cloneDeep, merge } from 'lodash'; | ||
| import { FeaturesPrivileges, Role, RoleIndexPrivilege } from '@kbn/security-plugin/common'; | ||
| import type { FeaturesPrivileges, Role, RoleIndexPrivilege } from '@kbn/security-plugin/common'; |
Contributor
There was a problem hiding this comment.
you sure you need to import the type here?
Contributor
Author
There was a problem hiding this comment.
yes, we only need type here. The same thing is in original PR https://github.com/elastic/kibana/pull/225438/files#diff-9dc19289c34d7d34a0554eeeaa7fcf25e7128bb58a5132b100dd3ed0386ef2a8R12
fake-haris
reviewed
Jul 7, 2025
| import { KbnClient } from '@kbn/test'; | ||
| import { Role } from '@kbn/security-plugin/common'; | ||
| import { ToolingLog } from '@kbn/tooling-log'; | ||
| import type { KbnClient } from '@kbn/test'; |
Contributor
Author
There was a problem hiding this comment.
fake-haris
approved these changes
Jul 7, 2025
…elastic#225438) ## Summary This PR removes `kbn/test-suites-serverless` as kbn reference for osquery/cypress test-helper module in order to fix circular dependency I faced in elastic#225377 Since the main consumer of that `shared/lib/security` code is `osquery/cypress` test module, I believe it is a resonable change in order to unblock us relocating tests from `x-pack/test` dir. (cherry picked from commit 10cc7b3)
dmlemeshko
force-pushed
the
backport/8.19/pr-225438
branch
from
d581e45 to
f888edd
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation