Skip to content

Comments

[9.1] [ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)#226802

Merged
dmlemeshko merged 3 commits intoelastic:9.1from
dmlemeshko:backport/9.1/pr-225438
Jul 8, 2025
Merged

[9.1] [ska] relocate 'shared/lib/security' helpers to 'osquery/cypress' dir (#225438)#226802
dmlemeshko merged 3 commits intoelastic:9.1from
dmlemeshko:backport/9.1/pr-225438

Conversation

@dmlemeshko
Copy link
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…elastic#225438)

## Summary

This PR removes `kbn/test-suites-serverless` as kbn reference for
osquery/cypress test-helper module in order to fix circular dependency I
faced in elastic#225377

Since the main consumer of that `shared/lib/security` code is
`osquery/cypress` test module, I believe it is a resonable change in
order to unblock us relocating tests from `x-pack/test` dir.

(cherry picked from commit 10cc7b3)
@dmlemeshko dmlemeshko requested a review from kibanamachine as a code owner July 7, 2025 12:59
@dmlemeshko dmlemeshko added the backport This PR is a backport of another PR label Jul 7, 2025
@dmlemeshko dmlemeshko enabled auto-merge (squash) July 7, 2025 12:59
@dmlemeshko dmlemeshko requested a review from fake-haris July 8, 2025 09:55
@dmlemeshko dmlemeshko merged commit 9fbd611 into elastic:9.1 Jul 8, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
@kbn/test-suites-serverless 1 0 -1
osquery 1 2 +1
total -0

Total ESLint disabled count

id before after diff
@kbn/test-suites-serverless 2 1 -1
osquery 117 118 +1
total -0

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants