[Logs UX] Replace usages of EuiErrorBoundary#220060
Merged
mohamedhamed-ahmed merged 3 commits intoelastic:mainfrom May 6, 2025
Merged
[Logs UX] Replace usages of EuiErrorBoundary#220060mohamedhamed-ahmed merged 3 commits intoelastic:mainfrom
mohamedhamed-ahmed merged 3 commits intoelastic:mainfrom
Conversation
mohamedhamed-ahmed
added
release_note:skip
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Contributor
Author
|
A couple of errors that I am not fully sure we want to catch as part of the |
mykolaharmash
approved these changes
May 5, 2025
Contributor
mykolaharmash
left a comment
mykolaharmash
left a comment
There was a problem hiding this comment.
Tested the onboarding changes locally, everything works as expected. Thank you for the change 🙌
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
Contributor
We shouldn't report them to telemetry if it's an expected flow (which seems it is). There's a related PR to audit log levels #218413 and a similar PR could be created, especially if the frequency of those errors is high. |
mohamedhamed-ahmed
added
backport:version
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15132035308 |
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15132035314 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 20, 2025
closes elastic#211287 ## 📝 Summary This PR add aims to replace the `EuiErrorBoundary` with `KibanaErrorBoundary` but figured out that both can be completely removed as they are already wrapped in `KibanaRenderContextProvider` as per the image below. <img width="857" alt="Screenshot 2025-05-05 at 14 41 55" src="https://github.com/user-attachments/assets/9d8e908e-5df3-40bc-9b0d-f47b94de42ef" /> ## 🔴 Before <img width="1725" alt="Screenshot 2025-05-05 at 13 25 23" src="https://github.com/user-attachments/assets/a474ce6f-2f43-4368-93d0-30191eb41816" /> ## 🟢 After <img width="1727" alt="Screenshot 2025-05-05 at 13 25 00" src="https://github.com/user-attachments/assets/2c2ffbd8-af0d-45fd-9de7-0375a8835f17" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 705fea6)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 20, 2025
closes elastic#211287 ## 📝 Summary This PR add aims to replace the `EuiErrorBoundary` with `KibanaErrorBoundary` but figured out that both can be completely removed as they are already wrapped in `KibanaRenderContextProvider` as per the image below. <img width="857" alt="Screenshot 2025-05-05 at 14 41 55" src="https://github.com/user-attachments/assets/9d8e908e-5df3-40bc-9b0d-f47b94de42ef" /> ## 🔴 Before <img width="1725" alt="Screenshot 2025-05-05 at 13 25 23" src="https://github.com/user-attachments/assets/a474ce6f-2f43-4368-93d0-30191eb41816" /> ## 🟢 After <img width="1727" alt="Screenshot 2025-05-05 at 13 25 00" src="https://github.com/user-attachments/assets/2c2ffbd8-af0d-45fd-9de7-0375a8835f17" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 705fea6)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 20, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Logs UX] Replace usages of EuiErrorBoundary (#220060)](#220060) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"mohamedhamed-ahmed","email":"mohamed.ahmed@elastic.co"},"sourceCommit":{"committedDate":"2025-05-06T10:42:29Z","message":"[Logs UX] Replace usages of EuiErrorBoundary (#220060)\n\ncloses https://github.com/elastic/kibana/issues/211287\n\n## 📝 Summary\n\nThis PR add aims to replace the `EuiErrorBoundary` with\n`KibanaErrorBoundary` but figured out that both can be completely\nremoved as they are already wrapped in `KibanaRenderContextProvider` as\nper the image below.\n\n<img width=\"857\" alt=\"Screenshot 2025-05-05 at 14 41 55\"\nsrc=\"https://github.com/user-attachments/assets/9d8e908e-5df3-40bc-9b0d-f47b94de42ef\"\n/>\n\n## 🔴 Before\n<img width=\"1725\" alt=\"Screenshot 2025-05-05 at 13 25 23\"\nsrc=\"https://github.com/user-attachments/assets/a474ce6f-2f43-4368-93d0-30191eb41816\"\n/>\n\n## 🟢 After\n<img width=\"1727\" alt=\"Screenshot 2025-05-05 at 13 25 00\"\nsrc=\"https://github.com/user-attachments/assets/2c2ffbd8-af0d-45fd-9de7-0375a8835f17\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"705fea6bd0efd6f25e1d151cdfb547c08bedc591","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-logs","backport:version","v9.1.0","v8.19.0","Project: Obs Quality"],"title":"[Logs UX] Replace usages of EuiErrorBoundary","number":220060,"url":"https://github.com/elastic/kibana/pull/220060","mergeCommit":{"message":"[Logs UX] Replace usages of EuiErrorBoundary (#220060)\n\ncloses https://github.com/elastic/kibana/issues/211287\n\n## 📝 Summary\n\nThis PR add aims to replace the `EuiErrorBoundary` with\n`KibanaErrorBoundary` but figured out that both can be completely\nremoved as they are already wrapped in `KibanaRenderContextProvider` as\nper the image below.\n\n<img width=\"857\" alt=\"Screenshot 2025-05-05 at 14 41 55\"\nsrc=\"https://github.com/user-attachments/assets/9d8e908e-5df3-40bc-9b0d-f47b94de42ef\"\n/>\n\n## 🔴 Before\n<img width=\"1725\" alt=\"Screenshot 2025-05-05 at 13 25 23\"\nsrc=\"https://github.com/user-attachments/assets/a474ce6f-2f43-4368-93d0-30191eb41816\"\n/>\n\n## 🟢 After\n<img width=\"1727\" alt=\"Screenshot 2025-05-05 at 13 25 00\"\nsrc=\"https://github.com/user-attachments/assets/2c2ffbd8-af0d-45fd-9de7-0375a8835f17\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"705fea6bd0efd6f25e1d151cdfb547c08bedc591"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220060","number":220060,"mergeCommit":{"message":"[Logs UX] Replace usages of EuiErrorBoundary (#220060)\n\ncloses https://github.com/elastic/kibana/issues/211287\n\n## 📝 Summary\n\nThis PR add aims to replace the `EuiErrorBoundary` with\n`KibanaErrorBoundary` but figured out that both can be completely\nremoved as they are already wrapped in `KibanaRenderContextProvider` as\nper the image below.\n\n<img width=\"857\" alt=\"Screenshot 2025-05-05 at 14 41 55\"\nsrc=\"https://github.com/user-attachments/assets/9d8e908e-5df3-40bc-9b0d-f47b94de42ef\"\n/>\n\n## 🔴 Before\n<img width=\"1725\" alt=\"Screenshot 2025-05-05 at 13 25 23\"\nsrc=\"https://github.com/user-attachments/assets/a474ce6f-2f43-4368-93d0-30191eb41816\"\n/>\n\n## 🟢 After\n<img width=\"1727\" alt=\"Screenshot 2025-05-05 at 13 25 00\"\nsrc=\"https://github.com/user-attachments/assets/2c2ffbd8-af0d-45fd-9de7-0375a8835f17\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"705fea6bd0efd6f25e1d151cdfb547c08bedc591"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>
Member
|
@mohamedhamed-ahmed Where is the guidance regarding |
Contributor
Author
|
@JasonStoltz let me share a document with you that has all needed information. |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
closes elastic#211287 ## 📝 Summary This PR add aims to replace the `EuiErrorBoundary` with `KibanaErrorBoundary` but figured out that both can be completely removed as they are already wrapped in `KibanaRenderContextProvider` as per the image below. <img width="857" alt="Screenshot 2025-05-05 at 14 41 55" src="https://github.com/user-attachments/assets/9d8e908e-5df3-40bc-9b0d-f47b94de42ef" /> ## 🔴 Before <img width="1725" alt="Screenshot 2025-05-05 at 13 25 23" src="https://github.com/user-attachments/assets/a474ce6f-2f43-4368-93d0-30191eb41816" /> ## 🟢 After <img width="1727" alt="Screenshot 2025-05-05 at 13 25 00" src="https://github.com/user-attachments/assets/2c2ffbd8-af0d-45fd-9de7-0375a8835f17" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
closes elastic#211287 ## 📝 Summary This PR add aims to replace the `EuiErrorBoundary` with `KibanaErrorBoundary` but figured out that both can be completely removed as they are already wrapped in `KibanaRenderContextProvider` as per the image below. <img width="857" alt="Screenshot 2025-05-05 at 14 41 55" src="https://github.com/user-attachments/assets/9d8e908e-5df3-40bc-9b0d-f47b94de42ef" /> ## 🔴 Before <img width="1725" alt="Screenshot 2025-05-05 at 13 25 23" src="https://github.com/user-attachments/assets/a474ce6f-2f43-4368-93d0-30191eb41816" /> ## 🟢 After <img width="1727" alt="Screenshot 2025-05-05 at 13 25 00" src="https://github.com/user-attachments/assets/2c2ffbd8-af0d-45fd-9de7-0375a8835f17" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #211287
📝 Summary
This PR add aims to replace the
EuiErrorBoundarywithKibanaErrorBoundarybut figured out that both can be completely removed as they are already wrapped inKibanaRenderContextProvideras per the image below.🔴 Before
🟢 After