Audit Logs Levels - Obs Ux Logs Team#218413
Merged
awahab07 merged 8 commits intoelastic:mainfrom May 7, 2025
Merged
Conversation
awahab07
added
release_note:skip
…-Audit-Log-Levels_Obs-Ux-Logs-Team
…-Audit-Log-Levels_Obs-Ux-Logs-Team
…-Audit-Log-Levels_Obs-Ux-Logs-Team
| if (errorStatusCode >= 500) { | ||
| logger.error(errorMessage); | ||
| } else if (errorStatusCode < 500 && errorStatusCode >= 400) { | ||
| logger.warn(errorMessage); |
Member
There was a problem hiding this comment.
Hey @awahab07, based on the discussion in the meeting, shall we not log 4xx errors for now since it is not actionable for us?
Contributor
There was a problem hiding this comment.
Would it be beneficial to have this logic more centralised in a shared plugin or it's better to define it within the plugins?
Contributor
Author
There was a problem hiding this comment.
shall we not log 4xx errors for now
Sounds good, I'll adjust logging accordingly.
Would it be beneficial to have this logic more centralised in a shared plugin or it's better to define it within the plugins?
Absolutely, having it central would be ideal. In fact there's an issue #198681 which covers that.
Contributor
Author
There was a problem hiding this comment.
@maryam-saeidi any suggestions how 4xx should be logged then, logged as debug or not logged at all?
Member
There was a problem hiding this comment.
For now, having it as debug sounds good to me until we work on #198681 or https://github.com/elastic/observability-dev/issues/4374.
…-Audit-Log-Levels_Obs-Ux-Logs-Team
…-Audit-Log-Levels_Obs-Ux-Logs-Team
…-Audit-Log-Levels_Obs-Ux-Logs-Team
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
cc @awahab07 |
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0 https://github.com/elastic/kibana/actions/runs/14886395864 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 7, 2025
The PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level). (cherry picked from commit cf2091d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 7, 2025
The PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level). (cherry picked from commit cf2091d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 7, 2025
The PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level). (cherry picked from commit cf2091d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 7, 2025
The PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level). (cherry picked from commit cf2091d)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
9 tasks
kibanamachine
added a commit
that referenced
this pull request
May 7, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Audit Logs Levels - Obs Ux Logs Team (#218413)](#218413) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Abdul Wahab Zahid","email":"awahab07@yahoo.com"},"sourceCommit":{"committedDate":"2025-05-07T14:48:54Z","message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"Audit Logs Levels - Obs Ux Logs Team","number":218413,"url":"https://github.com/elastic/kibana/pull/218413","mergeCommit":{"message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218413","number":218413,"mergeCommit":{"message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b"}}]}] BACKPORT--> Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
kibanamachine
added a commit
that referenced
this pull request
May 7, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Audit Logs Levels - Obs Ux Logs Team (#218413)](#218413) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Abdul Wahab Zahid","email":"awahab07@yahoo.com"},"sourceCommit":{"committedDate":"2025-05-07T14:48:54Z","message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"Audit Logs Levels - Obs Ux Logs Team","number":218413,"url":"https://github.com/elastic/kibana/pull/218413","mergeCommit":{"message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218413","number":218413,"mergeCommit":{"message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b"}}]}] BACKPORT--> Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
kibanamachine
added a commit
that referenced
this pull request
May 7, 2025
# Backport This will backport the following commits from `main` to `8.17`: - [Audit Logs Levels - Obs Ux Logs Team (#218413)](#218413) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Abdul Wahab Zahid","email":"awahab07@yahoo.com"},"sourceCommit":{"committedDate":"2025-05-07T14:48:54Z","message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"Audit Logs Levels - Obs Ux Logs Team","number":218413,"url":"https://github.com/elastic/kibana/pull/218413","mergeCommit":{"message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218413","number":218413,"mergeCommit":{"message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b"}}]}] BACKPORT--> Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
kibanamachine
added a commit
that referenced
this pull request
May 7, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [Audit Logs Levels - Obs Ux Logs Team (#218413)](#218413) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Abdul Wahab Zahid","email":"awahab07@yahoo.com"},"sourceCommit":{"committedDate":"2025-05-07T14:48:54Z","message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"Audit Logs Levels - Obs Ux Logs Team","number":218413,"url":"https://github.com/elastic/kibana/pull/218413","mergeCommit":{"message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218413","number":218413,"mergeCommit":{"message":"Audit Logs Levels - Obs Ux Logs Team (#218413)\n\nThe PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).","sha":"cf2091d5dca8aea47bec12ee14678382b36f9d1b"}}]}] BACKPORT--> Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
The PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
The PR audits and fixes the log levels for Dataset Quality plugin based on [guidelines](https://docs.elastic.dev/kibana-dev-docs/services/logging#log-level).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR audits and fixes the log levels for the followings plugins based on the guidelines.
x-pack/solutions/observability/plugins/observability_logs_explorer.error,.warnor.infox-pack/solutions/observability/plugins/observability_onboarding.errorwhich looks correct.errorand.infobut those are under e2e directory.x-pack/platform/plugins/shared/data_quality.error,.warnor.infox-pack/platform/plugins/shared/data_qualityx-pack/platform/plugins/shared/fields_metadata.error,.warnor.infox-pack/platform/plugins/shared/logs_data_access.error,.warnor.infox-pack/platform/plugins/shared/logs_shared.debuginstances