Skip to content

[Obs AI Assistant] replace EuiErrorBoundary with KibanaErrorBoundary#229710

Merged
neptunian merged 9 commits intoelastic:mainfrom
neptunian:replace-error-boundary
Jul 29, 2025
Merged

[Obs AI Assistant] replace EuiErrorBoundary with KibanaErrorBoundary#229710
neptunian merged 9 commits intoelastic:mainfrom
neptunian:replace-error-boundary

Conversation

@neptunian
Copy link
Contributor

@neptunian neptunian commented Jul 28, 2025

Replaces EuiErrorBoundary with using core.rendering.addContext().

https://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx

I tested this by throwing an error in the feedback buttons and the AI Assistant button itself and confirmed they are caught by the KibanaErrorBoundary.

@neptunian neptunian requested a review from a team as a code owner July 28, 2025 19:21
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 28, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@neptunian neptunian added release_note:fix backport:all-open Backport to all branches that could still receive a release labels Jul 28, 2025
@elasticmachine
Copy link
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: 1c6e1d0
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-229710-1c6e1d02f979

History

@neptunian neptunian merged commit d73f9ee into elastic:main Jul 29, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16602972488

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2025
…lastic#229710)

Replaces `EuiErrorBoundary` with using `core.rendering.addContext()`.

https://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx

I tested this by throwing an error in the feedback buttons and the AI
Assistant button itself and confirmed they are caught by the
`KibanaErrorBoundary`.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d73f9ee)
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2025
…lastic#229710)

Replaces `EuiErrorBoundary` with using `core.rendering.addContext()`.

https://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx

I tested this by throwing an error in the feedback buttons and the AI
Assistant button itself and confirmed they are caught by the
`KibanaErrorBoundary`.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d73f9ee)
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2025
…lastic#229710)

Replaces `EuiErrorBoundary` with using `core.rendering.addContext()`.

https://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx

I tested this by throwing an error in the feedback buttons and the AI
Assistant button itself and confirmed they are caught by the
`KibanaErrorBoundary`.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d73f9ee)
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2025
…lastic#229710)

Replaces `EuiErrorBoundary` with using `core.rendering.addContext()`.

https://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx

I tested this by throwing an error in the feedback buttons and the AI
Assistant button itself and confirmed they are caught by the
`KibanaErrorBoundary`.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d73f9ee)
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2025
…lastic#229710)

Replaces `EuiErrorBoundary` with using `core.rendering.addContext()`.

https://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx

I tested this by throwing an error in the feedback buttons and the AI
Assistant button itself and confirmed they are caught by the
`KibanaErrorBoundary`.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d73f9ee)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17
8.18
8.19
9.0
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 29, 2025
…ndary (#229710) (#229858)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Obs AI Assistant] replace EuiErrorBoundary with KibanaErrorBoundary
(#229710)](#229710)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sandra
G","email":"neptunian@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-29T17:21:18Z","message":"[Obs
AI Assistant] replace EuiErrorBoundary with KibanaErrorBoundary
(#229710)\n\nReplaces `EuiErrorBoundary` with using
`core.rendering.addContext()`.\n\n\nhttps://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx\n\nI
tested this by throwing an error in the feedback buttons and the
AI\nAssistant button itself and confirmed they are caught by
the\n`KibanaErrorBoundary`.\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d73f9eef6031eb4ee7f3d1d99935eaa8c98dc522","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","ci:project-deploy-observability","v9.2.0"],"title":"[Obs
AI Assistant] replace EuiErrorBoundary with
KibanaErrorBoundary","number":229710,"url":"https://github.com/elastic/kibana/pull/229710","mergeCommit":{"message":"[Obs
AI Assistant] replace EuiErrorBoundary with KibanaErrorBoundary
(#229710)\n\nReplaces `EuiErrorBoundary` with using
`core.rendering.addContext()`.\n\n\nhttps://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx\n\nI
tested this by throwing an error in the feedback buttons and the
AI\nAssistant button itself and confirmed they are caught by
the\n`KibanaErrorBoundary`.\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d73f9eef6031eb4ee7f3d1d99935eaa8c98dc522"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229710","number":229710,"mergeCommit":{"message":"[Obs
AI Assistant] replace EuiErrorBoundary with KibanaErrorBoundary
(#229710)\n\nReplaces `EuiErrorBoundary` with using
`core.rendering.addContext()`.\n\n\nhttps://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx\n\nI
tested this by throwing an error in the feedback buttons and the
AI\nAssistant button itself and confirmed they are caught by
the\n`KibanaErrorBoundary`.\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d73f9eef6031eb4ee7f3d1d99935eaa8c98dc522"}}]}]
BACKPORT-->

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 29, 2025
…undary (#229710) (#229856)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Obs AI Assistant] replace EuiErrorBoundary with KibanaErrorBoundary
(#229710)](#229710)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sandra
G","email":"neptunian@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-29T17:21:18Z","message":"[Obs
AI Assistant] replace EuiErrorBoundary with KibanaErrorBoundary
(#229710)\n\nReplaces `EuiErrorBoundary` with using
`core.rendering.addContext()`.\n\n\nhttps://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx\n\nI
tested this by throwing an error in the feedback buttons and the
AI\nAssistant button itself and confirmed they are caught by
the\n`KibanaErrorBoundary`.\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d73f9eef6031eb4ee7f3d1d99935eaa8c98dc522","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","ci:project-deploy-observability","v9.2.0"],"title":"[Obs
AI Assistant] replace EuiErrorBoundary with
KibanaErrorBoundary","number":229710,"url":"https://github.com/elastic/kibana/pull/229710","mergeCommit":{"message":"[Obs
AI Assistant] replace EuiErrorBoundary with KibanaErrorBoundary
(#229710)\n\nReplaces `EuiErrorBoundary` with using
`core.rendering.addContext()`.\n\n\nhttps://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx\n\nI
tested this by throwing an error in the feedback buttons and the
AI\nAssistant button itself and confirmed they are caught by
the\n`KibanaErrorBoundary`.\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d73f9eef6031eb4ee7f3d1d99935eaa8c98dc522"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229710","number":229710,"mergeCommit":{"message":"[Obs
AI Assistant] replace EuiErrorBoundary with KibanaErrorBoundary
(#229710)\n\nReplaces `EuiErrorBoundary` with using
`core.rendering.addContext()`.\n\n\nhttps://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx\n\nI
tested this by throwing an error in the feedback buttons and the
AI\nAssistant button itself and confirmed they are caught by
the\n`KibanaErrorBoundary`.\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d73f9eef6031eb4ee7f3d1d99935eaa8c98dc522"}}]}]
BACKPORT-->

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
VladimirFilonov pushed a commit to VladimirFilonov/kibana that referenced this pull request Jul 30, 2025
…lastic#229710)

Replaces `EuiErrorBoundary` with using `core.rendering.addContext()`.


https://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx

I tested this by throwing an error in the feedback buttons and the AI
Assistant button itself and confirmed they are caught by the
`KibanaErrorBoundary`.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 30, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @neptunian

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 31, 2025
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
…lastic#229710)

Replaces `EuiErrorBoundary` with using `core.rendering.addContext()`.


https://github.com/elastic/kibana/blob/main/src/core/packages/rendering/browser/README.mdx

I tested this by throwing an error in the feedback buttons and the AI
Assistant button itself and confirmed they are caught by the
`KibanaErrorBoundary`.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release ci:project-deploy-observability Create an Observability project release_note:fix v8.19.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants