Skip to content

[8.19] [Logs UX] Replace usages of EuiErrorBoundary (#220060)#220955

Merged
kibanamachine merged 1 commit intoelastic:8.19from
kibanamachine:backport/8.19/pr-220060
May 20, 2025
Merged

[8.19] [Logs UX] Replace usages of EuiErrorBoundary (#220060)#220955
kibanamachine merged 1 commit intoelastic:8.19from
kibanamachine:backport/8.19/pr-220060

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport This PR is a backport of another PR label May 20, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) May 20, 2025 08:03
closes elastic#211287

## 📝  Summary

This PR add aims to replace the `EuiErrorBoundary` with
`KibanaErrorBoundary` but figured out that both can be completely
removed as they are already wrapped in `KibanaRenderContextProvider` as
per the image below.

<img width="857" alt="Screenshot 2025-05-05 at 14 41 55"
src="https://github.com/user-attachments/assets/9d8e908e-5df3-40bc-9b0d-f47b94de42ef"
/>

## 🔴 Before
<img width="1725" alt="Screenshot 2025-05-05 at 13 25 23"
src="https://github.com/user-attachments/assets/a474ce6f-2f43-4368-93d0-30191eb41816"
/>

## 🟢 After
<img width="1727" alt="Screenshot 2025-05-05 at 13 25 00"
src="https://github.com/user-attachments/assets/2c2ffbd8-af0d-45fd-9de7-0375a8835f17"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 705fea6)
@kibanamachine kibanamachine force-pushed the backport/8.19/pr-220060 branch from eb76077 to e25bff2 Compare May 20, 2025 08:06
@kibanamachine kibanamachine merged commit 6e4659b into elastic:8.19 May 20, 2025
6 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.6MB 1.6MB -105.0B
observabilityOnboarding 237.8KB 237.8KB -56.0B
total -161.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityOnboarding 11.5KB 11.4KB -78.0B

cc @mohamedhamed-ahmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants