Skip to content

[Logs UX] Replace usages of EuiErrorBoundary #220060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohamedhamed-ahmed merged 3 commits into from
May 6, 2025
Merged

[Logs UX] Replace usages of EuiErrorBoundary #220060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6699c11
[Logs UX] Replace usages of EuiErrorBoundary
mohamedhamed-ahmed May 5, 2025
6f73907
[CI] Auto-commit changed files from 'node scripts/styled_components_m…
kibanamachine May 5, 2025
4b8aff5
Merge branch 'main' into 211287-replace-usages-of-euierrorboundary
mohamedhamed-ahmed May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions x-pack/solutions/observability/plugins/infra/public/pages/logs/log_entry_categories/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
* 2.0.
*/

import { EuiErrorBoundary } from '@elastic/eui';
import React from 'react';
import { MissingResultsPrivilegesPrompt } from '../../../components/logging/log_analysis_setup';
import { useLogAnalysisCapabilitiesContext } from '../../../containers/logs/log_analysis';
Expand Down Expand Up @@ -46,12 +45,10 @@ export const LogEntryCategoriesPage = () => {
}

return (
<EuiErrorBoundary>
<LogMlJobIdFormatsShimProvider>
<LogEntryCategoriesPageProviders>
<LogEntryCategoriesPageContent />
</LogEntryCategoriesPageProviders>
</LogMlJobIdFormatsShimProvider>
</EuiErrorBoundary>
<LogMlJobIdFormatsShimProvider>
<LogEntryCategoriesPageProviders>
<LogEntryCategoriesPageContent />
</LogEntryCategoriesPageProviders>
</LogMlJobIdFormatsShimProvider>
);
};
13 changes: 5 additions & 8 deletions x-pack/solutions/observability/plugins/infra/public/pages/logs/log_entry_rate/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
* 2.0.
*/

import { EuiErrorBoundary } from '@elastic/eui';
import React from 'react';
import { SubscriptionSplashPage } from '../../../components/subscription_splash_content';
import { MissingResultsPrivilegesPrompt } from '../../../components/logging/log_analysis_setup';
Expand Down Expand Up @@ -46,12 +45,10 @@ export const LogEntryRatePage = () => {
}

return (
<EuiErrorBoundary>
<LogMlJobIdFormatsShimProvider>
<LogEntryRatePageProviders>
<LogEntryRatePageContent />
</LogEntryRatePageProviders>
</LogMlJobIdFormatsShimProvider>
</EuiErrorBoundary>
<LogMlJobIdFormatsShimProvider>
<LogEntryRatePageProviders>
<LogEntryRatePageContent />
</LogEntryRatePageProviders>
</LogMlJobIdFormatsShimProvider>
);
};
9 changes: 3 additions & 6 deletions x-pack/solutions/observability/plugins/infra/public/pages/logs/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,15 @@
* 2.0.
*/

import { EuiErrorBoundary } from '@elastic/eui';
import React from 'react';
import type { RouteComponentProps } from 'react-router-dom';
import { LogsPageContent } from './page_content';
import { LogsPageProviders } from './page_providers';

export const LogsPage: React.FunctionComponent<RouteComponentProps> = () => {
return (
<EuiErrorBoundary>
<LogsPageProviders>
<LogsPageContent />
</LogsPageProviders>
</EuiErrorBoundary>
<LogsPageProviders>
<LogsPageContent />
</LogsPageProviders>
);
};
45 changes: 21 additions & 24 deletions x-pack/solutions/observability/plugins/observability_onboarding/public/application/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@
* 2.0.
*/

import { EuiErrorBoundary } from '@elastic/eui';
import { AppMountParameters, APP_WRAPPER_CLASS, CoreStart } from '@kbn/core/public';
import { i18n } from '@kbn/i18n';
import { PerformanceContextProvider } from '@kbn/ebt-tools';
import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
import { KibanaRenderContextProvider } from '@kbn/react-kibana-context-render';
import { KibanaThemeProvider } from '@kbn/react-kibana-context-theme';
import { RedirectAppLinks } from '@kbn/shared-ux-link-redirect-app';
import { Router } from '@kbn/shared-ux-router';
import React from 'react';
Expand Down Expand Up @@ -54,35 +52,34 @@ export function ObservabilityOnboardingAppRoot({
};

return (
<KibanaRenderContextProvider {...core}>
<KibanaRenderContextProvider
{...core}
theme={{ theme$ }}
modify={{
breakpoint: {
xxl: 1600,
xxxl: 2000,
},
}}
>
<div className={APP_WRAPPER_CLASS}>
<RedirectAppLinks
coreStart={{
application: core.application,
}}
>
<KibanaContextProvider services={services}>
<KibanaThemeProvider
theme={{ theme$ }}
modify={{
breakpoint: {
xxl: 1600,
xxxl: 2000,
},
}}
>
<Router history={history}>
<PerformanceContextProvider>
<EuiErrorBoundary>
<ObservabilityOnboardingHeaderActionMenu
setHeaderActionMenu={setHeaderActionMenu}
theme$={theme$}
/>
<ObservabilityOnboardingFlow />
</EuiErrorBoundary>
</PerformanceContextProvider>
</Router>
</KibanaThemeProvider>
<Router history={history}>
<PerformanceContextProvider>
<>
<ObservabilityOnboardingHeaderActionMenu
setHeaderActionMenu={setHeaderActionMenu}
theme$={theme$}
/>
<ObservabilityOnboardingFlow />
</>
</PerformanceContextProvider>
</Router>
</KibanaContextProvider>
</RedirectAppLinks>
</div>
Expand Down
1 change: 0 additions & 1 deletion x-pack/solutions/observability/plugins/observability_onboarding/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"@kbn/fleet-plugin",
"@kbn/shared-ux-link-redirect-app",
"@kbn/react-kibana-context-render",
"@kbn/react-kibana-context-theme",
"@kbn/discover-plugin",
"@kbn/spaces-plugin",
"@kbn/deeplinks-analytics",
Expand Down