Merged
Conversation
mgadewoll
added
release_note:skip
Contributor
⏳ Build in-progress, with failures
Failed CI Stepscc @mgadewoll |
Contributor
|
Pinging @elastic/eui-team (EUI) |
rmyz
approved these changes
May 5, 2025
Contributor
rmyz
left a comment
rmyz
left a comment
There was a problem hiding this comment.
x-pack/solutions/observability/plugins/infra/public/components/asset_details/tabs/processes/__snapshots__/processes_table.test.tsx.snap changes LGTM
jbudz
approved these changes
May 5, 2025
Contributor
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
src/dev/license_checker/config.ts LGTM
Contributor
agusruidiazgd
left a comment
agusruidiazgd
left a comment
There was a problem hiding this comment.
Hi @mgadewoll! Thanks for this changes 😸
Quick question: the snapshots on the explore side seem to have shifted, but I didn’t see any test changes—do you know what might’ve caused it?
Contributor
Author
@agusruidiazgd Yes, the changes to snapshots were done on EUI side. Table header cells have tooltips directly on them now when they are focusable, which added an additional wrapper as tooltip anchor in the snapshots.
|
agusruidiazgd
approved these changes
May 5, 2025
Contributor
agusruidiazgd
left a comment
agusruidiazgd
left a comment
There was a problem hiding this comment.
@mgadewoll thanks for the comments! LGTM from Explore side 😸
jughosta
approved these changes
May 6, 2025
Contributor
jughosta
left a comment
jughosta
left a comment
There was a problem hiding this comment.
Data Discovery changes LGTM 👍
markov00
approved these changes
May 6, 2025
mgadewoll
added a commit
that referenced
this pull request
May 6, 2025
`102.0.0` ⏩ `102.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) >[!IMPORTANT] This PR is a direct sibling to this [upgrade PR](#220039) to `main`. The difference is that it adds a standalone EUI package with the previous "Amsterdam" theme. Apart from the theme difference, **there are no further changes added**. ## Changes - Updated test selector (due to changed tooltip placement in [#8644](elastic/eui#8644)) - snapshot updates ## Package updates ### `@elastic/eui` #### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0) - Update `EuiDataGrid` to use `expand` glyph ([#8646](elastic/eui#8646)) **Accessibility** - Updated `EuiTableHeaderCell` to output `nameTooltip` directly on sortable cell elements, ensuring tooltips appear on focus ([#8644](elastic/eui#8644)) - Improved the accessibility of `EuiColorPicker` by: ([#8639](elastic/eui#8639)) - preventing duplicate color output for screen readers - adding tooltips with visual color labels for the selected colors on the saturation and hue sliders - updated accessible labels and announcements to be more descriptive **Dependency updates** - Updated `typescript` to v5.8.3 ([#8626](elastic/eui#8626))
Contributor
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/14862511898 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mgadewoll
added a commit
to mgadewoll/kibana
that referenced
this pull request
May 6, 2025
`102.0.0` ⏩ `102.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) >[!NOTE] There is also the sibling PR for `8.19` with old Amsterdam theme ready for review [here](elastic#220049). It contains the same changes. ## Changes - Updated test selector (due to changed tooltip placement in [elastic#8644](elastic/eui#8644)) - snapshot updates ## Package updates ### `@elastic/eui` #### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0) - Update `EuiDataGrid` to use `expand` glyph ([elastic#8646](elastic/eui#8646)) **Accessibility** - Updated `EuiTableHeaderCell` to output `nameTooltip` directly on sortable cell elements, ensuring tooltips appear on focus ([elastic#8644](elastic/eui#8644)) - Improved the accessibility of `EuiColorPicker` by: ([elastic#8639](elastic/eui#8639)) - preventing duplicate color output for screen readers - adding tooltips with visual color labels for the selected colors on the saturation and hue sliders - updated accessible labels and announcements to be more descriptive **Dependency updates** - Updated `typescript` to v5.8.3 ([elastic#8626](elastic/eui#8626)) (cherry picked from commit bca8299) # Conflicts: # x-pack/solutions/observability/plugins/infra/public/components/asset_details/tabs/processes/__snapshots__/processes_table.test.tsx.snap
mgadewoll
added a commit
that referenced
this pull request
May 6, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Upgrade EUI to v102.1.0 (#220039)](#220039) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Lene Gadewoll","email":"lene.gadewoll@elastic.co"},"sourceCommit":{"committedDate":"2025-05-06T14:38:55Z","message":"Upgrade EUI to v102.1.0 (#220039)\n\n`102.0.0` ⏩ `102.1.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n>[!NOTE]\nThere is also the sibling PR for `8.19` with old Amsterdam theme ready\nfor review [here](#220049). It\ncontains the same changes.\n\n## Changes\n\n- Updated test selector (due to changed tooltip placement in\n[#8644](https://github.com/elastic/eui/pull/8644))\n- snapshot updates\n\n## Package updates\n\n### `@elastic/eui`\n\n#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)\n\n- Update `EuiDataGrid` to use `expand` glyph\n([#8646](https://github.com/elastic/eui/pull/8646))\n\n**Accessibility**\n\n- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on\nsortable cell elements, ensuring tooltips appear on focus\n([#8644](https://github.com/elastic/eui/pull/8644))\n- Improved the accessibility of `EuiColorPicker` by:\n([#8639](https://github.com/elastic/eui/pull/8639))\n - preventing duplicate color output for screen readers\n- adding tooltips with visual color labels for the selected colors on\nthe saturation and hue sliders\n - updated accessible labels and announcements to be more descriptive\n\n**Dependency updates**\n\n- Updated `typescript` to v5.8.3\n([#8626](https://github.com/elastic/eui/pull/8626))","sha":"bca8299927ef023215494fb7bc21ad90891ffc54","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","backport:prev-minor","v9.1.0","v9.0.1"],"title":"Upgrade EUI to v102.1.0","number":220039,"url":"https://github.com/elastic/kibana/pull/220039","mergeCommit":{"message":"Upgrade EUI to v102.1.0 (#220039)\n\n`102.0.0` ⏩ `102.1.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n>[!NOTE]\nThere is also the sibling PR for `8.19` with old Amsterdam theme ready\nfor review [here](#220049). It\ncontains the same changes.\n\n## Changes\n\n- Updated test selector (due to changed tooltip placement in\n[#8644](https://github.com/elastic/eui/pull/8644))\n- snapshot updates\n\n## Package updates\n\n### `@elastic/eui`\n\n#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)\n\n- Update `EuiDataGrid` to use `expand` glyph\n([#8646](https://github.com/elastic/eui/pull/8646))\n\n**Accessibility**\n\n- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on\nsortable cell elements, ensuring tooltips appear on focus\n([#8644](https://github.com/elastic/eui/pull/8644))\n- Improved the accessibility of `EuiColorPicker` by:\n([#8639](https://github.com/elastic/eui/pull/8639))\n - preventing duplicate color output for screen readers\n- adding tooltips with visual color labels for the selected colors on\nthe saturation and hue sliders\n - updated accessible labels and announcements to be more descriptive\n\n**Dependency updates**\n\n- Updated `typescript` to v5.8.3\n([#8626](https://github.com/elastic/eui/pull/8626))","sha":"bca8299927ef023215494fb7bc21ad90891ffc54"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220039","number":220039,"mergeCommit":{"message":"Upgrade EUI to v102.1.0 (#220039)\n\n`102.0.0` ⏩ `102.1.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n>[!NOTE]\nThere is also the sibling PR for `8.19` with old Amsterdam theme ready\nfor review [here](#220049). It\ncontains the same changes.\n\n## Changes\n\n- Updated test selector (due to changed tooltip placement in\n[#8644](https://github.com/elastic/eui/pull/8644))\n- snapshot updates\n\n## Package updates\n\n### `@elastic/eui`\n\n#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)\n\n- Update `EuiDataGrid` to use `expand` glyph\n([#8646](https://github.com/elastic/eui/pull/8646))\n\n**Accessibility**\n\n- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on\nsortable cell elements, ensuring tooltips appear on focus\n([#8644](https://github.com/elastic/eui/pull/8644))\n- Improved the accessibility of `EuiColorPicker` by:\n([#8639](https://github.com/elastic/eui/pull/8639))\n - preventing duplicate color output for screen readers\n- adding tooltips with visual color labels for the selected colors on\nthe saturation and hue sliders\n - updated accessible labels and announcements to be more descriptive\n\n**Dependency updates**\n\n- Updated `typescript` to v5.8.3\n([#8626](https://github.com/elastic/eui/pull/8626))","sha":"bca8299927ef023215494fb7bc21ad90891ffc54"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
`102.0.0` ⏩ `102.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) >[!NOTE] There is also the sibling PR for `8.19` with old Amsterdam theme ready for review [here](elastic#220049). It contains the same changes. ## Changes - Updated test selector (due to changed tooltip placement in [elastic#8644](elastic/eui#8644)) - snapshot updates ## Package updates ### `@elastic/eui` #### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0) - Update `EuiDataGrid` to use `expand` glyph ([elastic#8646](elastic/eui#8646)) **Accessibility** - Updated `EuiTableHeaderCell` to output `nameTooltip` directly on sortable cell elements, ensuring tooltips appear on focus ([elastic#8644](elastic/eui#8644)) - Improved the accessibility of `EuiColorPicker` by: ([elastic#8639](elastic/eui#8639)) - preventing duplicate color output for screen readers - adding tooltips with visual color labels for the selected colors on the saturation and hue sliders - updated accessible labels and announcements to be more descriptive **Dependency updates** - Updated `typescript` to v5.8.3 ([elastic#8626](elastic/eui#8626))
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
`102.0.0` ⏩ `102.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) >[!NOTE] There is also the sibling PR for `8.19` with old Amsterdam theme ready for review [here](elastic#220049). It contains the same changes. ## Changes - Updated test selector (due to changed tooltip placement in [elastic#8644](elastic/eui#8644)) - snapshot updates ## Package updates ### `@elastic/eui` #### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0) - Update `EuiDataGrid` to use `expand` glyph ([elastic#8646](elastic/eui#8646)) **Accessibility** - Updated `EuiTableHeaderCell` to output `nameTooltip` directly on sortable cell elements, ensuring tooltips appear on focus ([elastic#8644](elastic/eui#8644)) - Improved the accessibility of `EuiColorPicker` by: ([elastic#8639](elastic/eui#8639)) - preventing duplicate color output for screen readers - adding tooltips with visual color labels for the selected colors on the saturation and hue sliders - updated accessible labels and announcements to be more descriptive **Dependency updates** - Updated `typescript` to v5.8.3 ([elastic#8626](elastic/eui#8626))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
102.0.0⏩102.1.0Questions? Please see our Kibana upgrade FAQ.
Note
There is also the sibling PR for
8.19with old Amsterdam theme ready for review here. It contains the same changes.Changes
Package updates
@elastic/euiv102.1.0EuiDataGridto useexpandglyph (#8646)Accessibility
EuiTableHeaderCellto outputnameTooltipdirectly on sortable cell elements, ensuring tooltips appear on focus (#8644)EuiColorPickerby: (#8639)Dependency updates
typescriptto v5.8.3 (#8626)