[Entity Analytics] [bug-fix] Do not abort risk score search request#219858
Merged
machadoum merged 3 commits intoelastic:mainfrom May 6, 2025
Merged
[Entity Analytics] [bug-fix] Do not abort risk score search request#219858machadoum merged 3 commits intoelastic:mainfrom
machadoum merged 3 commits intoelastic:mainfrom
Conversation
hop-dev
added
release_note:skip
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
machadoum
force-pushed
the
219490-abort-error-on-asset-crit-cha
branch
from
6450b4e to
85d2eab
Compare
machadoum
changed the title
machadoum
added
the
bug
Contributor
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
CAWilson94
approved these changes
May 2, 2025
hop-dev
added
backport:version
Contributor
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/14855773125 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 6, 2025
…lastic#219858) ## Summary Closes elastic#219490 Fix an error toast appearing when changing an entities asset criticality from the entity flyout. See video on issue above for more detail. We were seeing the risk score request be aborted and this was creating the error toast. - Do not toast if an abort error is thrown - Do not abort the request unless the component receives `skip:true` ### Test Steps 1. Use the security document generator `yarn start entity-store` command to load entities and enable the risk engine 2. Enable the entity store 3. from the entities table open the entity flyout 4. Assign/change asset criticality 5. observe the error is not present ### Why did the bug happen? The risk score component stops rendering because the conditions for aborting and searching differ. So we aborted the HTTP call but didn't search again. I believe this PR elastic#201810 introduced the bug --------- Co-authored-by: machadoum <pablo.nevesmachado@elastic.co> (cherry picked from commit 64d20bb)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
10 similar comments
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
May 23, 2025
…uest (#219858) (#220209) # Backport This will backport the following commits from `main` to `9.0`: - [[Entity Analytics] [bug-fix] Do not abort risk score search request (#219858)](#219858) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"mark.hopkin@elastic.co"},"sourceCommit":{"committedDate":"2025-05-06T09:04:02Z","message":"[Entity Analytics] [bug-fix] Do not abort risk score search request (#219858)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/219490\n\nFix an error toast appearing when changing an entities asset criticality\nfrom the entity flyout. See video on issue above for more detail.\n\nWe were seeing the risk score request be aborted and this was creating\nthe error toast.\n\n- Do not toast if an abort error is thrown\n- Do not abort the request unless the component receives `skip:true`\n\n### Test Steps\n\n1. Use the security document generator `yarn start entity-store` command\nto load entities and enable the risk engine\n2. Enable the entity store\n3. from the entities table open the entity flyout\n4. Assign/change asset criticality\n5. observe the error is not present\n\n### Why did the bug happen?\nThe risk score component stops rendering because the conditions for\naborting and searching differ. So we aborted the HTTP call but didn't\nsearch again.\n\nI believe this PR https://github.com/elastic/kibana/pull/201810\nintroduced the bug\n\n---------\n\nCo-authored-by: machadoum <pablo.nevesmachado@elastic.co>","sha":"64d20bb00b9e314c9abe257c8453c2684bccc0a3","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-minor","Team:Entity Analytics","v9.1.0","v9.0.2"],"title":"[Entity Analytics] [bug-fix] Do not abort risk score search request","number":219858,"url":"https://github.com/elastic/kibana/pull/219858","mergeCommit":{"message":"[Entity Analytics] [bug-fix] Do not abort risk score search request (#219858)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/219490\n\nFix an error toast appearing when changing an entities asset criticality\nfrom the entity flyout. See video on issue above for more detail.\n\nWe were seeing the risk score request be aborted and this was creating\nthe error toast.\n\n- Do not toast if an abort error is thrown\n- Do not abort the request unless the component receives `skip:true`\n\n### Test Steps\n\n1. Use the security document generator `yarn start entity-store` command\nto load entities and enable the risk engine\n2. Enable the entity store\n3. from the entities table open the entity flyout\n4. Assign/change asset criticality\n5. observe the error is not present\n\n### Why did the bug happen?\nThe risk score component stops rendering because the conditions for\naborting and searching differ. So we aborted the HTTP call but didn't\nsearch again.\n\nI believe this PR https://github.com/elastic/kibana/pull/201810\nintroduced the bug\n\n---------\n\nCo-authored-by: machadoum <pablo.nevesmachado@elastic.co>","sha":"64d20bb00b9e314c9abe257c8453c2684bccc0a3"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219858","number":219858,"mergeCommit":{"message":"[Entity Analytics] [bug-fix] Do not abort risk score search request (#219858)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/219490\n\nFix an error toast appearing when changing an entities asset criticality\nfrom the entity flyout. See video on issue above for more detail.\n\nWe were seeing the risk score request be aborted and this was creating\nthe error toast.\n\n- Do not toast if an abort error is thrown\n- Do not abort the request unless the component receives `skip:true`\n\n### Test Steps\n\n1. Use the security document generator `yarn start entity-store` command\nto load entities and enable the risk engine\n2. Enable the entity store\n3. from the entities table open the entity flyout\n4. Assign/change asset criticality\n5. observe the error is not present\n\n### Why did the bug happen?\nThe risk score component stops rendering because the conditions for\naborting and searching differ. So we aborted the HTTP call but didn't\nsearch again.\n\nI believe this PR https://github.com/elastic/kibana/pull/201810\nintroduced the bug\n\n---------\n\nCo-authored-by: machadoum <pablo.nevesmachado@elastic.co>","sha":"64d20bb00b9e314c9abe257c8453c2684bccc0a3"}},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co> Co-authored-by: machadoum <pablo.nevesmachado@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…lastic#219858) ## Summary Closes elastic#219490 Fix an error toast appearing when changing an entities asset criticality from the entity flyout. See video on issue above for more detail. We were seeing the risk score request be aborted and this was creating the error toast. - Do not toast if an abort error is thrown - Do not abort the request unless the component receives `skip:true` ### Test Steps 1. Use the security document generator `yarn start entity-store` command to load entities and enable the risk engine 2. Enable the entity store 3. from the entities table open the entity flyout 4. Assign/change asset criticality 5. observe the error is not present ### Why did the bug happen? The risk score component stops rendering because the conditions for aborting and searching differ. So we aborted the HTTP call but didn't search again. I believe this PR elastic#201810 introduced the bug --------- Co-authored-by: machadoum <pablo.nevesmachado@elastic.co>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
…lastic#219858) ## Summary Closes elastic#219490 Fix an error toast appearing when changing an entities asset criticality from the entity flyout. See video on issue above for more detail. We were seeing the risk score request be aborted and this was creating the error toast. - Do not toast if an abort error is thrown - Do not abort the request unless the component receives `skip:true` ### Test Steps 1. Use the security document generator `yarn start entity-store` command to load entities and enable the risk engine 2. Enable the entity store 3. from the entities table open the entity flyout 4. Assign/change asset criticality 5. observe the error is not present ### Why did the bug happen? The risk score component stops rendering because the conditions for aborting and searching differ. So we aborted the HTTP call but didn't search again. I believe this PR elastic#201810 introduced the bug --------- Co-authored-by: machadoum <pablo.nevesmachado@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #219490
Fix an error toast appearing when changing an entities asset criticality from the entity flyout. See video on issue above for more detail.
We were seeing the risk score request be aborted and this was creating the error toast.
skip:trueTest Steps
yarn start entity-storecommand to load entities and enable the risk engineWhy did the bug happen?
The risk score component stops rendering because the conditions for aborting and searching differ. So we aborted the HTTP call but didn't search again.
I believe this PR #201810 introduced the bug