Skip to content

[EuiDatGrid] Replace expandMini with expand icon in data grid #8646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryankeairns merged 3 commits into from
Apr 28, 2025
Merged

[EuiDatGrid] Replace expandMini with expand icon in data grid #8646

ryankeairns merged 3 commits into from
Apr 28, 2025

Conversation

@ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Apr 25, 2025 •
edited
Loading

Summary

As part of the icon redesign effort, we will be deprecating the expandMini glyph. In hindsight, it is not needed given the expand icon can simply be sized down as evidenced by this change for data grid.

The new expand icon was previously implemented while expandMini still has the hold style. This PR removes it from the data grid and sets us up to deprecate this icon along with several others.

After

Before

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@ryankeairns ryankeairns marked this pull request as ready for review April 25, 2025 22:37
@ryankeairns ryankeairns requested a review from a team as a code owner April 25, 2025 22:37
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 25, 2025

💚 Build Succeeded

History

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 25, 2025

💚 Build Succeeded

History

@ryankeairns ryankeairns added the design decision Use this to flag an item that needs input from the design team label Apr 25, 2025
weronikaolejniczak
weronikaolejniczak approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good! 🟢

@ryankeairns ryankeairns merged commit a38d241 into main Apr 28, 2025
7 checks passed
@ryankeairns ryankeairns deleted the rk/mini-data-grid-improvement branch April 28, 2025 16:34
@mgadewoll
Copy link
Contributor

mgadewoll commented Apr 30, 2025

ℹ️ When updating icons, please remember to run VRT tests too 😅

This was referenced May 5, 2025
Merged
Merged
mgadewoll added a commit to elastic/kibana that referenced this pull request May 6, 2025
@mgadewoll
Upgrade EUI to v102.1.0 (#220039)
bca8299 
`102.0.0` ⏩ `102.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

>[!NOTE]
There is also the sibling PR for `8.19` with old Amsterdam theme ready
for review [here](#220049). It
contains the same changes.

## Changes

- Updated test selector (due to changed tooltip placement in
[#8644](elastic/eui#8644))
- snapshot updates

## Package updates

### `@elastic/eui`

#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)

- Update `EuiDataGrid` to use `expand` glyph
([#8646](elastic/eui#8646))

**Accessibility**

- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on
sortable cell elements, ensuring tooltips appear on focus
([#8644](elastic/eui#8644))
- Improved the accessibility of `EuiColorPicker` by:
([#8639](elastic/eui#8639))
  - preventing duplicate color output for screen readers
- adding tooltips with visual color labels for the selected colors on
the saturation and hue sliders
  - updated accessible labels and announcements to be more descriptive

**Dependency updates**

- Updated `typescript` to v5.8.3
([#8626](elastic/eui#8626))
mgadewoll added a commit to elastic/kibana that referenced this pull request May 6, 2025
@mgadewoll
Upgrade EUI to v102.1.0 (#220049)
434fd04 
`102.0.0` ⏩ `102.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

>[!IMPORTANT]
This PR is a direct sibling to this [upgrade
PR](#220039) to `main`. The
difference is that it adds a standalone EUI package with the previous
"Amsterdam" theme.
Apart from the theme difference, **there are no further changes added**.

## Changes

- Updated test selector (due to changed tooltip placement in
[#8644](elastic/eui#8644))
- snapshot updates

## Package updates

### `@elastic/eui`

#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)

- Update `EuiDataGrid` to use `expand` glyph
([#8646](elastic/eui#8646))

**Accessibility**

- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on
sortable cell elements, ensuring tooltips appear on focus
([#8644](elastic/eui#8644))
- Improved the accessibility of `EuiColorPicker` by:
([#8639](elastic/eui#8639))
  - preventing duplicate color output for screen readers
- adding tooltips with visual color labels for the selected colors on
the saturation and hue sliders
  - updated accessible labels and announcements to be more descriptive

**Dependency updates**

- Updated `typescript` to v5.8.3
([#8626](elastic/eui#8626))
mgadewoll added a commit to mgadewoll/kibana that referenced this pull request May 6, 2025
@mgadewoll
Upgrade EUI to v102.1.0 (elastic#220039)
4e0cb69 
`102.0.0` ⏩ `102.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

>[!NOTE]
There is also the sibling PR for `8.19` with old Amsterdam theme ready
for review [here](elastic#220049). It
contains the same changes.

## Changes

- Updated test selector (due to changed tooltip placement in
[elastic#8644](elastic/eui#8644))
- snapshot updates

## Package updates

### `@elastic/eui`

#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)

- Update `EuiDataGrid` to use `expand` glyph
([elastic#8646](elastic/eui#8646))

**Accessibility**

- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on
sortable cell elements, ensuring tooltips appear on focus
([elastic#8644](elastic/eui#8644))
- Improved the accessibility of `EuiColorPicker` by:
([elastic#8639](elastic/eui#8639))
  - preventing duplicate color output for screen readers
- adding tooltips with visual color labels for the selected colors on
the saturation and hue sliders
  - updated accessible labels and announcements to be more descriptive

**Dependency updates**

- Updated `typescript` to v5.8.3
([elastic#8626](elastic/eui#8626))

(cherry picked from commit bca8299)

# Conflicts:
#	x-pack/solutions/observability/plugins/infra/public/components/asset_details/tabs/processes/__snapshots__/processes_table.test.tsx.snap
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@mgadewoll @akowalska622
Upgrade EUI to v102.1.0 (elastic#220039)
c8925d2 
`102.0.0` ⏩ `102.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

>[!NOTE]
There is also the sibling PR for `8.19` with old Amsterdam theme ready
for review [here](elastic#220049). It
contains the same changes.

## Changes

- Updated test selector (due to changed tooltip placement in
[elastic#8644](elastic/eui#8644))
- snapshot updates

## Package updates

### `@elastic/eui`

#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)

- Update `EuiDataGrid` to use `expand` glyph
([elastic#8646](elastic/eui#8646))

**Accessibility**

- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on
sortable cell elements, ensuring tooltips appear on focus
([elastic#8644](elastic/eui#8644))
- Improved the accessibility of `EuiColorPicker` by:
([elastic#8639](elastic/eui#8639))
  - preventing duplicate color output for screen readers
- adding tooltips with visual color labels for the selected colors on
the saturation and hue sliders
  - updated accessible labels and announcements to be more descriptive

**Dependency updates**

- Updated `typescript` to v5.8.3
([elastic#8626](elastic/eui#8626))
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
@mgadewoll @qn895
Upgrade EUI to v102.1.0 (elastic#220039)
96b1ce3 
`102.0.0` ⏩ `102.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

>[!NOTE]
There is also the sibling PR for `8.19` with old Amsterdam theme ready
for review [here](elastic#220049). It
contains the same changes.

## Changes

- Updated test selector (due to changed tooltip placement in
[elastic#8644](elastic/eui#8644))
- snapshot updates

## Package updates

### `@elastic/eui`

#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)

- Update `EuiDataGrid` to use `expand` glyph
([elastic#8646](elastic/eui#8646))

**Accessibility**

- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on
sortable cell elements, ensuring tooltips appear on focus
([elastic#8644](elastic/eui#8644))
- Improved the accessibility of `EuiColorPicker` by:
([elastic#8639](elastic/eui#8639))
  - preventing duplicate color output for screen readers
- adding tooltips with visual color labels for the selected colors on
the saturation and hue sliders
  - updated accessible labels and announcements to be more descriptive

**Dependency updates**

- Updated `typescript` to v5.8.3
([elastic#8626](elastic/eui#8626))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weronikaolejniczak weronikaolejniczak weronikaolejniczak approved these changes

Assignees

No one assigned

Labels

design decision Use this to flag an item that needs input from the design team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ryankeairns @elasticmachine @mgadewoll @weronikaolejniczak