Avoid printing notify object in lang selector on error#8639
Merged
Bargs merged 1 commit intoelastic:masterfrom Nov 3, 2016
Merged
Avoid printing notify object in lang selector on error#8639Bargs merged 1 commit intoelastic:masterfrom
Bargs merged 1 commit intoelastic:masterfrom
Conversation
When ES is unavailable and we can't get the list of enabled scripting langs we display a notification to the user. We were also accidentally returning that notification object from the service method and displaying its toString representation in the language select drop down. Now we simplay return an empty array so the dropdown is rendered without options. Fixes elastic#8636
Contributor
Author
|
@thomasneirynck mind giving this a second look while you're in the scripted field area anyway? |
Contributor
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Nov 3, 2016
Backports PR #8639 **Commit 1:** Avoid printing notify object in lang selector on error When ES is unavailable and we can't get the list of enabled scripting langs we display a notification to the user. We were also accidentally returning that notification object from the service method and displaying its toString representation in the language select drop down. Now we simplay return an empty array so the dropdown is rendered without options. Fixes #8636 * Original sha: 051c554 * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-12T15:25:15Z
Bargs
pushed a commit
that referenced
this pull request
Nov 3, 2016
Backports PR #8639 **Commit 1:** Avoid printing notify object in lang selector on error When ES is unavailable and we can't get the list of enabled scripting langs we display a notification to the user. We were also accidentally returning that notification object from the service method and displaying its toString representation in the language select drop down. Now we simplay return an empty array so the dropdown is rendered without options. Fixes #8636 * Original sha: 051c554 * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-12T15:25:15Z
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 10, 2016
When ES is unavailable and we can't get the list of enabled scripting langs we display a notification to the user. We were also accidentally returning that notification object from the service method and displaying its toString representation in the language select drop down. Now we simplay return an empty array so the dropdown is rendered without options. Fixes elastic#8636
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#8639 **Commit 1:** Avoid printing notify object in lang selector on error When ES is unavailable and we can't get the list of enabled scripting langs we display a notification to the user. We were also accidentally returning that notification object from the service method and displaying its toString representation in the language select drop down. Now we simplay return an empty array so the dropdown is rendered without options. Fixes elastic#8636 * Original sha: 051c554 * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-12T15:25:15Z Former-commit-id: 6ddafd2
mgadewoll
added a commit
that referenced
this pull request
May 6, 2025
`102.0.0` ⏩ `102.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) >[!NOTE] There is also the sibling PR for `8.19` with old Amsterdam theme ready for review [here](#220049). It contains the same changes. ## Changes - Updated test selector (due to changed tooltip placement in [#8644](elastic/eui#8644)) - snapshot updates ## Package updates ### `@elastic/eui` #### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0) - Update `EuiDataGrid` to use `expand` glyph ([#8646](elastic/eui#8646)) **Accessibility** - Updated `EuiTableHeaderCell` to output `nameTooltip` directly on sortable cell elements, ensuring tooltips appear on focus ([#8644](elastic/eui#8644)) - Improved the accessibility of `EuiColorPicker` by: ([#8639](elastic/eui#8639)) - preventing duplicate color output for screen readers - adding tooltips with visual color labels for the selected colors on the saturation and hue sliders - updated accessible labels and announcements to be more descriptive **Dependency updates** - Updated `typescript` to v5.8.3 ([#8626](elastic/eui#8626))
mgadewoll
added a commit
that referenced
this pull request
May 6, 2025
`102.0.0` ⏩ `102.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) >[!IMPORTANT] This PR is a direct sibling to this [upgrade PR](#220039) to `main`. The difference is that it adds a standalone EUI package with the previous "Amsterdam" theme. Apart from the theme difference, **there are no further changes added**. ## Changes - Updated test selector (due to changed tooltip placement in [#8644](elastic/eui#8644)) - snapshot updates ## Package updates ### `@elastic/eui` #### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0) - Update `EuiDataGrid` to use `expand` glyph ([#8646](elastic/eui#8646)) **Accessibility** - Updated `EuiTableHeaderCell` to output `nameTooltip` directly on sortable cell elements, ensuring tooltips appear on focus ([#8644](elastic/eui#8644)) - Improved the accessibility of `EuiColorPicker` by: ([#8639](elastic/eui#8639)) - preventing duplicate color output for screen readers - adding tooltips with visual color labels for the selected colors on the saturation and hue sliders - updated accessible labels and announcements to be more descriptive **Dependency updates** - Updated `typescript` to v5.8.3 ([#8626](elastic/eui#8626))
mgadewoll
added a commit
to mgadewoll/kibana
that referenced
this pull request
May 6, 2025
`102.0.0` ⏩ `102.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) >[!NOTE] There is also the sibling PR for `8.19` with old Amsterdam theme ready for review [here](elastic#220049). It contains the same changes. ## Changes - Updated test selector (due to changed tooltip placement in [elastic#8644](elastic/eui#8644)) - snapshot updates ## Package updates ### `@elastic/eui` #### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0) - Update `EuiDataGrid` to use `expand` glyph ([elastic#8646](elastic/eui#8646)) **Accessibility** - Updated `EuiTableHeaderCell` to output `nameTooltip` directly on sortable cell elements, ensuring tooltips appear on focus ([elastic#8644](elastic/eui#8644)) - Improved the accessibility of `EuiColorPicker` by: ([elastic#8639](elastic/eui#8639)) - preventing duplicate color output for screen readers - adding tooltips with visual color labels for the selected colors on the saturation and hue sliders - updated accessible labels and announcements to be more descriptive **Dependency updates** - Updated `typescript` to v5.8.3 ([elastic#8626](elastic/eui#8626)) (cherry picked from commit bca8299) # Conflicts: # x-pack/solutions/observability/plugins/infra/public/components/asset_details/tabs/processes/__snapshots__/processes_table.test.tsx.snap
mgadewoll
added a commit
that referenced
this pull request
May 6, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Upgrade EUI to v102.1.0 (#220039)](#220039) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Lene Gadewoll","email":"lene.gadewoll@elastic.co"},"sourceCommit":{"committedDate":"2025-05-06T14:38:55Z","message":"Upgrade EUI to v102.1.0 (#220039)\n\n`102.0.0` ⏩ `102.1.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n>[!NOTE]\nThere is also the sibling PR for `8.19` with old Amsterdam theme ready\nfor review [here](#220049). It\ncontains the same changes.\n\n## Changes\n\n- Updated test selector (due to changed tooltip placement in\n[#8644](https://github.com/elastic/eui/pull/8644))\n- snapshot updates\n\n## Package updates\n\n### `@elastic/eui`\n\n#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)\n\n- Update `EuiDataGrid` to use `expand` glyph\n([#8646](https://github.com/elastic/eui/pull/8646))\n\n**Accessibility**\n\n- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on\nsortable cell elements, ensuring tooltips appear on focus\n([#8644](https://github.com/elastic/eui/pull/8644))\n- Improved the accessibility of `EuiColorPicker` by:\n([#8639](https://github.com/elastic/eui/pull/8639))\n - preventing duplicate color output for screen readers\n- adding tooltips with visual color labels for the selected colors on\nthe saturation and hue sliders\n - updated accessible labels and announcements to be more descriptive\n\n**Dependency updates**\n\n- Updated `typescript` to v5.8.3\n([#8626](https://github.com/elastic/eui/pull/8626))","sha":"bca8299927ef023215494fb7bc21ad90891ffc54","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","backport:prev-minor","v9.1.0","v9.0.1"],"title":"Upgrade EUI to v102.1.0","number":220039,"url":"https://github.com/elastic/kibana/pull/220039","mergeCommit":{"message":"Upgrade EUI to v102.1.0 (#220039)\n\n`102.0.0` ⏩ `102.1.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n>[!NOTE]\nThere is also the sibling PR for `8.19` with old Amsterdam theme ready\nfor review [here](#220049). It\ncontains the same changes.\n\n## Changes\n\n- Updated test selector (due to changed tooltip placement in\n[#8644](https://github.com/elastic/eui/pull/8644))\n- snapshot updates\n\n## Package updates\n\n### `@elastic/eui`\n\n#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)\n\n- Update `EuiDataGrid` to use `expand` glyph\n([#8646](https://github.com/elastic/eui/pull/8646))\n\n**Accessibility**\n\n- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on\nsortable cell elements, ensuring tooltips appear on focus\n([#8644](https://github.com/elastic/eui/pull/8644))\n- Improved the accessibility of `EuiColorPicker` by:\n([#8639](https://github.com/elastic/eui/pull/8639))\n - preventing duplicate color output for screen readers\n- adding tooltips with visual color labels for the selected colors on\nthe saturation and hue sliders\n - updated accessible labels and announcements to be more descriptive\n\n**Dependency updates**\n\n- Updated `typescript` to v5.8.3\n([#8626](https://github.com/elastic/eui/pull/8626))","sha":"bca8299927ef023215494fb7bc21ad90891ffc54"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220039","number":220039,"mergeCommit":{"message":"Upgrade EUI to v102.1.0 (#220039)\n\n`102.0.0` ⏩ `102.1.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n>[!NOTE]\nThere is also the sibling PR for `8.19` with old Amsterdam theme ready\nfor review [here](#220049). It\ncontains the same changes.\n\n## Changes\n\n- Updated test selector (due to changed tooltip placement in\n[#8644](https://github.com/elastic/eui/pull/8644))\n- snapshot updates\n\n## Package updates\n\n### `@elastic/eui`\n\n#### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0)\n\n- Update `EuiDataGrid` to use `expand` glyph\n([#8646](https://github.com/elastic/eui/pull/8646))\n\n**Accessibility**\n\n- Updated `EuiTableHeaderCell` to output `nameTooltip` directly on\nsortable cell elements, ensuring tooltips appear on focus\n([#8644](https://github.com/elastic/eui/pull/8644))\n- Improved the accessibility of `EuiColorPicker` by:\n([#8639](https://github.com/elastic/eui/pull/8639))\n - preventing duplicate color output for screen readers\n- adding tooltips with visual color labels for the selected colors on\nthe saturation and hue sliders\n - updated accessible labels and announcements to be more descriptive\n\n**Dependency updates**\n\n- Updated `typescript` to v5.8.3\n([#8626](https://github.com/elastic/eui/pull/8626))","sha":"bca8299927ef023215494fb7bc21ad90891ffc54"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
`102.0.0` ⏩ `102.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) >[!NOTE] There is also the sibling PR for `8.19` with old Amsterdam theme ready for review [here](elastic#220049). It contains the same changes. ## Changes - Updated test selector (due to changed tooltip placement in [elastic#8644](elastic/eui#8644)) - snapshot updates ## Package updates ### `@elastic/eui` #### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0) - Update `EuiDataGrid` to use `expand` glyph ([elastic#8646](elastic/eui#8646)) **Accessibility** - Updated `EuiTableHeaderCell` to output `nameTooltip` directly on sortable cell elements, ensuring tooltips appear on focus ([elastic#8644](elastic/eui#8644)) - Improved the accessibility of `EuiColorPicker` by: ([elastic#8639](elastic/eui#8639)) - preventing duplicate color output for screen readers - adding tooltips with visual color labels for the selected colors on the saturation and hue sliders - updated accessible labels and announcements to be more descriptive **Dependency updates** - Updated `typescript` to v5.8.3 ([elastic#8626](elastic/eui#8626))
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
`102.0.0` ⏩ `102.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) >[!NOTE] There is also the sibling PR for `8.19` with old Amsterdam theme ready for review [here](elastic#220049). It contains the same changes. ## Changes - Updated test selector (due to changed tooltip placement in [elastic#8644](elastic/eui#8644)) - snapshot updates ## Package updates ### `@elastic/eui` #### [`v102.1.0`](https://github.com/elastic/eui/releases/v102.1.0) - Update `EuiDataGrid` to use `expand` glyph ([elastic#8646](elastic/eui#8646)) **Accessibility** - Updated `EuiTableHeaderCell` to output `nameTooltip` directly on sortable cell elements, ensuring tooltips appear on focus ([elastic#8644](elastic/eui#8644)) - Improved the accessibility of `EuiColorPicker` by: ([elastic#8639](elastic/eui#8639)) - preventing duplicate color output for screen readers - adding tooltips with visual color labels for the selected colors on the saturation and hue sliders - updated accessible labels and announcements to be more descriptive **Dependency updates** - Updated `typescript` to v5.8.3 ([elastic#8626](elastic/eui#8626))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ES is unavailable and we can't get the list of enabled scripting
langs we display a notification to the user. We were also accidentally
returning that notification object from the service method and
displaying its toString representation in the language select drop down.
Now we simplay return an empty array so the dropdown is rendered without
options.
Fixes #8636