[discover session] fix drill down state not saved with by-value discover sessions#219857
Merged
nreese merged 2 commits intoelastic:mainfrom May 6, 2025
Merged
[discover session] fix drill down state not saved with by-value discover sessions#219857nreese merged 2 commits intoelastic:mainfrom
nreese merged 2 commits intoelastic:mainfrom
Conversation
nreese
added
release_note:fix
Team:DataDiscovery
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
Author
|
@elasticmachine merge upstream |
davismcphee
approved these changes
May 5, 2025
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Works as expected, thanks for fixing it!
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0 https://github.com/elastic/kibana/actions/runs/14849165464 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 6, 2025
…ver sessions (elastic#219857) Fixes elastic#219856 Test instructions * install web logs sample data * create new dashboard * Click "Add from library" and select "[Logs] Visits" * Open panel context menu and select "Unlink from library" * Save dashboard * add drilldown to discover session * Save dashboard * re-open dashboard - ensure drill down still exists Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 5225bbc)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 6, 2025
…ver sessions (elastic#219857) Fixes elastic#219856 Test instructions * install web logs sample data * create new dashboard * Click "Add from library" and select "[Logs] Visits" * Open panel context menu and select "Unlink from library" * Save dashboard * add drilldown to discover session * Save dashboard * re-open dashboard - ensure drill down still exists Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 5225bbc)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 6, 2025
…ver sessions (elastic#219857) Fixes elastic#219856 Test instructions * install web logs sample data * create new dashboard * Click "Add from library" and select "[Logs] Visits" * Open panel context menu and select "Unlink from library" * Save dashboard * add drilldown to discover session * Save dashboard * re-open dashboard - ensure drill down still exists Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 5225bbc)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 6, 2025
…ver sessions (elastic#219857) Fixes elastic#219856 Test instructions * install web logs sample data * create new dashboard * Click "Add from library" and select "[Logs] Visits" * Open panel context menu and select "Unlink from library" * Save dashboard * add drilldown to discover session * Save dashboard * re-open dashboard - ensure drill down still exists Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 5225bbc)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 6, 2025
…e discover sessions (#219857) (#220181) # Backport This will backport the following commits from `main` to `8.18`: - [[discover session] fix drill down state not saved with by-value discover sessions (#219857)](#219857) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-05-06T00:38:03Z","message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0","v8.17.7","v8.18.2","v9.0.2"],"title":"[discover session] fix drill down state not saved with by-value discover sessions","number":219857,"url":"https://github.com/elastic/kibana/pull/219857","mergeCommit":{"message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.17","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219857","number":219857,"mergeCommit":{"message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
May 6, 2025
…e discover sessions (#219857) (#220180) # Backport This will backport the following commits from `main` to `8.17`: - [[discover session] fix drill down state not saved with by-value discover sessions (#219857)](#219857) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-05-06T00:38:03Z","message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0","v8.17.7","v8.18.2","v9.0.2"],"title":"[discover session] fix drill down state not saved with by-value discover sessions","number":219857,"url":"https://github.com/elastic/kibana/pull/219857","mergeCommit":{"message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.17","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219857","number":219857,"mergeCommit":{"message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
May 6, 2025
… discover sessions (#219857) (#220183) # Backport This will backport the following commits from `main` to `9.0`: - [[discover session] fix drill down state not saved with by-value discover sessions (#219857)](#219857) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-05-06T00:38:03Z","message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0","v8.17.7","v8.18.2","v9.0.2"],"title":"[discover session] fix drill down state not saved with by-value discover sessions","number":219857,"url":"https://github.com/elastic/kibana/pull/219857","mergeCommit":{"message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.17","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219857","number":219857,"mergeCommit":{"message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
May 6, 2025
…e discover sessions (#219857) (#220182) # Backport This will backport the following commits from `main` to `8.19`: - [[discover session] fix drill down state not saved with by-value discover sessions (#219857)](#219857) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-05-06T00:38:03Z","message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0","v8.17.7","v8.18.2","v9.0.2"],"title":"[discover session] fix drill down state not saved with by-value discover sessions","number":219857,"url":"https://github.com/elastic/kibana/pull/219857","mergeCommit":{"message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.17","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219857","number":219857,"mergeCommit":{"message":"[discover session] fix drill down state not saved with by-value discover sessions (#219857)\n\nFixes https://github.com/elastic/kibana/issues/219856\n\nTest instructions\n* install web logs sample data\n* create new dashboard\n* Click \"Add from library\" and select \"[Logs] Visits\"\n* Open panel context menu and select \"Unlink from library\"\n* Save dashboard\n* add drilldown to discover session\n* Save dashboard\n* re-open dashboard - ensure drill down still exists\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5225bbc46f6e98417982f52622cb9b7be1b27fbc"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Nathan Reese <reese.nathan@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…ver sessions (elastic#219857) Fixes elastic#219856 Test instructions * install web logs sample data * create new dashboard * Click "Add from library" and select "[Logs] Visits" * Open panel context menu and select "Unlink from library" * Save dashboard * add drilldown to discover session * Save dashboard * re-open dashboard - ensure drill down still exists Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
…ver sessions (elastic#219857) Fixes elastic#219856 Test instructions * install web logs sample data * create new dashboard * Click "Add from library" and select "[Logs] Visits" * Open panel context menu and select "Unlink from library" * Save dashboard * add drilldown to discover session * Save dashboard * re-open dashboard - ensure drill down still exists Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #219856
Test instructions