Skip to content

[9.0] [Solution Side Nav] Misc UI fixes (#216109)#217231

Merged
tsullivan merged 1 commit intoelastic:9.0from
tsullivan:backport/9.0/pr-216109
Apr 4, 2025
Merged

[9.0] [Solution Side Nav] Misc UI fixes (#216109)#217231
tsullivan merged 1 commit intoelastic:9.0from
tsullivan:backport/9.0/pr-216109

Conversation

@tsullivan
Copy link
Member

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

Part of elastic/kibana-team#1439
Pulled from elastic#210893
elastic#215969

## Summary

1. Allow item in the secondary panel to use the `renderItem` field
2. Fix handling of `defaultIsCollapsed` for items in the secondary panel
3. Allow secondary panel to contain a mix of ungrouped items as well as
sub-groups of items

![alksdjnfgklsdfhglskdhkds](https://github.com/user-attachments/assets/11d316d6-6c9a-4743-897f-93c40efa9013)

4. Fix the flagging of the "active" parent in the main nav panel, based
on the current URL

![jhgkdfgkjfhkhn](https://github.com/user-attachments/assets/b5f6efe3-e8f5-494b-bc12-abbd51acc12a)

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 05a8703)

# Conflicts:
#	src/platform/packages/shared/shared-ux/chrome/navigation/src/ui/navigation.stories.tsx
@tsullivan tsullivan requested a review from kibanamachine as a code owner April 4, 2025 16:03
@tsullivan tsullivan added the backport This PR is a backport of another PR label Apr 4, 2025
@tsullivan tsullivan enabled auto-merge (squash) April 4, 2025 16:03
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
navigation 20.1KB 19.9KB -185.0B
serverless 20.8KB 20.7KB -185.0B
total -370.0B

@tsullivan tsullivan merged commit 4e376a8 into elastic:9.0 Apr 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants