Skip to content

[Solution Side Nav] Add back external link indicator to sidenav#215946

Merged
kowalczyk-krzysztof merged 11 commits intoelastic:mainfrom
kowalczyk-krzysztof:feat/add-external-link-indicator-back-to-sidenav
Apr 3, 2025
Merged

[Solution Side Nav] Add back external link indicator to sidenav#215946
kowalczyk-krzysztof merged 11 commits intoelastic:mainfrom
kowalczyk-krzysztof:feat/add-external-link-indicator-back-to-sidenav

Conversation

@kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Mar 25, 2025 •
edited by kibanamachine
Loading

Summary

This PR adds back external link indicator to sidenav items.

Screenshot 2025-04-01 at 20 35 14

@kowalczyk-krzysztof kowalczyk-krzysztof added release_note:enhancement enhancement New value added to drive a business result Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// backport:prev-minor labels Mar 25, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Mar 25, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/add-external-link-indicator-back-to-sidenav branch 2 times, most recently from 63cb7fa to a58391d Compare March 31, 2025 11:10
@kowalczyk-krzysztof kowalczyk-krzysztof marked this pull request as ready for review April 1, 2025 18:35
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner April 1, 2025 18:35
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 1, 2025

Pinging @elastic/appex-sharedux (Team:SharedUX)

tsullivan
tsullivan requested changes Apr 2, 2025
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the external link indicator is showing up next to all of the links in the nav.
Here, I tested with a space set to the Security solution view:

image

@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/add-external-link-indicator-back-to-sidenav branch from ad0cfb1 to eeb1bf0 Compare April 2, 2025 10:39
@kowalczyk-krzysztof
Copy link
Member Author

kowalczyk-krzysztof commented Apr 2, 2025 •
edited
Loading

It looks like the external link indicator is showing up next to all of the links in the nav. Here, I tested with a space set to the Security solution view:
image

This is odd. In Storybook everything is fine. I'll investigate it.

EDIT: For some reason navNode.isExternalLink is always true but only in actual Kibana and not in Storybook

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 2, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
navigation 20.1KB 20.2KB +95.0B
serverless 20.8KB 20.9KB +95.0B
total +190.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 432.4KB 432.4KB -7.0B

History

cc @kowalczyk-krzysztof

tsullivan
tsullivan approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit e21739b into elastic:main Apr 3, 2025
11 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 3, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14254048466

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 3, 2025

💔 All backports failed

Status Branch Result
❌ 9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- [Solution Side Nav] Misc UI fixes (#216109)

Manual backport

To create the backport manually run:

node scripts/backport --pr 215946

Questions ?

Please refer to the Backport tool documentation

@kowalczyk-krzysztof kowalczyk-krzysztof added backport:version Backport to applied version labels v9.0.0 v8.19.0 and removed backport:prev-minor labels Apr 4, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof mentioned this pull request Apr 4, 2025
Merged
kowalczyk-krzysztof added a commit to kowalczyk-krzysztof/kibana that referenced this pull request Apr 4, 2025
@kowalczyk-krzysztof
[Solution Side Nav] Add back external link indicator to sidenav (elas…
15bd59a 
…tic#215946)

## Summary

This PR adds back external link indicator to sidenav items.

![Screenshot 2025-04-01 at 20 35
14](https://github.com/user-attachments/assets/c82def72-780e-4bb6-812d-d51244e90685)

(cherry picked from commit e21739b)
@kowalczyk-krzysztof
Copy link
Member Author

kowalczyk-krzysztof commented Apr 4, 2025

💔 Some backports could not be created

Status Branch Result
✅ 9.0
❌ 8.x Conflict resolution was aborted by the user

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 215946

Questions ?

Please refer to the Backport tool documentation

@kowalczyk-krzysztof kowalczyk-krzysztof mentioned this pull request Apr 4, 2025
Merged
@kowalczyk-krzysztof
Copy link
Member Author

kowalczyk-krzysztof commented Apr 4, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kowalczyk-krzysztof added a commit to kowalczyk-krzysztof/kibana that referenced this pull request Apr 4, 2025
@kowalczyk-krzysztof
[Solution Side Nav] Add back external link indicator to sidenav (elas…
a11947c 
…tic#215946)

## Summary

This PR adds back external link indicator to sidenav items.

![Screenshot 2025-04-01 at 20 35
14](https://github.com/user-attachments/assets/c82def72-780e-4bb6-812d-d51244e90685)

(cherry picked from commit e21739b)

# Conflicts:
#	src/platform/packages/shared/shared-ux/chrome/navigation/src/ui/navigation.stories.tsx
kowalczyk-krzysztof added a commit that referenced this pull request Apr 4, 2025
@kowalczyk-krzysztof
[9.0] [Solution Side Nav] Add back external link indicator to sidenav (…
6cdbf70 
…#215946) (#217242)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Solution Side Nav] Add back external link indicator to sidenav
(#215946)](#215946)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-04-03T22:34:23Z","message":"[Solution
Side Nav] Add back external link indicator to sidenav (#215946)\n\n##
Summary\n\nThis PR adds back external link indicator to sidenav
items.\n\n![Screenshot 2025-04-01 at 20
35\n14](https://github.com/user-attachments/assets/c82def72-780e-4bb6-812d-d51244e90685)","sha":"e21739b657d57a884b7a8da713a34f4f5c8273a2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","enhancement","v9.0.0","Team:SharedUX","backport:version","v9.1.0","v8.19.0"],"title":"[Solution
Side Nav] Add back external link indicator to
sidenav","number":215946,"url":"https://github.com/elastic/kibana/pull/215946","mergeCommit":{"message":"[Solution
Side Nav] Add back external link indicator to sidenav (#215946)\n\n##
Summary\n\nThis PR adds back external link indicator to sidenav
items.\n\n![Screenshot 2025-04-01 at 20
35\n14](https://github.com/user-attachments/assets/c82def72-780e-4bb6-812d-d51244e90685)","sha":"e21739b657d57a884b7a8da713a34f4f5c8273a2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215946","number":215946,"mergeCommit":{"message":"[Solution
Side Nav] Add back external link indicator to sidenav (#215946)\n\n##
Summary\n\nThis PR adds back external link indicator to sidenav
items.\n\n![Screenshot 2025-04-01 at 20
35\n14](https://github.com/user-attachments/assets/c82def72-780e-4bb6-812d-d51244e90685)","sha":"e21739b657d57a884b7a8da713a34f4f5c8273a2"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
kowalczyk-krzysztof added a commit that referenced this pull request Apr 4, 2025
@kowalczyk-krzysztof
[8.x] [Solution Side Nav] Add back external link indicator to sidenav (…
1746395 
…#215946) (#217245)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Solution Side Nav] Add back external link indicator to sidenav
(#215946)](#215946)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-04-03T22:34:23Z","message":"[Solution
Side Nav] Add back external link indicator to sidenav (#215946)\n\n##
Summary\n\nThis PR adds back external link indicator to sidenav
items.\n\n![Screenshot 2025-04-01 at 20
35\n14](https://github.com/user-attachments/assets/c82def72-780e-4bb6-812d-d51244e90685)","sha":"e21739b657d57a884b7a8da713a34f4f5c8273a2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","enhancement","v9.0.0","Team:SharedUX","backport:version","v9.1.0","v8.19.0"],"title":"[Solution
Side Nav] Add back external link indicator to
sidenav","number":215946,"url":"https://github.com/elastic/kibana/pull/215946","mergeCommit":{"message":"[Solution
Side Nav] Add back external link indicator to sidenav (#215946)\n\n##
Summary\n\nThis PR adds back external link indicator to sidenav
items.\n\n![Screenshot 2025-04-01 at 20
35\n14](https://github.com/user-attachments/assets/c82def72-780e-4bb6-812d-d51244e90685)","sha":"e21739b657d57a884b7a8da713a34f4f5c8273a2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/217242","number":217242,"state":"OPEN"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215946","number":215946,"mergeCommit":{"message":"[Solution
Side Nav] Add back external link indicator to sidenav (#215946)\n\n##
Summary\n\nThis PR adds back external link indicator to sidenav
items.\n\n![Screenshot 2025-04-01 at 20
35\n14](https://github.com/user-attachments/assets/c82def72-780e-4bb6-812d-d51244e90685)","sha":"e21739b657d57a884b7a8da713a34f4f5c8273a2"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the feat/add-external-link-indicator-back-to-sidenav branch August 1, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsullivan tsullivan tsullivan approved these changes

Assignees

@kowalczyk-krzysztof kowalczyk-krzysztof

Labels

backport:version Backport to applied version labels enhancement New value added to drive a business result release_note:enhancement Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kowalczyk-krzysztof @elasticmachine @kibanamachine @tsullivan @mistic