[ES|QL] Restructure validation code, remove command settings#215056
Merged
drewdaemon merged 20 commits intoelastic:mainfrom Mar 20, 2025
Merged
[ES|QL] Restructure validation code, remove command settings#215056drewdaemon merged 20 commits intoelastic:mainfrom
drewdaemon merged 20 commits intoelastic:mainfrom
Conversation
drewdaemon
added
Feature:ES|QL
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
drewdaemon
added
the
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
23 tasks
stratoula
approved these changes
Mar 20, 2025
Contributor
There was a problem hiding this comment.
This file can be split and cleaned up further (in the future)
Contributor
Author
There was a problem hiding this comment.
Agreed. At least it’s clear now how much of our code is just about checking function args
eokoneyo
approved these changes
Mar 20, 2025
This was referenced Mar 20, 2025
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Mar 20, 2025
…#215056) ## Summary Follow on to several recent efforts including elastic#195418 and elastic#213325 This PR - reorganizes validation code to make dependencies clearer and make it less overwhelming... it's not perfect but it's better - removes the deprecated notion of a command "setting" which only ever applied to `ENRICH`. No regression in `ENRICH` mode validation: <img width="874" alt="Screenshot 2025-03-18 at 1 04 46 PM" src="https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c" /> Or hover <img width="419" alt="Screenshot 2025-03-18 at 7 43 04 PM" src="https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
3 tasks
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13992352224 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 21, 2025
…#215056) ## Summary Follow on to several recent efforts including elastic#195418 and elastic#213325 This PR - reorganizes validation code to make dependencies clearer and make it less overwhelming... it's not perfect but it's better - removes the deprecated notion of a command "setting" which only ever applied to `ENRICH`. No regression in `ENRICH` mode validation: <img width="874" alt="Screenshot 2025-03-18 at 1 04 46 PM" src="https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c" /> Or hover <img width="419" alt="Screenshot 2025-03-18 at 7 43 04 PM" src="https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 9073b19)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 21, 2025
…215056) (#215491) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Restructure validation code, remove command settings (#215056)](#215056) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-03-20T13:16:34Z","message":"[ES|QL] Restructure validation code, remove command settings (#215056)\n\n## Summary\n\nFollow on to several recent efforts including\nhttps://github.com//issues/195418 and\nhttps://github.com//pull/213325\n\nThis PR\n- reorganizes validation code to make dependencies clearer and make it\nless overwhelming... it's not perfect but it's better\n- removes the deprecated notion of a command \"setting\" which only ever\napplied to `ENRICH`.\n\nNo regression in `ENRICH` mode validation:\n<img width=\"874\" alt=\"Screenshot 2025-03-18 at 1 04 46 PM\"\nsrc=\"https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c\"\n/>\n\nOr hover\n<img width=\"419\" alt=\"Screenshot 2025-03-18 at 7 43 04 PM\"\nsrc=\"https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b\"\n/>\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"9073b194072cee0ef5290982c05cfdb84662c673","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["technical debt","release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Restructure validation code, remove command settings","number":215056,"url":"https://github.com/elastic/kibana/pull/215056","mergeCommit":{"message":"[ES|QL] Restructure validation code, remove command settings (#215056)\n\n## Summary\n\nFollow on to several recent efforts including\nhttps://github.com//issues/195418 and\nhttps://github.com//pull/213325\n\nThis PR\n- reorganizes validation code to make dependencies clearer and make it\nless overwhelming... it's not perfect but it's better\n- removes the deprecated notion of a command \"setting\" which only ever\napplied to `ENRICH`.\n\nNo regression in `ENRICH` mode validation:\n<img width=\"874\" alt=\"Screenshot 2025-03-18 at 1 04 46 PM\"\nsrc=\"https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c\"\n/>\n\nOr hover\n<img width=\"419\" alt=\"Screenshot 2025-03-18 at 7 43 04 PM\"\nsrc=\"https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b\"\n/>\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"9073b194072cee0ef5290982c05cfdb84662c673"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215056","number":215056,"mergeCommit":{"message":"[ES|QL] Restructure validation code, remove command settings (#215056)\n\n## Summary\n\nFollow on to several recent efforts including\nhttps://github.com//issues/195418 and\nhttps://github.com//pull/213325\n\nThis PR\n- reorganizes validation code to make dependencies clearer and make it\nless overwhelming... it's not perfect but it's better\n- removes the deprecated notion of a command \"setting\" which only ever\napplied to `ENRICH`.\n\nNo regression in `ENRICH` mode validation:\n<img width=\"874\" alt=\"Screenshot 2025-03-18 at 1 04 46 PM\"\nsrc=\"https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c\"\n/>\n\nOr hover\n<img width=\"419\" alt=\"Screenshot 2025-03-18 at 7 43 04 PM\"\nsrc=\"https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b\"\n/>\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"9073b194072cee0ef5290982c05cfdb84662c673"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Mar 24, 2025
…#215056) ## Summary Follow on to several recent efforts including elastic#195418 and elastic#213325 This PR - reorganizes validation code to make dependencies clearer and make it less overwhelming... it's not perfect but it's better - removes the deprecated notion of a command "setting" which only ever applied to `ENRICH`. No regression in `ENRICH` mode validation: <img width="874" alt="Screenshot 2025-03-18 at 1 04 46 PM" src="https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c" /> Or hover <img width="419" alt="Screenshot 2025-03-18 at 7 43 04 PM" src="https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…#215056) ## Summary Follow on to several recent efforts including elastic#195418 and elastic#213325 This PR - reorganizes validation code to make dependencies clearer and make it less overwhelming... it's not perfect but it's better - removes the deprecated notion of a command "setting" which only ever applied to `ENRICH`. No regression in `ENRICH` mode validation: <img width="874" alt="Screenshot 2025-03-18 at 1 04 46 PM" src="https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c" /> Or hover <img width="419" alt="Screenshot 2025-03-18 at 7 43 04 PM" src="https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow on to several recent efforts including #195418 and #213325
This PR
ENRICH.No regression in
ENRICHmode validation:Or hover
Checklist