Skip to content

[ES|QL] Hides the actions and the "View problem" from the editor#213325

Merged
stratoula merged 6 commits intoelastic:mainfrom
stratoula:hide-actions-esql-editor
Mar 11, 2025
Merged

[ES|QL] Hides the actions and the "View problem" from the editor#213325
stratoula merged 6 commits intoelastic:mainfrom
stratoula:hide-actions-esql-editor

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Mar 6, 2025 •
edited by kibanamachine
Loading

Summary

Hides the actions and the view problem from the hover. (I didnt remove the code, we might want to enable it again in the future but we need to fix the bug I mention below)

Now

image

Before

image
  1. Quick fixes has a lot of bugs such as:

meow

  1. View problem doesn't appear correctly and it just repeats the error that exists already in the hover

meow

  1. Quick fixes are fixing now typos such as
  • index patterns
  • policies
  • field names
  • metadata options
  • quotes

Our autocomplete is good enough to solve these so this is not so helpful.

This PR hides the actions as they don't work correctly. We should reconsider displaying them again but for more sophisticated fixes such as:

#177554 (not for enrich but for joins)

We should fix the bug first (quick fix is not clickable)

@stratoula stratoula changed the title [ES|QL] Hides the actions and the view problem from the editor [ES|QL] Hides the actions and the "View problem" from the editor Mar 6, 2025
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// labels Mar 7, 2025
@stratoula stratoula marked this pull request as ready for review March 7, 2025 07:05
@stratoula stratoula requested a review from a team as a code owner March 7, 2025 07:05
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 7, 2025

Pinging @elastic/kibana-esql (Team:ESQL)

drewdaemon
drewdaemon requested changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MORE RED MORE RED

Let's remove actions.ts!!!

@stratoula
Copy link
Contributor Author

stratoula commented Mar 10, 2025 •
edited
Loading

I was thinking to not remove all the code tbh 🤔 Just hide it for now. Mostly because it is used by the ai assistant

@stratoula stratoula requested a review from a team as a code owner March 10, 2025 08:12
@stratoula
Copy link
Contributor Author

stratoula commented Mar 10, 2025 •
edited
Loading

Do you know something, yes let's remove all the code, feels good and although there is a usage from ai assistant, it doesnt seem to be used anywhere.

@stratoula stratoula requested a review from a team as a code owner March 10, 2025 10:07
stratoula
stratoula commented Mar 10, 2025
View reviewed changes
.../plugins/observability_ai_assistant_app/server/functions/query/correct_query_with_actions.ts
* - Combination of the above
*/

export const correctQueryWithActions = async (queryString: string) => {
Copy link
Contributor Author

@stratoula stratoula Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems as this function is not used anywhere anymore

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 10, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
esql 208 206 -2
lists 439 437 -2
securitySolution 7061 7059 -2
unifiedSearch 368 366 -2
total -8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-validation-autocomplete 201 187 -14
@kbn/monaco 186 184 -2
total -16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 239.1KB 239.0KB -108.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/esql-validation-autocomplete 14 12 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.6MB 3.6MB -6.3KB
Unknown metric groups

API count

id before after diff
@kbn/esql-validation-autocomplete 213 199 -14
@kbn/monaco 186 184 -2
total -16

History

drewdaemon
drewdaemon approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This removal will allow us to remove the deprecated command definition modes property.

And the code will still be there in the .git directory... until the end of ⏱️

@stratoula stratoula merged commit b9472b6 into elastic:main Mar 11, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 11, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13783734731

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 11, 2025

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 213325

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit to stratoula/kibana that referenced this pull request Mar 11, 2025
@stratoula
[ES|QL] Hides the actions and the "View problem" from the editor (ela…
1b912b6 
…stic#213325)

## Summary

Hides the actions and the view problem from the hover. (I didnt remove
the code, we might want to enable it again in the future but we need to
fix the bug I mention below)

**Now**

<img width="719" alt="image"
src="https://github.com/user-attachments/assets/423cfbdd-e067-409c-8eb4-1e2c2cc17649"
/>

**Before**

<img width="617" alt="image"
src="https://github.com/user-attachments/assets/7ec5f48d-af8b-4676-84f4-9fa4a0d8f220"
/>

1. Quick fixes has a lot of bugs such as:
- elastic#180491
- It is not easy to select it

![meow](https://github.com/user-attachments/assets/59856c5f-08cd-4205-96f3-b2a8a1da7c60)

2. View problem doesn't appear correctly and it just repeats the error
that exists already in the hover

![meow](https://github.com/user-attachments/assets/a3ab0c95-5997-4104-816a-97c249acafb6)

3. Quick fixes are fixing now typos such as
- index patterns
- policies
- field names
- metadata options
- quotes

Our autocomplete is good enough to solve these so this is not so
helpful.

This PR hides the actions as they don't work correctly. We should
reconsider displaying them again but for more sophisticated fixes such
as:

elastic#177554 (not for enrich but for
joins)

We should fix the bug first (quick fix is not clickable)

(cherry picked from commit b9472b6)

# Conflicts:
#	src/platform/packages/shared/kbn-monaco/src/esql/lib/converters/actions.ts
#	src/platform/packages/shared/kbn-monaco/src/esql/lib/esql_ast_provider.ts
@stratoula stratoula mentioned this pull request Mar 11, 2025
Merged
@stratoula
Copy link
Contributor Author

stratoula commented Mar 11, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit that referenced this pull request Mar 11, 2025
@stratoula @kibanamachine
[8.x] [ES|QL] Hides the actions and the "View problem" from the editor (
e6e551f 
#213325) (#213875)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Hides the actions and the "View problem" from the editor
(#213325)](#213325)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-11T08:40:26Z","message":"[ES|QL]
Hides the actions and the \"View problem\" from the editor
(#213325)\n\n## Summary\n\nHides the actions and the view problem from
the hover. (I didnt remove\nthe code, we might want to enable it again
in the future but we need to\nfix the bug I mention
below)\n\n**Now**\n\n<img width=\"719\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/423cfbdd-e067-409c-8eb4-1e2c2cc17649\"\n/>\n\n\n**Before**\n\n<img
width=\"617\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7ec5f48d-af8b-4676-84f4-9fa4a0d8f220\"\n/>\n\n1.
Quick fixes has a lot of bugs such as:\n-
https://github.com/elastic/kibana/issues/180491\n- It is not easy to
select it
\n\n\n![meow](https://github.com/user-attachments/assets/59856c5f-08cd-4205-96f3-b2a8a1da7c60)\n\n2.
View problem doesn't appear correctly and it just repeats the
error\nthat exists already in the
hover\n\n\n![meow](https://github.com/user-attachments/assets/a3ab0c95-5997-4104-816a-97c249acafb6)\n\n3.
Quick fixes are fixing now typos such as\n- index patterns\n-
policies\n- field names\n- metadata options\n- quotes \n\nOur
autocomplete is good enough to solve these so this is not
so\nhelpful.\n\n\nThis PR hides the actions as they don't work
correctly. We should\nreconsider displaying them again but for more
sophisticated fixes
such\nas:\n\nhttps://github.com//issues/177554 (not for
enrich but for\njoins)\n\nWe should fix the bug first (quick fix is not
clickable)","sha":"b9472b6ade4459f7dd3d15cccb5e2048fd377613","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Hides the actions and the \"View problem\" from the
editor","number":213325,"url":"https://github.com/elastic/kibana/pull/213325","mergeCommit":{"message":"[ES|QL]
Hides the actions and the \"View problem\" from the editor
(#213325)\n\n## Summary\n\nHides the actions and the view problem from
the hover. (I didnt remove\nthe code, we might want to enable it again
in the future but we need to\nfix the bug I mention
below)\n\n**Now**\n\n<img width=\"719\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/423cfbdd-e067-409c-8eb4-1e2c2cc17649\"\n/>\n\n\n**Before**\n\n<img
width=\"617\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7ec5f48d-af8b-4676-84f4-9fa4a0d8f220\"\n/>\n\n1.
Quick fixes has a lot of bugs such as:\n-
https://github.com/elastic/kibana/issues/180491\n- It is not easy to
select it
\n\n\n![meow](https://github.com/user-attachments/assets/59856c5f-08cd-4205-96f3-b2a8a1da7c60)\n\n2.
View problem doesn't appear correctly and it just repeats the
error\nthat exists already in the
hover\n\n\n![meow](https://github.com/user-attachments/assets/a3ab0c95-5997-4104-816a-97c249acafb6)\n\n3.
Quick fixes are fixing now typos such as\n- index patterns\n-
policies\n- field names\n- metadata options\n- quotes \n\nOur
autocomplete is good enough to solve these so this is not
so\nhelpful.\n\n\nThis PR hides the actions as they don't work
correctly. We should\nreconsider displaying them again but for more
sophisticated fixes
such\nas:\n\nhttps://github.com//issues/177554 (not for
enrich but for\njoins)\n\nWe should fix the bug first (quick fix is not
clickable)","sha":"b9472b6ade4459f7dd3d15cccb5e2048fd377613"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213325","number":213325,"mergeCommit":{"message":"[ES|QL]
Hides the actions and the \"View problem\" from the editor
(#213325)\n\n## Summary\n\nHides the actions and the view problem from
the hover. (I didnt remove\nthe code, we might want to enable it again
in the future but we need to\nfix the bug I mention
below)\n\n**Now**\n\n<img width=\"719\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/423cfbdd-e067-409c-8eb4-1e2c2cc17649\"\n/>\n\n\n**Before**\n\n<img
width=\"617\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7ec5f48d-af8b-4676-84f4-9fa4a0d8f220\"\n/>\n\n1.
Quick fixes has a lot of bugs such as:\n-
https://github.com/elastic/kibana/issues/180491\n- It is not easy to
select it
\n\n\n![meow](https://github.com/user-attachments/assets/59856c5f-08cd-4205-96f3-b2a8a1da7c60)\n\n2.
View problem doesn't appear correctly and it just repeats the
error\nthat exists already in the
hover\n\n\n![meow](https://github.com/user-attachments/assets/a3ab0c95-5997-4104-816a-97c249acafb6)\n\n3.
Quick fixes are fixing now typos such as\n- index patterns\n-
policies\n- field names\n- metadata options\n- quotes \n\nOur
autocomplete is good enough to solve these so this is not
so\nhelpful.\n\n\nThis PR hides the actions as they don't work
correctly. We should\nreconsider displaying them again but for more
sophisticated fixes
such\nas:\n\nhttps://github.com//issues/177554 (not for
enrich but for\njoins)\n\nWe should fix the bug first (quick fix is not
clickable)","sha":"b9472b6ade4459f7dd3d15cccb5e2048fd377613"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@drewdaemon drewdaemon mentioned this pull request Mar 18, 2025
Merged
1 task
drewdaemon added a commit that referenced this pull request Mar 20, 2025
@drewdaemon @elasticmachine
[ES|QL] Restructure validation code, remove command settings (#215056)
9073b19 
## Summary

Follow on to several recent efforts including
#195418 and
#213325

This PR
- reorganizes validation code to make dependencies clearer and make it
less overwhelming... it's not perfect but it's better
- removes the deprecated notion of a command "setting" which only ever
applied to `ENRICH`.

No regression in `ENRICH` mode validation:
<img width="874" alt="Screenshot 2025-03-18 at 1 04 46 PM"
src="https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c"
/>

Or hover
<img width="419" alt="Screenshot 2025-03-18 at 7 43 04 PM"
src="https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b"
/>





### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this pull request Mar 20, 2025
@drewdaemon @elasticmachine @clintandrewhall
[ES|QL] Restructure validation code, remove command settings (elastic…
12ea80f 
…#215056)

## Summary

Follow on to several recent efforts including
elastic#195418 and
elastic#213325

This PR
- reorganizes validation code to make dependencies clearer and make it
less overwhelming... it's not perfect but it's better
- removes the deprecated notion of a command "setting" which only ever
applied to `ENRICH`.

No regression in `ENRICH` mode validation:
<img width="874" alt="Screenshot 2025-03-18 at 1 04 46 PM"
src="https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c"
/>

Or hover
<img width="419" alt="Screenshot 2025-03-18 at 7 43 04 PM"
src="https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b"
/>





### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 21, 2025
@drewdaemon @elasticmachine
[ES|QL] Restructure validation code, remove command settings (elastic…
c15a4d0 
…#215056)

## Summary

Follow on to several recent efforts including
elastic#195418 and
elastic#213325

This PR
- reorganizes validation code to make dependencies clearer and make it
less overwhelming... it's not perfect but it's better
- removes the deprecated notion of a command "setting" which only ever
applied to `ENRICH`.

No regression in `ENRICH` mode validation:
<img width="874" alt="Screenshot 2025-03-18 at 1 04 46 PM"
src="https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c"
/>

Or hover
<img width="419" alt="Screenshot 2025-03-18 at 7 43 04 PM"
src="https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b"
/>

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 9073b19)
kibanamachine added a commit that referenced this pull request Mar 21, 2025
@kibanamachine @drewdaemon
[8.x] [ES|QL] Restructure validation code, remove command settings (#…
7b1eefd 
…215056) (#215491)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Restructure validation code, remove command settings
(#215056)](#215056)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Drew
Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-03-20T13:16:34Z","message":"[ES|QL]
Restructure validation code, remove command settings (#215056)\n\n##
Summary\n\nFollow on to several recent efforts
including\nhttps://github.com//issues/195418
and\nhttps://github.com//pull/213325\n\nThis PR\n-
reorganizes validation code to make dependencies clearer and make
it\nless overwhelming... it's not perfect but it's better\n- removes the
deprecated notion of a command \"setting\" which only ever\napplied to
`ENRICH`.\n\nNo regression in `ENRICH` mode validation:\n<img
width=\"874\" alt=\"Screenshot 2025-03-18 at 1 04
46 PM\"\nsrc=\"https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c\"\n/>\n\nOr
hover\n<img width=\"419\" alt=\"Screenshot 2025-03-18 at 7 43
04 PM\"\nsrc=\"https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b\"\n/>\n\n\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"9073b194072cee0ef5290982c05cfdb84662c673","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["technical
debt","release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Restructure validation code, remove command
settings","number":215056,"url":"https://github.com/elastic/kibana/pull/215056","mergeCommit":{"message":"[ES|QL]
Restructure validation code, remove command settings (#215056)\n\n##
Summary\n\nFollow on to several recent efforts
including\nhttps://github.com//issues/195418
and\nhttps://github.com//pull/213325\n\nThis PR\n-
reorganizes validation code to make dependencies clearer and make
it\nless overwhelming... it's not perfect but it's better\n- removes the
deprecated notion of a command \"setting\" which only ever\napplied to
`ENRICH`.\n\nNo regression in `ENRICH` mode validation:\n<img
width=\"874\" alt=\"Screenshot 2025-03-18 at 1 04
46 PM\"\nsrc=\"https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c\"\n/>\n\nOr
hover\n<img width=\"419\" alt=\"Screenshot 2025-03-18 at 7 43
04 PM\"\nsrc=\"https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b\"\n/>\n\n\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"9073b194072cee0ef5290982c05cfdb84662c673"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215056","number":215056,"mergeCommit":{"message":"[ES|QL]
Restructure validation code, remove command settings (#215056)\n\n##
Summary\n\nFollow on to several recent efforts
including\nhttps://github.com//issues/195418
and\nhttps://github.com//pull/213325\n\nThis PR\n-
reorganizes validation code to make dependencies clearer and make
it\nless overwhelming... it's not perfect but it's better\n- removes the
deprecated notion of a command \"setting\" which only ever\napplied to
`ENRICH`.\n\nNo regression in `ENRICH` mode validation:\n<img
width=\"874\" alt=\"Screenshot 2025-03-18 at 1 04
46 PM\"\nsrc=\"https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c\"\n/>\n\nOr
hover\n<img width=\"419\" alt=\"Screenshot 2025-03-18 at 7 43
04 PM\"\nsrc=\"https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b\"\n/>\n\n\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"9073b194072cee0ef5290982c05cfdb84662c673"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Drew Tate <drew.tate@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
@stratoula @CAWilson94
[ES|QL] Hides the actions and the "View problem" from the editor (ela…
1ec0eaa 
…stic#213325)

## Summary

Hides the actions and the view problem from the hover. (I didnt remove
the code, we might want to enable it again in the future but we need to
fix the bug I mention below)

**Now**

<img width="719" alt="image"
src="https://github.com/user-attachments/assets/423cfbdd-e067-409c-8eb4-1e2c2cc17649"
/>


**Before**

<img width="617" alt="image"
src="https://github.com/user-attachments/assets/7ec5f48d-af8b-4676-84f4-9fa4a0d8f220"
/>

1. Quick fixes has a lot of bugs such as:
- elastic#180491
- It is not easy to select it 


![meow](https://github.com/user-attachments/assets/59856c5f-08cd-4205-96f3-b2a8a1da7c60)

2. View problem doesn't appear correctly and it just repeats the error
that exists already in the hover


![meow](https://github.com/user-attachments/assets/a3ab0c95-5997-4104-816a-97c249acafb6)

3. Quick fixes are fixing now typos such as
- index patterns
- policies
- field names
- metadata options
- quotes 

Our autocomplete is good enough to solve these so this is not so
helpful.


This PR hides the actions as they don't work correctly. We should
reconsider displaying them again but for more sophisticated fixes such
as:

elastic#177554 (not for enrich but for
joins)

We should fix the bug first (quick fix is not clickable)
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Mar 24, 2025
@drewdaemon @elasticmachine @JoseLuisGJ
[ES|QL] Restructure validation code, remove command settings (elastic…
464c1eb 
…#215056)

## Summary

Follow on to several recent efforts including
elastic#195418 and
elastic#213325

This PR
- reorganizes validation code to make dependencies clearer and make it
less overwhelming... it's not perfect but it's better
- removes the deprecated notion of a command "setting" which only ever
applied to `ENRICH`.

No regression in `ENRICH` mode validation:
<img width="874" alt="Screenshot 2025-03-18 at 1 04 46 PM"
src="https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c"
/>

Or hover
<img width="419" alt="Screenshot 2025-03-18 at 7 43 04 PM"
src="https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b"
/>





### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
@drewdaemon @elasticmachine @cqliu1
[ES|QL] Restructure validation code, remove command settings (elastic…
54fa80c 
…#215056)

## Summary

Follow on to several recent efforts including
elastic#195418 and
elastic#213325

This PR
- reorganizes validation code to make dependencies clearer and make it
less overwhelming... it's not perfect but it's better
- removes the deprecated notion of a command "setting" which only ever
applied to `ENRICH`.

No regression in `ENRICH` mode validation:
<img width="874" alt="Screenshot 2025-03-18 at 1 04 46 PM"
src="https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c"
/>

Or hover
<img width="419" alt="Screenshot 2025-03-18 at 7 43 04 PM"
src="https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b"
/>





### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

@eokoneyo eokoneyo eokoneyo approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stratoula @elasticmachine @kibanamachine @sorenlouv @drewdaemon @eokoneyo