Skip to content

[Graph/SCSS] Migrate source_modal.scss file to css in js#215168

Merged
mariairiartef merged 4 commits intoelastic:mainfrom
mariairiartef:lens/scss-js/graph-5
Mar 20, 2025
Merged

[Graph/SCSS] Migrate source_modal.scss file to css in js#215168
mariairiartef merged 4 commits intoelastic:mainfrom
mariairiartef:lens/scss-js/graph-5

Conversation

@mariairiartef
Copy link
Contributor

@mariairiartef mariairiartef commented Mar 19, 2025

Summary

Part of #208908

Replaces source_modal.scss files file to css-in-js.

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@mariairiartef mariairiartef added Feature:Graph Graph application feature technical debt Improvement of the software architecture and operational architecture Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Mar 19, 2025
@mariairiartef mariairiartef self-assigned this Mar 19, 2025
@mariairiartef mariairiartef requested review from a team as code owners March 19, 2025 13:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-graph (Feature:Graph)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mariairiartef mariairiartef enabled auto-merge (squash) March 20, 2025 13:04
@mariairiartef mariairiartef merged commit 971c205 into elastic:main Mar 20, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 389.5KB 389.4KB -48.0B

History

cc @mariairiartef

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13973248534

clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this pull request Mar 20, 2025
…15168)

## Summary

Part of elastic#208908

Replaces `source_modal.scss` files file to css-in-js.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Mar 24, 2025
…15168)

## Summary

Part of elastic#208908

Replaces `source_modal.scss` files file to css-in-js.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 24, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 215168 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 215168 locally

nickofthyme pushed a commit to nickofthyme/kibana that referenced this pull request Mar 26, 2025
…15168)

## Summary

Part of elastic#208908

Replaces `source_modal.scss` files file to css-in-js.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 971c205)

# Conflicts:
#	x-pack/platform/plugins/private/graph/public/components/_index.scss
@nickofthyme
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

markov00 pushed a commit that referenced this pull request Mar 26, 2025
…5168) (#215978)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Graph/SCSS] Migrate `source_modal.scss` file to css in js
(#215168)](#215168)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maria
Iriarte","email":"106958839+mariairiartef@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-20T15:33:46Z","message":"[Graph/SCSS]
Migrate `source_modal.scss` file to css in js (#215168)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/208908\n\nReplaces
`source_modal.scss` files file to css-in-js.\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"971c2056ad771cc9cebaf1557ba39f60f1d93ec9","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Graph","technical
debt","Team:Visualizations","release_note:skip","backport
missing","v9.0.0","backport:version","v9.1.0","v8.19.0"],"title":"[Graph/SCSS]
Migrate `source_modal.scss` file to css in
js","number":215168,"url":"https://github.com/elastic/kibana/pull/215168","mergeCommit":{"message":"[Graph/SCSS]
Migrate `source_modal.scss` file to css in js (#215168)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/208908\n\nReplaces
`source_modal.scss` files file to css-in-js.\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"971c2056ad771cc9cebaf1557ba39f60f1d93ec9"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215168","number":215168,"mergeCommit":{"message":"[Graph/SCSS]
Migrate `source_modal.scss` file to css in js (#215168)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/208908\n\nReplaces
`source_modal.scss` files file to css-in-js.\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"971c2056ad771cc9cebaf1557ba39f60f1d93ec9"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 26, 2025
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
…15168)

## Summary

Part of elastic#208908

Replaces `source_modal.scss` files file to css-in-js.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes scss-removal Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// technical debt Improvement of the software architecture and operational architecture v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants