Skip to content

[ES|QL] Merges the controls props#214699

Merged
stratoula merged 3 commits intoelastic:mainfrom
stratoula:merge-editor-controls-props
Mar 20, 2025
Merged

[ES|QL] Merges the controls props#214699
stratoula merged 3 commits intoelastic:mainfrom
stratoula:merge-editor-controls-props

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Mar 17, 2025 •
edited by kibanamachine
Loading

Summary

Small change to the editor api. Groups the controls related props together

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 17, 2025

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-editor 15 13 -2
esql 29 27 -2
total -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 239.3KB 239.5KB +225.0B
lens 1.5MB 1.5MB +18.0B
total +243.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/esql-editor 0 1 +1
Unknown metric groups

API count

id before after diff
@kbn/esql-editor 38 34 -4
esql 51 47 -4
total -8

@stratoula stratoula added v9.1.0 v8.19.0 release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// labels Mar 17, 2025
@stratoula stratoula marked this pull request as ready for review March 17, 2025 11:01
@stratoula stratoula requested review from a team as code owners March 17, 2025 11:01
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 17, 2025

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula merged commit 92a2efa into elastic:main Mar 20, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 20, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13973235294

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 20, 2025

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [APM] remove unnecessary field service.environment from top dependency spans endpoint (#215321)
- Fix warning in @kbn/grouping's GroupSelector component (#215225)
- [Detection Engine] Rule Data View select uses Data View name for display (#214495)
- [ML] Anomaly Explorer: Migrate Explorer from SCSS to Emotion (#215196)
- [SecuritySolution] Fix Data view refresh does not support the indexPattern parameter (#215151)
- [ES|QL] Restructure validation code, remove command settings (#215056)
- [Streams 🌊] Enrichment - Add support for date processor (#213559)
- [Performance] Refactor TTFMP query from, to fields (#213911)
- [Graph/SCSS] Migrate settings _index.css, _legacy_icon.scss and _url_template_list.scss files to Emotion (#215021)
- [Lens/SCSS] Replace scss to css-in-js for Lens codebase (#209768)

Manual backport

To create the backport manually run:

node scripts/backport --pr 214699

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Mar 20, 2025
Merged
1 task
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this pull request Mar 20, 2025
@stratoula @clintandrewhall
[ES|QL] Merges the controls props (elastic#214699)
492d4b9 
## Summary

Small change to the editor api. Groups the controls related props
together
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Mar 24, 2025
@stratoula @JoseLuisGJ
[ES|QL] Merges the controls props (elastic#214699)
d30e2c9 
## Summary

Small change to the editor api. Groups the controls related props
together
stratoula added a commit to stratoula/kibana that referenced this pull request Mar 24, 2025
@stratoula
[ES|QL] Merges the controls props (elastic#214699)
9383bf9 
## Summary

Small change to the editor api. Groups the controls related props
together

(cherry picked from commit 92a2efa)
@stratoula stratoula mentioned this pull request Mar 24, 2025
Merged
@stratoula
Copy link
Contributor Author

stratoula commented Mar 24, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 24, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 24, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

stratoula added a commit that referenced this pull request Mar 24, 2025
@stratoula
[8.x] [ES|QL] Merges the controls props (#214699) (#215734)
060a29f 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Merges the controls props
(#214699)](#214699)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-20T15:33:11Z","message":"[ES|QL]
Merges the controls props (#214699)\n\n## Summary\n\nSmall change to the
editor api. Groups the controls related
props\ntogether","sha":"92a2efacd26c9093561e9048d634ec65a6e549f7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Merges the controls
props","number":214699,"url":"https://github.com/elastic/kibana/pull/214699","mergeCommit":{"message":"[ES|QL]
Merges the controls props (#214699)\n\n## Summary\n\nSmall change to the
editor api. Groups the controls related
props\ntogether","sha":"92a2efacd26c9093561e9048d634ec65a6e549f7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214699","number":214699,"mergeCommit":{"message":"[ES|QL]
Merges the controls props (#214699)\n\n## Summary\n\nSmall change to the
editor api. Groups the controls related
props\ntogether","sha":"92a2efacd26c9093561e9048d634ec65a6e549f7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 24, 2025
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
@stratoula @cqliu1
[ES|QL] Merges the controls props (elastic#214699)
94e50c4 
## Summary

Small change to the editor api. Groups the controls related props
together
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

@markov00 markov00 markov00 approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stratoula @elasticmachine @kibanamachine @drewdaemon @markov00