[8.x] [ES|QL] Restructure validation code, remove command settings (#215056)#215491
Merged
kibanamachine merged 1 commit intoelastic:8.xfrom Mar 21, 2025
Merged
Conversation
…#215056) ## Summary Follow on to several recent efforts including elastic#195418 and elastic#213325 This PR - reorganizes validation code to make dependencies clearer and make it less overwhelming... it's not perfect but it's better - removes the deprecated notion of a command "setting" which only ever applied to `ENRICH`. No regression in `ENRICH` mode validation: <img width="874" alt="Screenshot 2025-03-18 at 1 04 46 PM" src="https://github.com/user-attachments/assets/e6639d8a-d129-440f-ac30-64a2ef6ab65c" /> Or hover <img width="419" alt="Screenshot 2025-03-18 at 7 43 04 PM" src="https://github.com/user-attachments/assets/8f9c020c-dcfd-42dc-8e14-4b1c4311457b" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 9073b19)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
cc @drewdaemon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation