Skip to content

[Graph/SCSS] Migrate settings _index.css, _legacy_icon.scss and _url_template_list.scss files to Emotion#215021

Merged
mariairiartef merged 9 commits intoelastic:mainfrom
mariairiartef:lens/scss-js/graph-4
Mar 20, 2025
Merged

[Graph/SCSS] Migrate settings _index.css, _legacy_icon.scss and _url_template_list.scss files to Emotion#215021
mariairiartef merged 9 commits intoelastic:mainfrom
mariairiartef:lens/scss-js/graph-4

Conversation

@mariairiartef
Copy link
Copy Markdown
Contributor

@mariairiartef mariairiartef commented Mar 18, 2025 •
edited by kibanamachine
Loading

Summary

Part of #208908

Replaces _index.css, _legacy_icon.scss and _url_template_list.scss files file to css-in-js.

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@mariairiartef mariairiartef self-assigned this Mar 18, 2025
@mariairiartef mariairiartef added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels technical debt Improvement of the software architecture and operational architecture labels Mar 18, 2025
@mariairiartef mariairiartef marked this pull request as ready for review March 18, 2025 16:35
@mariairiartef mariairiartef requested review from a team as code owners March 18, 2025 16:35
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 18, 2025

Pinging @elastic/kibana-graph (Feature:Graph)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 18, 2025

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mariairiartef mariairiartef changed the title [Graph/SCSS] Migrate settings _index.css, _legacy_icon.scss and _legacy_icon.scss files to Emotion [Graph/SCSS] Migrate settings _index.css, _legacy_icon.scss and _url_template_list.scss files to Emotion Mar 18, 2025
@mariairiartef mariairiartef mentioned this pull request Mar 19, 2025
Closed
74 tasks
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 19, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #119 / upgrade assistant Kibana API Deprecations keeps track of all counters via saved objects and core usage counters
  • [job] [logs] FTR Configs #119 / upgrade assistant Kibana API Deprecations keeps track of all counters via saved objects and core usage counters

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
graph 274 275 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 390.0KB 389.5KB -505.0B

History

cc @mariairiartef

@mariairiartef mariairiartef enabled auto-merge (squash) March 20, 2025 08:55
@mariairiartef mariairiartef merged commit 48b286e into elastic:main Mar 20, 2025
9 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 20, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13967156158

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 20, 2025

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Graph/SCSS] Refactor styles to use Emotion (#212916)

Manual backport

To create the backport manually run:

node scripts/backport --pr 215021

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Mar 20, 2025
Merged
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this pull request Mar 20, 2025
@mariairiartef @clintandrewhall
[Graph/SCSS] Migrate settings _index.css, _legacy_icon.scss and `…
fe27afa 
…_url_template_list.scss` files to Emotion (elastic#215021)

## Summary

Part of elastic#208908

Replaces `_index.css`, `_legacy_icon.scss` and `_url_template_list.scss`
files file to css-in-js.


### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 24, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 24, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 215021 locally

JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Mar 24, 2025
@mariairiartef @JoseLuisGJ
[Graph/SCSS] Migrate settings _index.css, _legacy_icon.scss and `…
3421883 
…_url_template_list.scss` files to Emotion (elastic#215021)

## Summary

Part of elastic#208908

Replaces `_index.css`, `_legacy_icon.scss` and `_url_template_list.scss`
files file to css-in-js.


### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 25, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 215021 locally

nickofthyme pushed a commit to nickofthyme/kibana that referenced this pull request Mar 26, 2025
@mariairiartef
[Graph/SCSS] Migrate settings _index.css, _legacy_icon.scss and `…
9f1da87 
…_url_template_list.scss` files to Emotion (elastic#215021)

## Summary

Part of elastic#208908

Replaces `_index.css`, `_legacy_icon.scss` and `_url_template_list.scss`
files file to css-in-js.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 48b286e)

# Conflicts:
#	x-pack/platform/plugins/private/graph/public/components/_index.scss
@nickofthyme nickofthyme mentioned this pull request Mar 26, 2025
Merged
@nickofthyme
Copy link
Copy Markdown
Contributor

nickofthyme commented Mar 26, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

nickofthyme added a commit that referenced this pull request Mar 26, 2025
@nickofthyme @mariairiartef @markov00
[8.x] [Graph/SCSS] Migrate settings _index.css, _legacy_icon.scss…
d6c681f 
… and `_url_template_list.scss` files to Emotion (#215021) (#215977)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Graph/SCSS] Migrate settings `_index.css`, `_legacy_icon.scss` and
`_url_template_list.scss` files to Emotion
(#215021)](#215021)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maria
Iriarte","email":"106958839+mariairiartef@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-20T10:29:06Z","message":"[Graph/SCSS]
Migrate settings `_index.css`, `_legacy_icon.scss` and
`_url_template_list.scss` files to Emotion (#215021)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/208908\n\nReplaces
`_index.css`, `_legacy_icon.scss` and `_url_template_list.scss`\nfiles
file to css-in-js.\n\n\n### Checklist\n\n- [x] The PR description
includes the appropriate Release Notes section,\nand the correct
`release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"48b286e46062395795347e93648b79fd1c68997b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Graph","technical
debt","Team:Visualizations","release_note:skip","backport
missing","backport:version","v9.1.0","v8.19.0"],"title":"[Graph/SCSS]
Migrate settings `_index.css`, `_legacy_icon.scss` and
`_url_template_list.scss` files to
Emotion","number":215021,"url":"https://github.com/elastic/kibana/pull/215021","mergeCommit":{"message":"[Graph/SCSS]
Migrate settings `_index.css`, `_legacy_icon.scss` and
`_url_template_list.scss` files to Emotion (#215021)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/208908\n\nReplaces
`_index.css`, `_legacy_icon.scss` and `_url_template_list.scss`\nfiles
file to css-in-js.\n\n\n### Checklist\n\n- [x] The PR description
includes the appropriate Release Notes section,\nand the correct
`release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"48b286e46062395795347e93648b79fd1c68997b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215021","number":215021,"mergeCommit":{"message":"[Graph/SCSS]
Migrate settings `_index.css`, `_legacy_icon.scss` and
`_url_template_list.scss` files to Emotion (#215021)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/208908\n\nReplaces
`_index.css`, `_legacy_icon.scss` and `_url_template_list.scss`\nfiles
file to css-in-js.\n\n\n### Checklist\n\n- [x] The PR description
includes the appropriate Release Notes section,\nand the correct
`release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"48b286e46062395795347e93648b79fd1c68997b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>
Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 26, 2025
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
@mariairiartef @cqliu1
[Graph/SCSS] Migrate settings _index.css, _legacy_icon.scss and `…
276de02 
…_url_template_list.scss` files to Emotion (elastic#215021)

## Summary

Part of elastic#208908

Replaces `_index.css`, `_legacy_icon.scss` and `_url_template_list.scss`
files file to css-in-js.


### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees

@mariairiartef mariairiartef

Labels

backport:version Backport to applied version labels Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes scss-removal Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// technical debt Improvement of the software architecture and operational architecture v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mariairiartef @elasticmachine @kibanamachine @nickofthyme @ryankeairns @tsullivan