[APM] remove unnecessary field service.environment from top dependency spans endpoint#215321
Merged
rmyz merged 1 commit intoelastic:mainfrom Mar 20, 2025
Conversation
…dency spans endpoint
rmyz
added
release_note:fix
v9.0.0
apm
Team:obs-ux-infra_services - DEPRECATED
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
💚 Build Succeeded
Metrics [docs]
cc @rmyz |
rmyz
deleted the
215106-apm-fix-top-dependencies-span-no-service_environment
branch
Contributor
|
Starting backport for target branches: 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13973201246 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 20, 2025
…y spans endpoint (elastic#215321) ## Summary Fixes elastic#215106 This PR removes `service.environment` as a required field for `getTopDependencySpans` endpoint. It was not used at all, so it can be safely removed without adapting the UI. (cherry picked from commit 8193e56)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 20, 2025
…y spans endpoint (elastic#215321) ## Summary Fixes elastic#215106 This PR removes `service.environment` as a required field for `getTopDependencySpans` endpoint. It was not used at all, so it can be safely removed without adapting the UI. (cherry picked from commit 8193e56)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Mar 20, 2025
kibanamachine
added a commit
that referenced
this pull request
Mar 20, 2025
…endency spans endpoint (#215321) (#215361) # Backport This will backport the following commits from `main` to `9.0`: - [[APM] remove unnecessary field service.environment from top dependency spans endpoint (#215321)](#215321) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-03-20T15:31:36Z","message":"[APM] remove unnecessary field service.environment from top dependency spans endpoint (#215321)\n\n## Summary\n\nFixes #215106\n\nThis PR removes `service.environment` as a required field for\n`getTopDependencySpans` endpoint.\nIt was not used at all, so it can be safely removed without adapting the\nUI.","sha":"8193e56970757edc96fef17b18c6accbc1fad0dd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","apm","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"[APM] remove unnecessary field service.environment from top dependency spans endpoint","number":215321,"url":"https://github.com/elastic/kibana/pull/215321","mergeCommit":{"message":"[APM] remove unnecessary field service.environment from top dependency spans endpoint (#215321)\n\n## Summary\n\nFixes #215106\n\nThis PR removes `service.environment` as a required field for\n`getTopDependencySpans` endpoint.\nIt was not used at all, so it can be safely removed without adapting the\nUI.","sha":"8193e56970757edc96fef17b18c6accbc1fad0dd"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215321","number":215321,"mergeCommit":{"message":"[APM] remove unnecessary field service.environment from top dependency spans endpoint (#215321)\n\n## Summary\n\nFixes #215106\n\nThis PR removes `service.environment` as a required field for\n`getTopDependencySpans` endpoint.\nIt was not used at all, so it can be safely removed without adapting the\nUI.","sha":"8193e56970757edc96fef17b18c6accbc1fad0dd"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Mar 20, 2025
…y spans endpoint (elastic#215321) ## Summary Fixes elastic#215106 This PR removes `service.environment` as a required field for `getTopDependencySpans` endpoint. It was not used at all, so it can be safely removed without adapting the UI.
kibanamachine
added a commit
that referenced
this pull request
Mar 21, 2025
…endency spans endpoint (#215321) (#215360) # Backport This will backport the following commits from `main` to `8.x`: - [[APM] remove unnecessary field service.environment from top dependency spans endpoint (#215321)](#215321) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-03-20T15:31:36Z","message":"[APM] remove unnecessary field service.environment from top dependency spans endpoint (#215321)\n\n## Summary\n\nFixes #215106\n\nThis PR removes `service.environment` as a required field for\n`getTopDependencySpans` endpoint.\nIt was not used at all, so it can be safely removed without adapting the\nUI.","sha":"8193e56970757edc96fef17b18c6accbc1fad0dd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","apm","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"[APM] remove unnecessary field service.environment from top dependency spans endpoint","number":215321,"url":"https://github.com/elastic/kibana/pull/215321","mergeCommit":{"message":"[APM] remove unnecessary field service.environment from top dependency spans endpoint (#215321)\n\n## Summary\n\nFixes #215106\n\nThis PR removes `service.environment` as a required field for\n`getTopDependencySpans` endpoint.\nIt was not used at all, so it can be safely removed without adapting the\nUI.","sha":"8193e56970757edc96fef17b18c6accbc1fad0dd"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215321","number":215321,"mergeCommit":{"message":"[APM] remove unnecessary field service.environment from top dependency spans endpoint (#215321)\n\n## Summary\n\nFixes #215106\n\nThis PR removes `service.environment` as a required field for\n`getTopDependencySpans` endpoint.\nIt was not used at all, so it can be safely removed without adapting the\nUI.","sha":"8193e56970757edc96fef17b18c6accbc1fad0dd"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Mar 24, 2025
…y spans endpoint (elastic#215321) ## Summary Fixes elastic#215106 This PR removes `service.environment` as a required field for `getTopDependencySpans` endpoint. It was not used at all, so it can be safely removed without adapting the UI.
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…y spans endpoint (elastic#215321) ## Summary Fixes elastic#215106 This PR removes `service.environment` as a required field for `getTopDependencySpans` endpoint. It was not used at all, so it can be safely removed without adapting the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #215106
This PR removes
service.environmentas a required field forgetTopDependencySpansendpoint.It was not used at all, so it can be safely removed without adapting the UI.