Skip to content

[ES|QL] Hides the actions and the "View problem" from the editor #213325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stratoula merged 6 commits into from
Mar 11, 2025
Merged

[ES|QL] Hides the actions and the "View problem" from the editor #213325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b9d3754
[ES|QL] Hides the actions and the view problem from the editor
stratoula Mar 6, 2025
7cbf959
Merge branch 'main' into hide-actions-esql-editor
stratoula Mar 6, 2025
dca27bb
Merge branch 'main' into hide-actions-esql-editor
stratoula Mar 10, 2025
ffcc679
REMOVE THEM ALL
stratoula Mar 10, 2025
3e8cb16
Cleanup translations
stratoula Mar 10, 2025
6ed2b0e
Remove it from ai assistant as it is not used anywhere
stratoula Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/platform/packages/private/kbn-esql-editor/src/esql_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,11 +618,6 @@ export const ESQLEditor = memo(function ESQLEditor({

const hoverProvider = useMemo(() => ESQLLang.getHoverProvider?.(esqlCallbacks), [esqlCallbacks]);

const codeActionProvider = useMemo(
() => ESQLLang.getCodeActionProvider?.(esqlCallbacks),
[esqlCallbacks]
);

const onErrorClick = useCallback(({ startLineNumber, startColumn }: MonacoMessage) => {
if (!editor1.current) {
return;
Expand Down Expand Up @@ -770,7 +765,6 @@ export const ESQLEditor = memo(function ESQLEditor({
return hoverProvider?.provideHover(model, position, token);
},
}}
codeActions={codeActionProvider}
onChange={onQueryUpdate}
editorDidMount={(editor) => {
editor1.current = editor;
Expand Down
3 changes: 3 additions & 0 deletions src/platform/packages/private/kbn-esql-editor/src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,9 @@ export const getEditorOverwrites = (theme: UseEuiTheme<{}>) => {
.monaco-hover {
display: block !important;
}
.hover-row.status-bar {
display: none;
}
.margin-view-overlays .line-numbers {
color: ${theme.euiTheme.colors.textDisabled};
}
Expand Down
1 change: 0 additions & 1 deletion src/platform/packages/shared/kbn-esql-validation-autocomplete/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ The package is structure as follow:
```
src
| autocomplete // => the autocomplete/suggest service logic
| code_actions // => the quick fixes service logic
| definitions // => static assets to define all components behaviour of a ES|QL query: commands, functions, etc...
| validation // => the validation logic

Expand Down
6 changes: 0 additions & 6 deletions src/platform/packages/shared/kbn-esql-validation-autocomplete/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
*/

export type { SuggestionRawDefinition, ItemKind } from './src/autocomplete/types';
export type { CodeAction } from './src/code_actions/types';
export type {
FunctionDefinition,
CommandDefinition,
Expand All @@ -28,9 +27,6 @@ export { getAstContext } from './src/shared/context';
export { validateQuery } from './src/validation/validation';
// Autocomplete function
export { suggest } from './src/autocomplete/autocomplete';
// Quick fixes function
export { getActions } from './src/code_actions/actions';

/**
* Some utility functions that can be useful to build more feature
* for the ES|QL language
Expand Down Expand Up @@ -76,6 +72,4 @@ export {
getSourcesHelper,
} from './src/shared/resources_helpers';

export { wrapAsEditorMessage } from './src/code_actions/utils';

export { getRecommendedQueries } from './src/autocomplete/recommended_queries/templates';
Loading