[8.x] [ES|QL] Hides the actions and the "View problem" from the editor (#213325)#213875
Merged
stratoula merged 2 commits intoelastic:8.xfrom Mar 11, 2025
Merged
[8.x] [ES|QL] Hides the actions and the "View problem" from the editor (#213325)#213875stratoula merged 2 commits intoelastic:8.xfrom
stratoula merged 2 commits intoelastic:8.xfrom
Conversation
…stic#213325) ## Summary Hides the actions and the view problem from the hover. (I didnt remove the code, we might want to enable it again in the future but we need to fix the bug I mention below) **Now** <img width="719" alt="image" src="https://github.com/user-attachments/assets/423cfbdd-e067-409c-8eb4-1e2c2cc17649" /> **Before** <img width="617" alt="image" src="https://github.com/user-attachments/assets/7ec5f48d-af8b-4676-84f4-9fa4a0d8f220" /> 1. Quick fixes has a lot of bugs such as: - elastic#180491 - It is not easy to select it  2. View problem doesn't appear correctly and it just repeats the error that exists already in the hover  3. Quick fixes are fixing now typos such as - index patterns - policies - field names - metadata options - quotes Our autocomplete is good enough to solve these so this is not so helpful. This PR hides the actions as they don't work correctly. We should reconsider displaying them again but for more sophisticated fixes such as: elastic#177554 (not for enrich but for joins) We should fix the bug first (quick fix is not clickable) (cherry picked from commit b9472b6) # Conflicts: # src/platform/packages/shared/kbn-monaco/src/esql/lib/converters/actions.ts # src/platform/packages/shared/kbn-monaco/src/esql/lib/esql_ast_provider.ts
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation