Skip to content

[8.x] [ES|QL] Hides the actions and the "View problem" from the editor (#213325)#213875

Merged
stratoula merged 2 commits intoelastic:8.xfrom
stratoula:backport/8.x/pr-213325
Mar 11, 2025
Merged

[8.x] [ES|QL] Hides the actions and the "View problem" from the editor (#213325)#213875
stratoula merged 2 commits intoelastic:8.xfrom
stratoula:backport/8.x/pr-213325

Conversation

@stratoula
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…stic#213325)

## Summary

Hides the actions and the view problem from the hover. (I didnt remove
the code, we might want to enable it again in the future but we need to
fix the bug I mention below)

**Now**

<img width="719" alt="image"
src="https://github.com/user-attachments/assets/423cfbdd-e067-409c-8eb4-1e2c2cc17649"
/>

**Before**

<img width="617" alt="image"
src="https://github.com/user-attachments/assets/7ec5f48d-af8b-4676-84f4-9fa4a0d8f220"
/>

1. Quick fixes has a lot of bugs such as:
- elastic#180491
- It is not easy to select it

![meow](https://github.com/user-attachments/assets/59856c5f-08cd-4205-96f3-b2a8a1da7c60)

2. View problem doesn't appear correctly and it just repeats the error
that exists already in the hover

![meow](https://github.com/user-attachments/assets/a3ab0c95-5997-4104-816a-97c249acafb6)

3. Quick fixes are fixing now typos such as
- index patterns
- policies
- field names
- metadata options
- quotes

Our autocomplete is good enough to solve these so this is not so
helpful.

This PR hides the actions as they don't work correctly. We should
reconsider displaying them again but for more sophisticated fixes such
as:

elastic#177554 (not for enrich but for
joins)

We should fix the bug first (quick fix is not clickable)

(cherry picked from commit b9472b6)

# Conflicts:
#	src/platform/packages/shared/kbn-monaco/src/esql/lib/converters/actions.ts
#	src/platform/packages/shared/kbn-monaco/src/esql/lib/esql_ast_provider.ts
@stratoula stratoula added the backport This PR is a backport of another PR label Mar 11, 2025
@stratoula stratoula enabled auto-merge (squash) March 11, 2025 09:01
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
esql 209 207 -2
lists 441 439 -2
securitySolution 7121 7119 -2
unifiedSearch 370 368 -2
total -8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-validation-autocomplete 200 186 -14
@kbn/monaco 127 125 -2
total -16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 238.1KB 238.0KB -108.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/esql-validation-autocomplete 14 12 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.6MB 3.6MB -6.3KB
Unknown metric groups

API count

id before after diff
@kbn/esql-validation-autocomplete 212 198 -14
@kbn/monaco 127 125 -2
total -16

@stratoula stratoula disabled auto-merge March 11, 2025 12:25
@stratoula stratoula merged commit e6e551f into elastic:8.x Mar 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants