[Security Solution] remove isDraggable props + various related cleanups#207959
Merged
PhilippeOberti merged 2 commits intoelastic:mainfrom Feb 6, 2025
Merged
[Security Solution] remove isDraggable props + various related cleanups#207959PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti merged 2 commits intoelastic:mainfrom
Conversation
PhilippeOberti
force-pushed
the
draggable-removal
branch
2 times, most recently
from
6ec8642 to
15a5642
Compare
PhilippeOberti
force-pushed
the
draggable-removal
branch
from
15a5642 to
71b7f16
Compare
PhilippeOberti
force-pushed
the
draggable-removal
branch
4 times, most recently
from
c1d469a to
c7d6b5e
Compare
PhilippeOberti
added
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
Contributor
Author
Files by Code Ownerelastic/kibana-localization
elastic/kibana-operations
elastic/security-detection-engine
elastic/security-engineering-productivity
elastic/security-entity-analytics
elastic/security-generative-ai
elastic/security-solution
elastic/security-threat-hunting-explore
elastic/security-threat-hunting-investigations
|
PhilippeOberti
changed the title
andrew-goldstein
approved these changes
Jan 30, 2025
Contributor
andrew-goldstein
left a comment
andrew-goldstein
left a comment
There was a problem hiding this comment.
elastic/security-generative-ai changes LGTM
jbudz
approved these changes
Jan 31, 2025
Contributor
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
packages/kbn-babel-preset/styled_components_files.js LGTM
CAWilson94
approved these changes
Feb 3, 2025
Contributor
CAWilson94
left a comment
CAWilson94
left a comment
There was a problem hiding this comment.
Desk tested relevant areas in Entity Analytics for current isDraggable usage—can confirm it’s not in use. Great work, thanks! 🎉
rylnd
approved these changes
Feb 5, 2025
Contributor
rylnd
left a comment
rylnd
left a comment
There was a problem hiding this comment.
Detection Engine changes LGTM.
semd
approved these changes
Feb 5, 2025
Contributor
semd
left a comment
semd
left a comment
There was a problem hiding this comment.
Threat Hunting Explore changes LGTM
christineweng
approved these changes
Feb 5, 2025
Contributor
christineweng
left a comment
christineweng
left a comment
There was a problem hiding this comment.
Awesome clean up! Investigations changes LGTM, just had a question about a cypress test
Contributor
There was a problem hiding this comment.
why did the number change?
Contributor
Author
There was a problem hiding this comment.
because I changed the way the dom element was queried. With the simplification, it removed some extra unused dom elements which had a data-test-subj that was used. To keep things simple and not introduce new code, I used another existing data-test-subj, but that one is on multiple elements on the page (in the KPI chart first then in the alerts table).
It is not the most elegant way to solve this, but it was the only way I found without modifying application's code.
PhilippeOberti
force-pushed
the
draggable-removal
branch
from
c7d6b5e to
e0d861f
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13188628402 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
drewdaemon
pushed a commit
to drewdaemon/kibana
that referenced
this pull request
Feb 6, 2025
…ps (elastic#207959) ## Summary This PR removes the `isDraggable` prop throughout Security Solution. Unless I'm mistaken, this property isn't necessary anymore, as we do not use those draggable elements anymore. From what I could see, we had its value set to `false` everywhere. This lead to a lot of files impacted, but most of them have only a couple of lines changed. In some files though, removing the `isDraggable` prop allowed to remove more code than became obsolete. **No UI changes should have been introduced in this PR!** ### What this PR does - removes `isDraggable` everywhere - performs the extra small cleanup when obvious - updates all corresponding unit e2e and tests ### What this PR does - rename files or component names to limit the already extensive impact of the code change
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Feb 7, 2025
…ps (elastic#207959) ## Summary This PR removes the `isDraggable` prop throughout Security Solution. Unless I'm mistaken, this property isn't necessary anymore, as we do not use those draggable elements anymore. From what I could see, we had its value set to `false` everywhere. This lead to a lot of files impacted, but most of them have only a couple of lines changed. In some files though, removing the `isDraggable` prop allowed to remove more code than became obsolete. **No UI changes should have been introduced in this PR!** ### What this PR does - removes `isDraggable` everywhere - performs the extra small cleanup when obvious - updates all corresponding unit e2e and tests ### What this PR does - rename files or component names to limit the already extensive impact of the code change (cherry picked from commit ebb31d2) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_kpis/severity_level_panel/columns.tsx # x-pack/solutions/security/plugins/security_solution/public/one_discover/cell_renderers/cell_renderer.test.tsx # x-pack/solutions/security/plugins/security_solution/public/one_discover/cell_renderers/cell_renderers.tsx # x-pack/solutions/security/plugins/security_solution/public/timelines/components/netflow/__snapshots__/index.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/body/renderers/netflow/__snapshots__/netflow_row_renderer.test.tsx.snap # x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_cell_actions.cy.ts
PhilippeOberti
added a commit
that referenced
this pull request
Feb 7, 2025
…cleanups (#207959) (#210116) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] remove isDraggable props + various related cleanups (#207959)](#207959) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T21:56:09Z","message":"[Security Solution] remove isDraggable props + various related cleanups (#207959)\n\n## Summary\r\n\r\nThis PR removes the `isDraggable` prop throughout Security Solution.\r\nUnless I'm mistaken, this property isn't necessary anymore, as we do not\r\nuse those draggable elements anymore. From what I could see, we had its\r\nvalue set to `false` everywhere.\r\n\r\nThis lead to a lot of files impacted, but most of them have only a\r\ncouple of lines changed. In some files though, removing the\r\n`isDraggable` prop allowed to remove more code than became obsolete.\r\n\r\n**No UI changes should have been introduced in this PR!**\r\n\r\n### What this PR does\r\n\r\n- removes `isDraggable` everywhere\r\n- performs the extra small cleanup when obvious\r\n- updates all corresponding unit e2e and tests\r\n\r\n### What this PR does\r\n\r\n- rename files or component names to limit the already extensive impact\r\nof the code change","sha":"ebb31d249f5d940fac6188230c03b8435ddb26ca","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] remove isDraggable props + various related cleanups","number":207959,"url":"https://github.com/elastic/kibana/pull/207959","mergeCommit":{"message":"[Security Solution] remove isDraggable props + various related cleanups (#207959)\n\n## Summary\r\n\r\nThis PR removes the `isDraggable` prop throughout Security Solution.\r\nUnless I'm mistaken, this property isn't necessary anymore, as we do not\r\nuse those draggable elements anymore. From what I could see, we had its\r\nvalue set to `false` everywhere.\r\n\r\nThis lead to a lot of files impacted, but most of them have only a\r\ncouple of lines changed. In some files though, removing the\r\n`isDraggable` prop allowed to remove more code than became obsolete.\r\n\r\n**No UI changes should have been introduced in this PR!**\r\n\r\n### What this PR does\r\n\r\n- removes `isDraggable` everywhere\r\n- performs the extra small cleanup when obvious\r\n- updates all corresponding unit e2e and tests\r\n\r\n### What this PR does\r\n\r\n- rename files or component names to limit the already extensive impact\r\nof the code change","sha":"ebb31d249f5d940fac6188230c03b8435ddb26ca"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207959","number":207959,"mergeCommit":{"message":"[Security Solution] remove isDraggable props + various related cleanups (#207959)\n\n## Summary\r\n\r\nThis PR removes the `isDraggable` prop throughout Security Solution.\r\nUnless I'm mistaken, this property isn't necessary anymore, as we do not\r\nuse those draggable elements anymore. From what I could see, we had its\r\nvalue set to `false` everywhere.\r\n\r\nThis lead to a lot of files impacted, but most of them have only a\r\ncouple of lines changed. In some files though, removing the\r\n`isDraggable` prop allowed to remove more code than became obsolete.\r\n\r\n**No UI changes should have been introduced in this PR!**\r\n\r\n### What this PR does\r\n\r\n- removes `isDraggable` everywhere\r\n- performs the extra small cleanup when obvious\r\n- updates all corresponding unit e2e and tests\r\n\r\n### What this PR does\r\n\r\n- rename files or component names to limit the already extensive impact\r\nof the code change","sha":"ebb31d249f5d940fac6188230c03b8435ddb26ca"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This was referenced Feb 26, 2025
christineweng
added a commit
that referenced
this pull request
Nov 5, 2025
…212589) ## Summary This PR is a follow up clean up of draggables after [this PR](#207959) that removed `isDraggable` prop everywhere. This is part 2 of the draggable clean ups listed in #212593. Included in this PR: 1. Removed the creation of data provider props in `DefaultDraggable`. The security cell actions only require `field` and `value`, so creating the data provider object and later taking just the query fields are redundant. 2. Merged `CellActionWrapper`, `DraggableWrapper` and `DefaultDraggable` into `CellActionsRenderer`, moved files to cell actions folder 4. Updated Zeek and suricata components to call `CellActionsRenderer` directly and removed the tooltips 5. Updated tests Before and after in flow charts **Before** *props in red are used to create data provider and are now obsolete <img width="1345" height="706" alt="image" src="https://github.com/user-attachments/assets/406b84bd-9577-4fb3-9987-27b947eb62fb" /> **After** <img width="1071" height="707" alt="image" src="https://github.com/user-attachments/assets/4233ed14-4d46-432e-a22c-d416499aeb76" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
wildemat
pushed a commit
to wildemat/kibana
that referenced
this pull request
Nov 6, 2025
…lastic#212589) ## Summary This PR is a follow up clean up of draggables after [this PR](elastic#207959) that removed `isDraggable` prop everywhere. This is part 2 of the draggable clean ups listed in elastic#212593. Included in this PR: 1. Removed the creation of data provider props in `DefaultDraggable`. The security cell actions only require `field` and `value`, so creating the data provider object and later taking just the query fields are redundant. 2. Merged `CellActionWrapper`, `DraggableWrapper` and `DefaultDraggable` into `CellActionsRenderer`, moved files to cell actions folder 4. Updated Zeek and suricata components to call `CellActionsRenderer` directly and removed the tooltips 5. Updated tests Before and after in flow charts **Before** *props in red are used to create data provider and are now obsolete <img width="1345" height="706" alt="image" src="https://github.com/user-attachments/assets/406b84bd-9577-4fb3-9987-27b947eb62fb" /> **After** <img width="1071" height="707" alt="image" src="https://github.com/user-attachments/assets/4233ed14-4d46-432e-a22c-d416499aeb76" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
…lastic#212589) ## Summary This PR is a follow up clean up of draggables after [this PR](elastic#207959) that removed `isDraggable` prop everywhere. This is part 2 of the draggable clean ups listed in elastic#212593. Included in this PR: 1. Removed the creation of data provider props in `DefaultDraggable`. The security cell actions only require `field` and `value`, so creating the data provider object and later taking just the query fields are redundant. 2. Merged `CellActionWrapper`, `DraggableWrapper` and `DefaultDraggable` into `CellActionsRenderer`, moved files to cell actions folder 4. Updated Zeek and suricata components to call `CellActionsRenderer` directly and removed the tooltips 5. Updated tests Before and after in flow charts **Before** *props in red are used to create data provider and are now obsolete <img width="1345" height="706" alt="image" src="https://github.com/user-attachments/assets/406b84bd-9577-4fb3-9987-27b947eb62fb" /> **After** <img width="1071" height="707" alt="image" src="https://github.com/user-attachments/assets/4233ed14-4d46-432e-a22c-d416499aeb76" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
isDraggableprop throughout Security Solution. Unless I'm mistaken, this property isn't necessary anymore, as we do not use those draggable elements anymore. From what I could see, we had its value set tofalseeverywhere.This lead to a lot of files impacted, but most of them have only a couple of lines changed. In some files though, removing the
isDraggableprop allowed to remove more code than became obsolete.No UI changes should have been introduced in this PR!
What this PR does
isDraggableeverywhereWhat this PR does