[Security Solution] remove isDraggable props + various related cleanups

x-pack/platform/plugins/private/translations/translations/fr-FR.json

@@ -36409,9 +36409,6 @@
     "xpack.securitySolution.dragAndDrop.copyToClipboardTooltip": "Copier dans le Presse-papiers",
     "xpack.securitySolution.dragAndDrop.draggableKeyboardInstructionsNotDraggingScreenReaderOnly": "Appuyez sur Entrée pour accéder aux options ou sur la barre d'espace pour commencer le glisser-déposer.",
     "xpack.securitySolution.dragAndDrop.fieldLabel": "Champ",
-    "xpack.securitySolution.draggables.field.categoryLabel": "Catégorie",
-    "xpack.securitySolution.draggables.field.fieldLabel": "Champ",
-    "xpack.securitySolution.draggables.field.typeLabel": "Type",
     "xpack.securitySolution.editDataProvider.doesNotExistLabel": "n'existe pas",
     "xpack.securitySolution.editDataProvider.existsLabel": "existe",
     "xpack.securitySolution.editDataProvider.fieldLabel": "Champ",

x-pack/platform/plugins/private/translations/translations/ja-JP.json

@@ -36269,9 +36269,6 @@
     "xpack.securitySolution.dragAndDrop.copyToClipboardTooltip": "クリップボードにコピー",
     "xpack.securitySolution.dragAndDrop.draggableKeyboardInstructionsNotDraggingScreenReaderOnly": "オプションは Enter キーを押します。ドラッグを開始するには、スペースを押します。",
     "xpack.securitySolution.dragAndDrop.fieldLabel": "フィールド",
-    "xpack.securitySolution.draggables.field.categoryLabel": "カテゴリー",
-    "xpack.securitySolution.draggables.field.fieldLabel": "フィールド",
-    "xpack.securitySolution.draggables.field.typeLabel": "型",
     "xpack.securitySolution.editDataProvider.doesNotExistLabel": "存在しない",
     "xpack.securitySolution.editDataProvider.existsLabel": "存在する",
     "xpack.securitySolution.editDataProvider.fieldLabel": "フィールド",

x-pack/platform/plugins/private/translations/translations/zh-CN.json

@@ -35728,9 +35728,6 @@
     "xpack.securitySolution.dragAndDrop.copyToClipboardTooltip": "复制到剪贴板",
     "xpack.securitySolution.dragAndDrop.draggableKeyboardInstructionsNotDraggingScreenReaderOnly": "按 enter 键可显示选项，或按空格键开始拖动。",
     "xpack.securitySolution.dragAndDrop.fieldLabel": "字段",
-    "xpack.securitySolution.draggables.field.categoryLabel": "类别",
-    "xpack.securitySolution.draggables.field.fieldLabel": "字段",
-    "xpack.securitySolution.draggables.field.typeLabel": "类型",
     "xpack.securitySolution.editDataProvider.doesNotExistLabel": "不存在",
     "xpack.securitySolution.editDataProvider.existsLabel": "存在",
     "xpack.securitySolution.editDataProvider.fieldLabel": "字段",

x-pack/platform/plugins/shared/timelines/common/types/timeline/rows/index.ts

@@ -19,12 +19,10 @@ export interface DeprecatedRowRenderer {
   renderRow: ({
     contextId,
     data,
-    isDraggable,
     scopeId,
   }: {
     contextId?: string;
     data: Ecs;
-    isDraggable: boolean;
     scopeId: string;
   }) => React.ReactNode;
 }

x-pack/solutions/security/plugins/security_solution/common/types/timeline/cells/index.ts

@@ -23,7 +23,6 @@ export type CellValueElementProps = EuiDataGridCellValueElementProps & {
   ecsData?: Ecs;
   eventId: string; // _id
   header: ColumnHeaderOptions;
-  isDraggable: boolean;
   isTimeline?: boolean; // Default cell renderer is used for both the alert table and timeline. This allows us to cheaply separate concerns
   linkValues: string[] | undefined;
   rowRenderers?: RowRenderer[];

x-pack/solutions/security/plugins/security_solution/common/types/timeline/rows/index.ts

@@ -14,12 +14,10 @@ export interface RowRenderer {
   renderRow: ({
     contextId,
     data,
-    isDraggable,
     scopeId,
   }: {
     contextId?: string;
     data: Ecs;
-    isDraggable: boolean;
     scopeId: string;
   }) => React.ReactNode;
 }

x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/attack_discovery_markdown_formatter/field_markdown_renderer/get_host_flyout_panel_props.ts

@@ -14,7 +14,6 @@ interface HostPanelProps extends Record<string, unknown> {
   contextID: string;
   scopeId: string;
   hostName: string;
-  isDraggable?: boolean;
 }
 
 interface HostPanelExpandableFlyoutProps extends FlyoutPanelProps {

x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/attack_discovery_markdown_formatter/field_markdown_renderer/index.tsx

@@ -58,7 +58,6 @@ export const getFieldMarkdownRenderer = (disableActions: boolean) => {
             eventId=""
             iconType={icon}
             isAggregatable={false}
-            isDraggable={false}
             field={name}
             value={value}
           >

x-pack/solutions/security/plugins/security_solution/public/common/components/charts/draggable_legend_item.tsx

@@ -71,7 +71,6 @@ const DraggableLegendItemComponent: React.FC<{
                 field={field}
                 hideTopN={true}
                 id={dataProviderId}
-                isDraggable={false}
                 scopeId={scopeId}
                 value={value}
               >

x-pack/solutions/security/plugins/security_solution/public/common/components/drag_and_drop/draggable_wrapper.test.tsx

@@ -15,12 +15,7 @@ import { TestProviders } from '../../mock';
 import { mockDataProviders } from '../../../timelines/components/timeline/data_providers/mock/mock_data_providers';
 import { ROW_RENDERER_BROWSER_EXAMPLE_TIMELINE_ID } from '../../../timelines/components/row_renderers_browser/constants';
 import { DragDropContextWrapper } from './drag_drop_context_wrapper';
-import {
-  ConditionalPortal,
-  disableHoverActions,
-  DraggableWrapper,
-  getStyle,
-} from './draggable_wrapper';
+import { disableHoverActions, DraggableWrapper, getStyle } from './draggable_wrapper';
 import { useMountAppended } from '../../utils/use_mount_appended';
 import { TimelineId } from '../../../../common/types';
 import { TableId } from '@kbn/securitysolution-data-table';
@@ -85,11 +80,7 @@ describe('DraggableWrapper', () => {
       const wrapper = shallow(
         <TestProviders>
           <DragDropContextWrapper browserFields={mockBrowserFields}>
-            <DraggableWrapper
-              dataProvider={dataProvider}
-              isDraggable={true}
-              render={() => message}
-            />
+            <DraggableWrapper dataProvider={dataProvider} render={() => message} />
           </DragDropContextWrapper>
         </TestProviders>
       );
@@ -101,11 +92,7 @@ describe('DraggableWrapper', () => {
       const wrapper = mount(
         <TestProviders>
           <DragDropContextWrapper browserFields={mockBrowserFields}>
-            <DraggableWrapper
-              dataProvider={dataProvider}
-              isDraggable={true}
-              render={() => message}
-            />
+            <DraggableWrapper dataProvider={dataProvider} render={() => message} />
           </DragDropContextWrapper>
         </TestProviders>
       );
@@ -115,14 +102,11 @@ describe('DraggableWrapper', () => {
 
     scopeIdsWithHoverActions.forEach((scopeId) => {
       test(`it renders hover actions (by default) when 'isDraggable' is false and timelineId is '${scopeId}'`, async () => {
-        const isDraggable = false;
-
         const { queryByTestId } = render(
           <TestProviders>
             <DragDropContextWrapper browserFields={mockBrowserFields}>
               <DraggableWrapper
                 dataProvider={dataProvider}
-                isDraggable={isDraggable}
                 render={() => message}
                 scopeId={scopeId}
               />
@@ -136,14 +120,11 @@ describe('DraggableWrapper', () => {
 
     scopeIdsNoHoverActions.forEach((scopeId) => {
       test(`it does NOT render hover actions when 'isDraggable' is false and timelineId is '${scopeId}'`, async () => {
-        const isDraggable = false;
-
         const { queryByTestId } = render(
           <TestProviders>
             <DragDropContextWrapper browserFields={mockBrowserFields}>
               <DraggableWrapper
                 dataProvider={dataProvider}
-                isDraggable={isDraggable}
                 render={() => message}
                 scopeId={scopeId}
               />
@@ -161,30 +142,19 @@ describe('DraggableWrapper', () => {
       const wrapper = mount(
         <TestProviders>
           <DragDropContextWrapper browserFields={mockBrowserFields}>
-            <DraggableWrapper
-              dataProvider={dataProvider}
-              isDraggable={true}
-              render={() => message}
-              truncate
-            />
+            <DraggableWrapper dataProvider={dataProvider} render={() => message} truncate />
           </DragDropContextWrapper>
         </TestProviders>
       );
 
-      expect(wrapper.find('[data-test-subj="draggable-truncatable-content"]').exists()).toEqual(
-        true
-      );
+      expect(wrapper.find('[data-test-subj="render-truncatable-content"]').exists()).toEqual(true);
     });
 
     test('it does NOT apply text truncation styling when truncate is NOT specified', () => {
       const wrapper = mount(
         <TestProviders>
           <DragDropContextWrapper browserFields={mockBrowserFields}>
-            <DraggableWrapper
-              dataProvider={dataProvider}
-              isDraggable={true}
-              render={() => message}
-            />
+            <DraggableWrapper dataProvider={dataProvider} render={() => message} />
           </DragDropContextWrapper>
         </TestProviders>
       );
@@ -197,21 +167,6 @@ describe('DraggableWrapper', () => {
 });
 
 describe('ConditionalPortal', () => {
-  const mount = useMountAppended();
-  const props = {
-    registerProvider: jest.fn(),
-  };
-
-  it('calls registerProvider when isDragging', () => {
-    mount(
-      <ConditionalPortal {...props}>
-        <div />
-      </ConditionalPortal>
-    );
-
-    expect(props.registerProvider.mock.calls.length).toEqual(1);
-  });
-
   describe('getStyle', () => {
     const style: DraggingStyle = {
       boxSizing: 'border-box',