[8.x] [Security Solution] remove isDraggable props + various related cleanups (#207959)#210116
Merged
PhilippeOberti merged 1 commit intoelastic:8.xfrom Feb 7, 2025
Merged
Conversation
PhilippeOberti
force-pushed
the
backport/8.x/pr-207959
branch
from
9719405 to
34521f6
Compare
…ps (elastic#207959) ## Summary This PR removes the `isDraggable` prop throughout Security Solution. Unless I'm mistaken, this property isn't necessary anymore, as we do not use those draggable elements anymore. From what I could see, we had its value set to `false` everywhere. This lead to a lot of files impacted, but most of them have only a couple of lines changed. In some files though, removing the `isDraggable` prop allowed to remove more code than became obsolete. **No UI changes should have been introduced in this PR!** ### What this PR does - removes `isDraggable` everywhere - performs the extra small cleanup when obvious - updates all corresponding unit e2e and tests ### What this PR does - rename files or component names to limit the already extensive impact of the code change (cherry picked from commit ebb31d2) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_kpis/severity_level_panel/columns.tsx # x-pack/solutions/security/plugins/security_solution/public/one_discover/cell_renderers/cell_renderer.test.tsx # x-pack/solutions/security/plugins/security_solution/public/one_discover/cell_renderers/cell_renderers.tsx # x-pack/solutions/security/plugins/security_solution/public/timelines/components/netflow/__snapshots__/index.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/body/renderers/netflow/__snapshots__/netflow_row_renderer.test.tsx.snap # x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_cell_actions.cy.ts
PhilippeOberti
force-pushed
the
backport/8.x/pr-207959
branch
from
65bf0b2 to
7770e6b
Compare
christineweng
approved these changes
Feb 7, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation