Skip to content

[Security Solution] Remove draggable wrapper and data provider props#212589

Merged
christineweng merged 3 commits intoelastic:mainfrom
christineweng:remove-draggable-wrapper
Nov 5, 2025
Merged

[Security Solution] Remove draggable wrapper and data provider props#212589
christineweng merged 3 commits intoelastic:mainfrom
christineweng:remove-draggable-wrapper

Conversation

@christineweng
Copy link
Copy Markdown
Contributor

@christineweng christineweng commented Feb 26, 2025 •
edited
Loading

Summary

This PR is a follow up clean up of draggables after this PR that removed isDraggable prop everywhere. This is part 2 of the draggable clean ups listed in #212593.

Included in this PR:

  1. Removed the creation of data provider props in DefaultDraggable. The security cell actions only require field and value, so creating the data provider object and later taking just the query fields are redundant.
  2. Merged CellActionWrapper, DraggableWrapper and DefaultDraggable into CellActionsRenderer, moved files to cell actions folder
  3. Updated Zeek and suricata components to call CellActionsRenderer directly and removed the tooltips
  4. Updated tests

Before and after in flow charts

Before
*props in red are used to create data provider and are now obsolete
image

After
image

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@christineweng christineweng added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Feb 26, 2025
@christineweng christineweng self-assigned this Feb 26, 2025
@christineweng christineweng mentioned this pull request Feb 26, 2025
Open
@christineweng christineweng added the Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team label Feb 26, 2025
@christineweng christineweng force-pushed the remove-draggable-wrapper branch 4 times, most recently from 3d6f957 to b798ccf Compare March 4, 2025 03:39
@christineweng christineweng added backport:skip This PR does not require backporting v9.2.0 and removed backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Aug 14, 2025
@christineweng christineweng force-pushed the remove-draggable-wrapper branch 4 times, most recently from ce2c915 to 3964b22 Compare August 15, 2025 19:28
@christineweng christineweng force-pushed the remove-draggable-wrapper branch 2 times, most recently from 76c4979 to d68a539 Compare October 24, 2025 16:32
@christineweng christineweng force-pushed the remove-draggable-wrapper branch 2 times, most recently from 83c7fde to d2b0add Compare October 29, 2025 20:21
@christineweng christineweng marked this pull request as ready for review October 29, 2025 20:22
@christineweng christineweng requested review from a team as code owners October 29, 2025 20:22
@christineweng christineweng requested a review from a team as a code owner October 29, 2025 20:22
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2025

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@christineweng christineweng force-pushed the remove-draggable-wrapper branch from d2b0add to 364f172 Compare October 29, 2025 23:55
PhilippeOberti
PhilippeOberti approved these changes Oct 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this! Code LGTM and did some smoke testing, everything looks good. Thanks for this very nice cleanup :)

machadoum
machadoum approved these changes Nov 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@machadoum machadoum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entity analytics code LGTM!

I desk-tested it, but couldn't find many entity analytics pages affected. The only one I did was the network/maps tools.

Image Image

I also noticed that many of the affected components are rendered by the timeline, so we might consider moving it to the timeline code base in the future:

Image

Thank you! Great effort! 👏 👏 👏

@christineweng christineweng enabled auto-merge (squash) November 5, 2025 19:57
@christineweng christineweng merged commit 91aa8e0 into elastic:main Nov 5, 2025
12 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 5, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.0MB 11.0MB -3.7KB

Count of Enzyme imports

Enzyme is no longer supported, and we should switch to @testing-library/react instead.

id before after diff
securitySolution 183 182 -1

History

cc @christineweng

wildemat pushed a commit to wildemat/kibana that referenced this pull request Nov 6, 2025
@christineweng @wildemat
[Security Solution] Remove draggable wrapper and data provider props (e…
daf36c3 
…lastic#212589)

## Summary

This PR is a follow up clean up of draggables after [this
PR](elastic#207959) that removed
`isDraggable` prop everywhere. This is part 2 of the draggable clean ups
listed in elastic#212593.

Included in this PR:

1. Removed the creation of data provider props in `DefaultDraggable`.
The security cell actions only require `field` and `value`, so creating
the data provider object and later taking just the query fields are
redundant.
2. Merged `CellActionWrapper`, `DraggableWrapper` and `DefaultDraggable`
into `CellActionsRenderer`, moved files to cell actions folder
4. Updated Zeek and suricata components to call `CellActionsRenderer`
directly and removed the tooltips
5. Updated tests 


Before and after in flow charts

**Before**
*props in red are used to create data provider and are now obsolete
<img width="1345" height="706" alt="image"
src="https://github.com/user-attachments/assets/406b84bd-9577-4fb3-9987-27b947eb62fb"
/>

**After**
<img width="1071" height="707" alt="image"
src="https://github.com/user-attachments/assets/4233ed14-4d46-432e-a22c-d416499aeb76"
/>




### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Dec 2, 2025
@christineweng @eokoneyo
[Security Solution] Remove draggable wrapper and data provider props (e…
925e7a8 
…lastic#212589)

## Summary

This PR is a follow up clean up of draggables after [this
PR](elastic#207959) that removed
`isDraggable` prop everywhere. This is part 2 of the draggable clean ups
listed in elastic#212593.

Included in this PR:

1. Removed the creation of data provider props in `DefaultDraggable`.
The security cell actions only require `field` and `value`, so creating
the data provider object and later taking just the query fields are
redundant.
2. Merged `CellActionWrapper`, `DraggableWrapper` and `DefaultDraggable`
into `CellActionsRenderer`, moved files to cell actions folder
4. Updated Zeek and suricata components to call `CellActionsRenderer`
directly and removed the tooltips
5. Updated tests 


Before and after in flow charts

**Before**
*props in red are used to create data provider and are now obsolete
<img width="1345" height="706" alt="image"
src="https://github.com/user-attachments/assets/406b84bd-9577-4fb3-9987-27b947eb62fb"
/>

**After**
<img width="1071" height="707" alt="image"
src="https://github.com/user-attachments/assets/4233ed14-4d46-432e-a22c-d416499aeb76"
/>




### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@machadoum machadoum machadoum approved these changes

@jbudz jbudz jbudz approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees

@christineweng christineweng

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@christineweng @elasticmachine @machadoum @jbudz @PhilippeOberti