[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components#207318
Merged
agusruidiazgd merged 18 commits intoelastic:mainfrom Jan 30, 2025
Merged
Conversation
agusruidiazgd
added
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
jbudz
approved these changes
Jan 21, 2025
Contributor
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
packages/kbn-babel-preset/styled_components_files.js LGTM
christineweng
approved these changes
Jan 22, 2025
Contributor
christineweng
left a comment
christineweng
left a comment
There was a problem hiding this comment.
investigations changes LGTM, thank you!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
There are no new commits on the base branch. |
…azgd/kibana into fix/styled-component-migration
kapral18
reviewed
Jan 23, 2025
...ity/plugins/security_solution/public/explore/network/components/embeddables/embedded_map.tsx
Outdated
Show resolved
Hide resolved
kapral18
approved these changes
Jan 23, 2025
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kapral18
added
backport:version
Contributor
|
removing 9.0.0 to not trigger automation for backports for already merged 9.0.0 |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kapral18
pushed a commit
to kapral18/kibana
that referenced
this pull request
Feb 11, 2025
…nents (elastic#207318) ## Summary Addresses [elastic#206437](elastic#206437) This PR migrates `explore page` from `styled-components` to `@emotion/styled`. In the process I also convert the kbn/ui-theme json tokens to euiTheme counterparts. https://github.com/user-attachments/assets/f1702c0d-78f7-4e17-a8d6-c7c9ae19d3b7 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 1e63b5a)
kapral18
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
…nents (elastic#207318) Addresses [elastic#206437](elastic#206437) This PR migrates `explore page` from `styled-components` to `@emotion/styled`. In the process I also convert the kbn/ui-theme json tokens to euiTheme counterparts. https://github.com/user-attachments/assets/f1702c0d-78f7-4e17-a8d6-c7c9ae19d3b7 Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 1e63b5a)
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…-components (#207318) (#208928) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)](#207318) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Agustina Nahir Ruidiaz","email":"61565784+agusruidiazgd@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-30T12:24:05Z","message":"[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)\n\n## Summary\r\nAddresses [#206437](https://github.com/elastic/kibana/issues/206437)\r\nThis PR migrates `explore page` from `styled-components` to\r\n`@emotion/styled`.\r\nIn the process I also convert the kbn/ui-theme json tokens to euiTheme\r\ncounterparts.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f1702c0d-78f7-4e17-a8d6-c7c9ae19d3b7\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1e63b5ae999eb5022f9f02626db9f70e17d28a92","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Explore","backport:prev-minor","ci:cloud-deploy","EUI Visual Refresh"],"title":"[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components","number":207318,"url":"https://github.com/elastic/kibana/pull/207318","mergeCommit":{"message":"[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)\n\n## Summary\r\nAddresses [#206437](https://github.com/elastic/kibana/issues/206437)\r\nThis PR migrates `explore page` from `styled-components` to\r\n`@emotion/styled`.\r\nIn the process I also convert the kbn/ui-theme json tokens to euiTheme\r\ncounterparts.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f1702c0d-78f7-4e17-a8d6-c7c9ae19d3b7\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1e63b5ae999eb5022f9f02626db9f70e17d28a92"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207318","number":207318,"mergeCommit":{"message":"[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)\n\n## Summary\r\nAddresses [#206437](https://github.com/elastic/kibana/issues/206437)\r\nThis PR migrates `explore page` from `styled-components` to\r\n`@emotion/styled`.\r\nIn the process I also convert the kbn/ui-theme json tokens to euiTheme\r\ncounterparts.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f1702c0d-78f7-4e17-a8d6-c7c9ae19d3b7\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1e63b5ae999eb5022f9f02626db9f70e17d28a92"}}]}] BACKPORT--> --------- Co-authored-by: Agustina Nahir Ruidiaz <61565784+agusruidiazgd@users.noreply.github.com> Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>
kapral18
added a commit
that referenced
this pull request
Feb 12, 2025
…d-components (#207318) (#209852) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)](#207318) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Agustina Nahir Ruidiaz","email":"61565784+agusruidiazgd@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-30T12:24:05Z","message":"[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)\n\n## Summary\r\nAddresses [#206437](https://github.com/elastic/kibana/issues/206437)\r\nThis PR migrates `explore page` from `styled-components` to\r\n`@emotion/styled`.\r\nIn the process I also convert the kbn/ui-theme json tokens to euiTheme\r\ncounterparts.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f1702c0d-78f7-4e17-a8d6-c7c9ae19d3b7\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1e63b5ae999eb5022f9f02626db9f70e17d28a92","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","Team:Threat Hunting:Explore","ci:cloud-deploy","backport:version","v8.18.0","EUI Visual Refresh","v9.1.0"],"title":"[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components","number":207318,"url":"https://github.com/elastic/kibana/pull/207318","mergeCommit":{"message":"[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)\n\n## Summary\r\nAddresses [#206437](https://github.com/elastic/kibana/issues/206437)\r\nThis PR migrates `explore page` from `styled-components` to\r\n`@emotion/styled`.\r\nIn the process I also convert the kbn/ui-theme json tokens to euiTheme\r\ncounterparts.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f1702c0d-78f7-4e17-a8d6-c7c9ae19d3b7\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1e63b5ae999eb5022f9f02626db9f70e17d28a92"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/208928","number":208928,"state":"OPEN"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Agustina Nahir Ruidiaz <61565784+agusruidiazgd@users.noreply.github.com>
kibanamachine
removed
the
backport missing
This was referenced Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #206437
This PR migrates
explore pagefromstyled-componentsto@emotion/styled.In the process I also convert the kbn/ui-theme json tokens to euiTheme counterparts.
Screen.Recording.2025-01-21.at.11.22.34.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.