Skip to content

[ML] Fixes Anomaly Explorer URL for alerting context with non-default space #160899

Merged
darnautov merged 5 commits intoelastic:mainfrom
darnautov:ml-160762-ad-alert-explorer-url
Jul 5, 2023
Merged

[ML] Fixes Anomaly Explorer URL for alerting context with non-default space #160899
darnautov merged 5 commits intoelastic:mainfrom
darnautov:ml-160762-ad-alert-explorer-url

Conversation

@darnautov
Copy link
Copy Markdown
Contributor

@darnautov darnautov commented Jun 29, 2023 •
edited by kibanamachine
Loading

Summary

Fixes #160762

Checklist

@darnautov darnautov added release_note:fix :ml Feature:Anomaly Detection ML anomaly detection Team:ML Team label for ML (also use :ml) t// v8.9.0 v8.10.0 labels Jun 29, 2023
@darnautov darnautov requested a review from a team as a code owner June 29, 2023 14:30
@darnautov darnautov self-assigned this Jun 29, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 29, 2023

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic reviewed Jun 29, 2023
View reviewed changes
@darnautov darnautov requested review from alvarezmelissa87 and jgowdyelastic and removed request for walterra June 29, 2023 14:48
@darnautov darnautov requested a review from a team as a code owner July 4, 2023 08:16
@darnautov
Copy link
Copy Markdown
Contributor Author

darnautov commented Jul 4, 2023

@elasticmachine merge upstream

jgowdyelastic
jgowdyelastic reviewed Jul 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 4, 2023

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov enabled auto-merge (squash) July 4, 2023 11:02
@darnautov darnautov merged commit 7728519 into elastic:main Jul 5, 2023
@darnautov darnautov deleted the ml-160762-ad-alert-explorer-url branch July 5, 2023 08:58
@kibanamachine kibanamachine mentioned this pull request Jul 5, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 5, 2023
@darnautov
[ML] Fix Anomaly Explorer URL for alerting context with non-default s…
67a97a3 
…pace (elastic#160899)

## Summary

Fixes elastic#160762

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7728519)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 5, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 5, 2023
@kibanamachine @darnautov
[8.9] [ML] Fix Anomaly Explorer URL for alerting context with non-def…
b53af79 
…ault space (#160899) (#161235)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[ML] Fix Anomaly Explorer URL for alerting context with non-default
space (#160899)](#160899)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-07-05T08:53:02Z","message":"[ML]
Fix Anomaly Explorer URL for alerting context with non-default space
(#160899)\n\n## Summary\r\n\r\nFixes #160762 \r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"77285193045db36453f367d61552638218fde013","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly
Detection","Team:ML","v8.9.0","v8.10.0"],"number":160899,"url":"https://github.com/elastic/kibana/pull/160899","mergeCommit":{"message":"[ML]
Fix Anomaly Explorer URL for alerting context with non-default space
(#160899)\n\n## Summary\r\n\r\nFixes #160762 \r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"77285193045db36453f367d61552638218fde013"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160899","number":160899,"mergeCommit":{"message":"[ML]
Fix Anomaly Explorer URL for alerting context with non-default space
(#160899)\n\n## Summary\r\n\r\nFixes #160762 \r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"77285193045db36453f367d61552638218fde013"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 5, 2023
@jloleysens
Merge branch 'main' into additional-validation-mechanism
cfd7b70 
* main: (354 commits)
  [Synthetics] Overview page fix last refresh value display (elastic#161086)
  [Synthetics] Remove TLS alert option for ICMP monitor (elastic#161173)
  fixing the path of manifets for hints autodiscover (elastic#161075)
  [Fleet] Fix permissions in integrations Assets page (elastic#161233)
  Update publicBaseUrl warning id (elastic#161204)
  [ML] Fix Anomaly Explorer URL for alerting context with non-default space  (elastic#160899)
  [Enterprise Search]Add 404 error handling for mappings and documents endpoints (elastic#161203)
  [Logs Shared] Move LogStream and LogView into new shared plugin (elastic#161151)
  [Security Solutions] Fix  CellActions component should hide ShowTopN action for nested fields (elastic#159645)
  [SecuritySolutions] Remove filter actions from Cases alerts table and fix show_top_n action (elastic#161150)
  [Infrastructure UI] Add strict payload validation to inventory_views endpoint (elastic#160852)
  [api-docs] 2023-07-05 Daily api_docs build (elastic#161225)
  Fix errors in custom metric payload in SLO dev docs (elastic#161141)
  [data views] Fix overwrite param for create (elastic#160953)
  [Synthetics] Perform params API HTTP migration (elastic#160575)
  [Cloud Security][FTR]Refactor API FTR to use .to.eql instead of .to.be  (elastic#160694)
  Have SLO routes return a 403 instead of a 400 when user has an insufficient license (elastic#161193)
  [Discover] Fix shared links flaky test (elastic#161172)
  [ftr] Improve FTR error handling for NoSuchSessionError (elastic#161025)
  skip flaky suite (elastic#151981)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 5, 2023
@jloleysens
Merge branch 'main' into more-response-validation-tests
7d26fcf 
* main: (354 commits)
  [Synthetics] Overview page fix last refresh value display (elastic#161086)
  [Synthetics] Remove TLS alert option for ICMP monitor (elastic#161173)
  fixing the path of manifets for hints autodiscover (elastic#161075)
  [Fleet] Fix permissions in integrations Assets page (elastic#161233)
  Update publicBaseUrl warning id (elastic#161204)
  [ML] Fix Anomaly Explorer URL for alerting context with non-default space  (elastic#160899)
  [Enterprise Search]Add 404 error handling for mappings and documents endpoints (elastic#161203)
  [Logs Shared] Move LogStream and LogView into new shared plugin (elastic#161151)
  [Security Solutions] Fix  CellActions component should hide ShowTopN action for nested fields (elastic#159645)
  [SecuritySolutions] Remove filter actions from Cases alerts table and fix show_top_n action (elastic#161150)
  [Infrastructure UI] Add strict payload validation to inventory_views endpoint (elastic#160852)
  [api-docs] 2023-07-05 Daily api_docs build (elastic#161225)
  Fix errors in custom metric payload in SLO dev docs (elastic#161141)
  [data views] Fix overwrite param for create (elastic#160953)
  [Synthetics] Perform params API HTTP migration (elastic#160575)
  [Cloud Security][FTR]Refactor API FTR to use .to.eql instead of .to.be  (elastic#160694)
  Have SLO routes return a 403 instead of a 400 when user has an insufficient license (elastic#161193)
  [Discover] Fix shared links flaky test (elastic#161172)
  [ftr] Improve FTR error handling for NoSuchSessionError (elastic#161025)
  skip flaky suite (elastic#151981)
  ...
@szabosteve szabosteve changed the title [ML] Fix Anomaly Explorer URL for alerting context with non-default space [ML] Fixes Anomaly Explorer URL for alerting context with non-default space Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnasikas cnasikas cnasikas approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

@qn895 qn895 Awaiting requested review from qn895

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@darnautov darnautov

Labels

Feature:Anomaly Detection ML anomaly detection :ml release_note:fix Team:ML Team label for ML (also use :ml) t// v8.9.0 v8.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ML] Anomaly Explorer URL in alerting context doesn't contain a space id

6 participants

@darnautov @elasticmachine @kibana-ci @kibanamachine @cnasikas @jgowdyelastic