[data views] Fix overwrite param for create by mattkime · Pull Request #160953 · elastic/kibana

mattkime · 2023-06-30T01:06:20Z

Summary

Under some circumstances passing override to POST /api/data_views/data_view would fail. Its now fixed.

To test - Try using the override param from the Kibana dev console. I found it reproduced the problem before the fix and shows its resolved after the fix. The problem did not appear in the integration tests.

I suspect the problem had to do with how quickly the delete was performed - if it completed before the create command then everything was fine. If it didn't then the error would appear. Passing the overwrite param to the saved object client eliminates the possibility of the delete failing to complete.

Closes #161016

…into fix_data_view_overwrite

elasticmachine · 2023-07-01T15:41:26Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta · 2023-07-03T07:23:58Z

src/plugins/data_views/common/data_views/data_views.ts

    const response: SavedObject<DataViewAttributes> = (await this.savedObjectsClient.create(body, {
      id: dataView.id,
      initialNamespaces: dataView.namespaces.length > 0 ? dataView.namespaces : undefined,
+      overwrite: override,


Would it be possible to consistently use overwrite or override?

…into fix_data_view_overwrite

kibana-ci · 2023-07-03T17:27:07Z

💚 Build Succeeded

Buildkite Build
Commit: 4926c9e

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`data`	2579	2583	+4
`dataViews`	258	268	+10
total			+14

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dataViews`	44.6KB	44.7KB	+12.0B

Unknown metric groups

API count

id	before	after	diff
`dataViews`	1048	1051	+3

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	14	16	+2
`securitySolution`	411	415	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	15	17	+2
`securitySolution`	490	494	+4
total			+6

History

💚 Build #139673 succeeded 2ff931a
💚 Build #139644 succeeded 534f197
💔 Build #139565 failed 852c9a4
💔 Build #139533 failed fa260a3
💔 Build #139460 failed c2ec8d4
💔 Build #139296 failed 3fc8c3b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

jughosta

LGTM 👍

test/api_integration/apis/data_views/fields_api/update_fields/main.ts

## Summary Under some circumstances passing `override` to `POST /api/data_views/data_view` would fail. Its now fixed. To test - Try using the override param from the Kibana dev console. I found it reproduced the problem before the fix and shows its resolved after the fix. The problem did not appear in the integration tests. I suspect the problem had to do with how quickly the delete was performed - if it completed before the create command then everything was fine. If it didn't then the error would appear. Passing the overwrite param to the saved object client eliminates the possibility of the delete failing to complete. Closes elastic#161016 (cherry picked from commit 803d139)

kibanamachine · 2023-07-04T20:41:37Z

💔 Some backports could not be created

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts
✅	8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 160953

Questions ?

Please refer to the Backport tool documentation

* main: (354 commits) [Synthetics] Overview page fix last refresh value display (elastic#161086) [Synthetics] Remove TLS alert option for ICMP monitor (elastic#161173) fixing the path of manifets for hints autodiscover (elastic#161075) [Fleet] Fix permissions in integrations Assets page (elastic#161233) Update publicBaseUrl warning id (elastic#161204) [ML] Fix Anomaly Explorer URL for alerting context with non-default space (elastic#160899) [Enterprise Search]Add 404 error handling for mappings and documents endpoints (elastic#161203) [Logs Shared] Move LogStream and LogView into new shared plugin (elastic#161151) [Security Solutions] Fix CellActions component should hide ShowTopN action for nested fields (elastic#159645) [SecuritySolutions] Remove filter actions from Cases alerts table and fix show_top_n action (elastic#161150) [Infrastructure UI] Add strict payload validation to inventory_views endpoint (elastic#160852) [api-docs] 2023-07-05 Daily api_docs build (elastic#161225) Fix errors in custom metric payload in SLO dev docs (elastic#161141) [data views] Fix overwrite param for create (elastic#160953) [Synthetics] Perform params API HTTP migration (elastic#160575) [Cloud Security][FTR]Refactor API FTR to use .to.eql instead of .to.be (elastic#160694) Have SLO routes return a 403 instead of a 400 when user has an insufficient license (elastic#161193) [Discover] Fix shared links flaky test (elastic#161172) [ftr] Improve FTR error handling for NoSuchSessionError (elastic#161025) skip flaky suite (elastic#151981) ...

kibanamachine · 2024-05-06T21:48:57Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2024-08-15T21:48:55Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 160953 locally

pass overwrite to saved object client

6b0636e

mattkime changed the title ~~pass overwrite to saved object client~~ [data views] Fix overwrite param for create Jun 30, 2023

mattkime self-assigned this Jun 30, 2023

mattkime added 7 commits June 29, 2023 21:26

add schema for overwrite

820a6cd

supply override

3fc8c3b

Merge branch 'main' into fix_data_view_overwrite

c2ec8d4

restore delete on dupe name

2123867

Merge branch 'fix_data_view_overwrite' of github.com:mattkime/kibana …

fa260a3

…into fix_data_view_overwrite

Merge branch 'main' into fix_data_view_overwrite

852c9a4

Merge branch 'main' into fix_data_view_overwrite

534f197

mattkime marked this pull request as ready for review July 1, 2023 15:41

mattkime requested a review from a team as a code owner July 1, 2023 15:41

Merge branch 'main' into fix_data_view_overwrite

2ff931a

jughosta reviewed Jul 3, 2023

View reviewed changes

mattkime added 3 commits July 3, 2023 11:14

Merge branch 'main' into fix_data_view_overwrite

36c4911

overwrite instead of override

425377b

Merge branch 'fix_data_view_overwrite' of github.com:mattkime/kibana …

4926c9e

…into fix_data_view_overwrite

jughosta approved these changes Jul 4, 2023

View reviewed changes

kertal reviewed Jul 4, 2023

View reviewed changes

test/api_integration/apis/data_views/fields_api/update_fields/main.ts Show resolved Hide resolved

mattkime merged commit 803d139 into elastic:main Jul 4, 2023

kibanamachine added the v8.10.0 label Jul 4, 2023

kibanamachine mentioned this pull request Jul 4, 2023

[8.9] [data views] Fix overwrite param for create (#160953) #161219

Closed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 6, 2024

mattkime added the backport:skip This PR does not require backporting label Aug 15, 2024

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 15, 2024

mattkime removed the backport:all-open Backport to all branches that could still receive a release label Aug 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[data views] Fix overwrite param for create#160953

[data views] Fix overwrite param for create#160953
mattkime merged 12 commits intoelastic:mainfrom
mattkime:fix_data_view_overwrite

mattkime commented Jun 30, 2023 •

edited by kibanamachine

Loading

Uh oh!

elasticmachine commented Jul 1, 2023

Uh oh!

jughosta Jul 3, 2023

Uh oh!

kibana-ci commented Jul 3, 2023

API count

ESLint disabled line counts

Total ESLint disabled count

Uh oh!

jughosta left a comment

Uh oh!

Uh oh!

kibanamachine commented Jul 4, 2023

Uh oh!

kibanamachine commented May 6, 2024

Uh oh!

kibanamachine commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mattkime commented Jun 30, 2023 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Jul 1, 2023

Uh oh!

jughosta Jul 3, 2023

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jul 3, 2023

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

jughosta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Jul 4, 2023

💔 Some backports could not be created

Manual backport

Questions ?

Uh oh!

kibanamachine commented May 6, 2024

Uh oh!

kibanamachine commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mattkime commented Jun 30, 2023 •

edited by kibanamachine

Loading