Skip to content

[Fleet] Fix permissions in integrations Assets page#161233

Merged
criamico merged 1 commit intoelastic:mainfrom
criamico:fix_assets_permissions
Jul 5, 2023
Merged

[Fleet] Fix permissions in integrations Assets page#161233
criamico merged 1 commit intoelastic:mainfrom
criamico:fix_assets_permissions

Conversation

@criamico
Copy link
Copy Markdown
Member

@criamico criamico commented Jul 5, 2023 •
edited by kibanamachine
Loading

Fixes #161058

Summary

Fix permissions for Integrations assets tab. A user with role "Fleet All - Integration Read" wasn't able to visualize the assets tab.

Test

  • Create a user with "Fleet All - Integration Read" as shown in this video:
250448262-047702a9-e8d3-4639-ab15-13bb3048ec61.mp4
  • Log in with this new user
  • Navigate to any installed integration, then to the Assets tab
  • Verify that the assets are shown as usual (no warnings are shown)
Screenshot 2023-07-05 at 10 22 36

@criamico criamico added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor v8.10.0 labels Jul 5, 2023
@criamico criamico self-assigned this Jul 5, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jul 5, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico marked this pull request as ready for review July 5, 2023 08:25
@criamico criamico requested a review from a team as a code owner July 5, 2023 08:25
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 5, 2023

Pinging @elastic/fleet (Team:Fleet)

@criamico criamico enabled auto-merge (squash) July 5, 2023 09:03
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 5, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 975.2KB 975.1KB -4.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit 38b487a into elastic:main Jul 5, 2023
@kibanamachine kibanamachine mentioned this pull request Jul 5, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 5, 2023
@criamico
[Fleet] Fix permissions in integrations Assets page (elastic#161233)
ef9a3a3 
Fixes elastic#161058

## Summary
Fix permissions for Integrations assets tab. A user with role "Fleet All
- Integration Read" wasn't able to visualize the assets tab.

### Test

- Create a user with "Fleet All - Integration Read" as shown in this
video:

https://github.com/elastic/kibana/assets/16084106/a13c6ddd-a3d1-4e15-9c9d-9d56e1dbb0f0

- Log in with this new user
- Navigate to any installed integration, then to the Assets tab
- Verify that the assets are shown as usual (no warnings are shown)

<img width="2556" alt="Screenshot 2023-07-05 at 10 22 36"
src="https://github.com/elastic/kibana/assets/16084106/b050d7ee-3794-41c4-b429-50eb6291697a">

(cherry picked from commit 38b487a)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 5, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 5, 2023
@kibanamachine @criamico
[8.9] [Fleet] Fix permissions in integrations Assets page (#161233) (#…
1428940 
…161236)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Fleet] Fix permissions in integrations Assets page
(#161233)](#161233)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cristina
Amico","email":"criamico@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-07-05T09:27:54Z","message":"[Fleet]
Fix permissions in integrations Assets page (#161233)\n\nFixes
https://github.com/elastic/kibana/issues/161058\r\n\r\n## Summary\r\nFix
permissions for Integrations assets tab. A user with role \"Fleet
All\r\n- Integration Read\" wasn't able to visualize the assets
tab.\r\n\r\n### Test\r\n\r\n- Create a user with \"Fleet All -
Integration Read\" as shown in
this\r\nvideo:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/16084106/a13c6ddd-a3d1-4e15-9c9d-9d56e1dbb0f0\r\n\r\n-
Log in with this new user\r\n- Navigate to any installed integration,
then to the Assets tab\r\n- Verify that the assets are shown as usual
(no warnings are shown)\r\n\r\n<img width=\"2556\" alt=\"Screenshot
2023-07-05 at 10 22
36\"\r\nsrc=\"https://github.com/elastic/kibana/assets/16084106/b050d7ee-3794-41c4-b429-50eb6291697a\">","sha":"38b487a879ba12a2a6b37930fd05d60aa3c7ae10","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.10.0"],"number":161233,"url":"https://github.com/elastic/kibana/pull/161233","mergeCommit":{"message":"[Fleet]
Fix permissions in integrations Assets page (#161233)\n\nFixes
https://github.com/elastic/kibana/issues/161058\r\n\r\n## Summary\r\nFix
permissions for Integrations assets tab. A user with role \"Fleet
All\r\n- Integration Read\" wasn't able to visualize the assets
tab.\r\n\r\n### Test\r\n\r\n- Create a user with \"Fleet All -
Integration Read\" as shown in
this\r\nvideo:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/16084106/a13c6ddd-a3d1-4e15-9c9d-9d56e1dbb0f0\r\n\r\n-
Log in with this new user\r\n- Navigate to any installed integration,
then to the Assets tab\r\n- Verify that the assets are shown as usual
(no warnings are shown)\r\n\r\n<img width=\"2556\" alt=\"Screenshot
2023-07-05 at 10 22
36\"\r\nsrc=\"https://github.com/elastic/kibana/assets/16084106/b050d7ee-3794-41c4-b429-50eb6291697a\">","sha":"38b487a879ba12a2a6b37930fd05d60aa3c7ae10"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161233","number":161233,"mergeCommit":{"message":"[Fleet]
Fix permissions in integrations Assets page (#161233)\n\nFixes
https://github.com/elastic/kibana/issues/161058\r\n\r\n## Summary\r\nFix
permissions for Integrations assets tab. A user with role \"Fleet
All\r\n- Integration Read\" wasn't able to visualize the assets
tab.\r\n\r\n### Test\r\n\r\n- Create a user with \"Fleet All -
Integration Read\" as shown in
this\r\nvideo:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/16084106/a13c6ddd-a3d1-4e15-9c9d-9d56e1dbb0f0\r\n\r\n-
Log in with this new user\r\n- Navigate to any installed integration,
then to the Assets tab\r\n- Verify that the assets are shown as usual
(no warnings are shown)\r\n\r\n<img width=\"2556\" alt=\"Screenshot
2023-07-05 at 10 22
36\"\r\nsrc=\"https://github.com/elastic/kibana/assets/16084106/b050d7ee-3794-41c4-b429-50eb6291697a\">","sha":"38b487a879ba12a2a6b37930fd05d60aa3c7ae10"}}]}]
BACKPORT-->

Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 5, 2023
@jloleysens
Merge branch 'main' into additional-validation-mechanism
cfd7b70 
* main: (354 commits)
  [Synthetics] Overview page fix last refresh value display (elastic#161086)
  [Synthetics] Remove TLS alert option for ICMP monitor (elastic#161173)
  fixing the path of manifets for hints autodiscover (elastic#161075)
  [Fleet] Fix permissions in integrations Assets page (elastic#161233)
  Update publicBaseUrl warning id (elastic#161204)
  [ML] Fix Anomaly Explorer URL for alerting context with non-default space  (elastic#160899)
  [Enterprise Search]Add 404 error handling for mappings and documents endpoints (elastic#161203)
  [Logs Shared] Move LogStream and LogView into new shared plugin (elastic#161151)
  [Security Solutions] Fix  CellActions component should hide ShowTopN action for nested fields (elastic#159645)
  [SecuritySolutions] Remove filter actions from Cases alerts table and fix show_top_n action (elastic#161150)
  [Infrastructure UI] Add strict payload validation to inventory_views endpoint (elastic#160852)
  [api-docs] 2023-07-05 Daily api_docs build (elastic#161225)
  Fix errors in custom metric payload in SLO dev docs (elastic#161141)
  [data views] Fix overwrite param for create (elastic#160953)
  [Synthetics] Perform params API HTTP migration (elastic#160575)
  [Cloud Security][FTR]Refactor API FTR to use .to.eql instead of .to.be  (elastic#160694)
  Have SLO routes return a 403 instead of a 400 when user has an insufficient license (elastic#161193)
  [Discover] Fix shared links flaky test (elastic#161172)
  [ftr] Improve FTR error handling for NoSuchSessionError (elastic#161025)
  skip flaky suite (elastic#151981)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 5, 2023
@jloleysens
Merge branch 'main' into more-response-validation-tests
7d26fcf 
* main: (354 commits)
  [Synthetics] Overview page fix last refresh value display (elastic#161086)
  [Synthetics] Remove TLS alert option for ICMP monitor (elastic#161173)
  fixing the path of manifets for hints autodiscover (elastic#161075)
  [Fleet] Fix permissions in integrations Assets page (elastic#161233)
  Update publicBaseUrl warning id (elastic#161204)
  [ML] Fix Anomaly Explorer URL for alerting context with non-default space  (elastic#160899)
  [Enterprise Search]Add 404 error handling for mappings and documents endpoints (elastic#161203)
  [Logs Shared] Move LogStream and LogView into new shared plugin (elastic#161151)
  [Security Solutions] Fix  CellActions component should hide ShowTopN action for nested fields (elastic#159645)
  [SecuritySolutions] Remove filter actions from Cases alerts table and fix show_top_n action (elastic#161150)
  [Infrastructure UI] Add strict payload validation to inventory_views endpoint (elastic#160852)
  [api-docs] 2023-07-05 Daily api_docs build (elastic#161225)
  Fix errors in custom metric payload in SLO dev docs (elastic#161141)
  [data views] Fix overwrite param for create (elastic#160953)
  [Synthetics] Perform params API HTTP migration (elastic#160575)
  [Cloud Security][FTR]Refactor API FTR to use .to.eql instead of .to.be  (elastic#160694)
  Have SLO routes return a 403 instead of a 400 when user has an insufficient license (elastic#161193)
  [Discover] Fix shared links flaky test (elastic#161172)
  [ftr] Improve FTR error handling for NoSuchSessionError (elastic#161025)
  skip flaky suite (elastic#151981)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlind23 jlind23 jlind23 approved these changes

Assignees

@criamico criamico

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.9.0 v8.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Fleet]: Unable to view integration Assets when logged in as User with role: Fleet-All, Integrations-Read and Saved Objects Management- Read.

5 participants

@criamico @elasticmachine @kibana-ci @kibanamachine @jlind23