Skip to content

[Synthetics] Remove TLS alert option for ICMP monitor#161173

Merged
shahzad31 merged 1 commit intoelastic:mainfrom
shahzad31:icmp-tls
Jul 5, 2023
Merged

[Synthetics] Remove TLS alert option for ICMP monitor#161173
shahzad31 merged 1 commit intoelastic:mainfrom
shahzad31:icmp-tls

Conversation

@shahzad31
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 commented Jul 4, 2023 •
edited by kibanamachine
Loading

Summary

Fixes #161100

Removed TLS alert option for ICMP monitor

Also

  • Updated TLS key migration to only apply to tcp and http monitor
  • Update tls alert query as same

@ghost
Copy link
Copy Markdown

ghost commented Jul 4, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 marked this pull request as ready for review July 4, 2023 15:14
@shahzad31 shahzad31 requested a review from a team as a code owner July 4, 2023 15:14
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 v8.10.0 labels Jul 4, 2023
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 4, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 4, 2023

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 4, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 907.3KB 907.3KB +12.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

History

  • 💛 Build #140009 was flaky 7ca0f9ca8010fef347e1c12fab46fd8817f09e82

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

awahab07
awahab07 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahzad31 shahzad31 merged commit 6a84ea1 into elastic:main Jul 5, 2023
@shahzad31 shahzad31 deleted the icmp-tls branch July 5, 2023 09:55
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 5, 2023

💔 All backports failed

Status Branch Result
❌ 8.9 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 161173

Questions ?

Please refer to the Backport tool documentation

@shahzad31 shahzad31 mentioned this pull request Jul 5, 2023
Merged
@shahzad31
Copy link
Copy Markdown
Contributor Author

shahzad31 commented Jul 5, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jul 5, 2023
@shahzad31
[Synthetics] Remove TLS alert option for ICMP monitor (elastic#161173)
0db4ec5 
(cherry picked from commit 6a84ea1)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 5, 2023
@jloleysens
Merge branch 'main' into additional-validation-mechanism
cfd7b70 
* main: (354 commits)
  [Synthetics] Overview page fix last refresh value display (elastic#161086)
  [Synthetics] Remove TLS alert option for ICMP monitor (elastic#161173)
  fixing the path of manifets for hints autodiscover (elastic#161075)
  [Fleet] Fix permissions in integrations Assets page (elastic#161233)
  Update publicBaseUrl warning id (elastic#161204)
  [ML] Fix Anomaly Explorer URL for alerting context with non-default space  (elastic#160899)
  [Enterprise Search]Add 404 error handling for mappings and documents endpoints (elastic#161203)
  [Logs Shared] Move LogStream and LogView into new shared plugin (elastic#161151)
  [Security Solutions] Fix  CellActions component should hide ShowTopN action for nested fields (elastic#159645)
  [SecuritySolutions] Remove filter actions from Cases alerts table and fix show_top_n action (elastic#161150)
  [Infrastructure UI] Add strict payload validation to inventory_views endpoint (elastic#160852)
  [api-docs] 2023-07-05 Daily api_docs build (elastic#161225)
  Fix errors in custom metric payload in SLO dev docs (elastic#161141)
  [data views] Fix overwrite param for create (elastic#160953)
  [Synthetics] Perform params API HTTP migration (elastic#160575)
  [Cloud Security][FTR]Refactor API FTR to use .to.eql instead of .to.be  (elastic#160694)
  Have SLO routes return a 403 instead of a 400 when user has an insufficient license (elastic#161193)
  [Discover] Fix shared links flaky test (elastic#161172)
  [ftr] Improve FTR error handling for NoSuchSessionError (elastic#161025)
  skip flaky suite (elastic#151981)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 5, 2023
@jloleysens
Merge branch 'main' into more-response-validation-tests
7d26fcf 
* main: (354 commits)
  [Synthetics] Overview page fix last refresh value display (elastic#161086)
  [Synthetics] Remove TLS alert option for ICMP monitor (elastic#161173)
  fixing the path of manifets for hints autodiscover (elastic#161075)
  [Fleet] Fix permissions in integrations Assets page (elastic#161233)
  Update publicBaseUrl warning id (elastic#161204)
  [ML] Fix Anomaly Explorer URL for alerting context with non-default space  (elastic#160899)
  [Enterprise Search]Add 404 error handling for mappings and documents endpoints (elastic#161203)
  [Logs Shared] Move LogStream and LogView into new shared plugin (elastic#161151)
  [Security Solutions] Fix  CellActions component should hide ShowTopN action for nested fields (elastic#159645)
  [SecuritySolutions] Remove filter actions from Cases alerts table and fix show_top_n action (elastic#161150)
  [Infrastructure UI] Add strict payload validation to inventory_views endpoint (elastic#160852)
  [api-docs] 2023-07-05 Daily api_docs build (elastic#161225)
  Fix errors in custom metric payload in SLO dev docs (elastic#161141)
  [data views] Fix overwrite param for create (elastic#160953)
  [Synthetics] Perform params API HTTP migration (elastic#160575)
  [Cloud Security][FTR]Refactor API FTR to use .to.eql instead of .to.be  (elastic#160694)
  Have SLO routes return a 403 instead of a 400 when user has an insufficient license (elastic#161193)
  [Discover] Fix shared links flaky test (elastic#161172)
  [ftr] Improve FTR error handling for NoSuchSessionError (elastic#161025)
  skip flaky suite (elastic#151981)
  ...
shahzad31 added a commit that referenced this pull request Jul 6, 2023
@shahzad31
[8.9] [Synthetics] Remove TLS alert option for ICMP monitor (#161173) (…
9ee8cd6 
…#161245)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Synthetics] Remove TLS alert option for ICMP monitor
(#161173)](#161173)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-07-05T09:55:38Z","message":"[Synthetics]
Remove TLS alert option for ICMP monitor
(#161173)","sha":"6a84ea186b664b55c19a9465b2ea80ddd29c6ffd","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.9.0","v8.10.0"],"number":161173,"url":"https://github.com/elastic/kibana/pull/161173","mergeCommit":{"message":"[Synthetics]
Remove TLS alert option for ICMP monitor
(#161173)","sha":"6a84ea186b664b55c19a9465b2ea80ddd29c6ffd"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161173","number":161173,"mergeCommit":{"message":"[Synthetics]
Remove TLS alert option for ICMP monitor
(#161173)","sha":"6a84ea186b664b55c19a9465b2ea80ddd29c6ffd"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0 v8.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Synthetics] TLS cert alert toggle shouldn’t be there for ICMP monitors

5 participants

@shahzad31 @elasticmachine @kibana-ci @kibanamachine @awahab07