[Lens] Automatically unlink cloned library annotation group layers (#161130)

Author: drewdaemon

x-pack/plugins/lens/public/visualizations/xy/visualization.test.tsx

@@ -50,7 +50,11 @@ import { unifiedSearchPluginMock } from '@kbn/unified-search-plugin/public/mocks
 import { layerTypes, Visualization } from '../..';
 import { set } from '@kbn/safer-lodash-set';
 import { SavedObjectReference } from '@kbn/core-saved-objects-api-server';
-import { getAnnotationsLayers } from './visualization_helpers';
+import {
+  getAnnotationsLayers,
+  isAnnotationsLayer,
+  isByReferenceAnnotationsLayer,
+} from './visualization_helpers';
 import { cloneDeep } from 'lodash';
 import { DataViewsServicePublic } from '@kbn/data-views-plugin/public';
 
@@ -3240,6 +3244,59 @@ describe('xy_visualization', () => {
     });
   });
 
+  describe('#cloneLayer', () => {
+    it('should turned cloned by-reference annotation groups into by-value', () => {
+      const state = exampleState();
+      const layer: XYByValueAnnotationLayerConfig = {
+        layerId: 'layer-id',
+        layerType: 'annotations',
+        indexPatternId: 'some-index-pattern',
+        ignoreGlobalFilters: false,
+        annotations: [
+          {
+            id: 'some-annotation-id',
+            type: 'manual',
+            key: {
+              type: 'point_in_time',
+              timestamp: 'timestamp',
+            },
+          } as PointInTimeEventAnnotationConfig,
+        ],
+      };
+
+      state.layers = [
+        {
+          ...layer,
+          annotationGroupId: 'some-group-id',
+          __lastSaved: {
+            ...layer,
+            title: '',
+            description: '',
+            tags: [],
+          },
+        },
+      ];
+
+      const newLayerId = 'new-layer-id';
+
+      const stateWithClonedLayer = xyVisualization.cloneLayer!(
+        state,
+        layer.layerId,
+        newLayerId,
+        new Map()
+      );
+
+      expect(
+        isAnnotationsLayer(stateWithClonedLayer.layers[0]) &&
+          isByReferenceAnnotationsLayer(stateWithClonedLayer.layers[0])
+      ).toBe(true);
+      expect(
+        isAnnotationsLayer(stateWithClonedLayer.layers[1]) &&
+          isByReferenceAnnotationsLayer(stateWithClonedLayer.layers[1])
+      ).toBe(false);
+    });
+  });
+
   describe('#getUniqueLabels', () => {
     it('creates unique labels for single annotations layer with repeating labels', async () => {
       const annotationLayer: XYAnnotationLayerConfig = {

x-pack/plugins/lens/public/visualizations/xy/visualization.tsx

@@ -106,7 +106,7 @@ import {
   validateLayersForDimension,
 } from './visualization_helpers';
 import { groupAxesByType } from './axes_configuration';
-import type { XYState } from './types';
+import type { XYByValueAnnotationLayerConfig, XYState } from './types';
 import { ReferenceLinePanel } from './xy_config_panel/reference_line_config_panel';
 import { AnnotationsPanel } from './xy_config_panel/annotations_config_panel';
 import { defaultAnnotationLabel } from './annotations/helpers';
@@ -174,10 +174,25 @@ export const getXyVisualization = ({
       if (isAnnotationsLayer(toCopyLayer)) {
         toCopyLayer.annotations.forEach((i) => clonedIDsMap.set(i.id, generateId()));
       }
-      const newLayer = renewIDs(toCopyLayer, [...clonedIDsMap.keys()], (id: string) =>
+
+      let newLayer = renewIDs(toCopyLayer, [...clonedIDsMap.keys()], (id: string) =>
         clonedIDsMap.get(id)
       );
+
       newLayer.layerId = newLayerId;
+
+      if (isAnnotationsLayer(newLayer) && isByReferenceAnnotationsLayer(newLayer)) {
+        const byValueVersion: XYByValueAnnotationLayerConfig = {
+          annotations: newLayer.annotations,
+          ignoreGlobalFilters: newLayer.ignoreGlobalFilters,
+          layerId: newLayer.layerId,
+          layerType: newLayer.layerType,
+          indexPatternId: newLayer.indexPatternId,
+        };
+
+        newLayer = byValueVersion;
+      }
+
       return {
         ...state,
         layers: [...state.layers, newLayer],