Merged
Conversation
tkajtoch
added
release_note:skip
tkajtoch
force-pushed
the
eui-v80.0
branch
2 times, most recently
from
a4cb95a to
5f3f79f
Compare
Contributor
|
Pinging @elastic/eui-team (EUI) |
cee-chen
reviewed
May 17, 2023
| onChange={this._onLatChange} | ||
| isInvalid={isLatInvalid} | ||
| data-test-subj="latitudeInput" | ||
| step="any" // Browsers will validate decimals as invalid otherwise |
Contributor
There was a problem hiding this comment.
For context for this reversion, EuiFieldNumber now defaults to step="any", so all decimal number inputs will no longer have invalid states (although you're still of course free to pass in your own custom step interval, e.g. step={0.5}
jbudz
approved these changes
May 17, 2023
nreese
approved these changes
May 17, 2023
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-gis changes LGTM
code review only
Member
Author
|
@elasticmachine merge upstream |
peteharverson
approved these changes
May 18, 2023
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
ML functional test change LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @tkajtoch |
yctercero
approved these changes
May 18, 2023
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
## Summary `@elastic/eui@79.0.1` ⏩ `@elastic/eui@80.0.0` --- ## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0) - Improved the contrast ratio of meta labels within `EuiSelectableTemplateSitewide` to meet WCAG AA guidelines. ([elastic#6761](elastic/eui#6761)) - Added `vulnerabilityManagementApp` glyph to `EuiIcon` ([elastic#6762](elastic/eui#6762)) - Added `logoVulnerabilityManagement` icon to `EuiIcon` ([elastic#6763](elastic/eui#6763)) - Added `onPanelChange` callback to `EuiContextMenu` to provide consumer access to `panelId` and `direction`. ([elastic#6767](elastic/eui#6767)) **Bug fixes** - Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full height and vertically centered. ([elastic#6766](elastic/eui#6766)) - Improved the uniformity of dropdown components by hiding the dropdown icon of disabled `EuiComboBox`s. ([elastic#6768](elastic/eui#6768)) **Breaking changes** - `EuiFieldNumber` now defaults the `step` prop to `"any"` ([elastic#6760](elastic/eui#6760)) - EUI now globally resets a default Chromium browser style that was decreasing the opacity of disabled `select` items. ([elastic#6768](elastic/eui#6768)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@elastic/eui@79.0.1⏩@elastic/eui@80.0.080.0.0EuiSelectableTemplateSitewideto meet WCAG AA guidelines. (#6761)vulnerabilityManagementAppglyph toEuiIcon(#6762)logoVulnerabilityManagementicon toEuiIcon(#6763)onPanelChangecallback toEuiContextMenuto provide consumer access topanelIdanddirection. (#6767)Bug fixes
EuiComboBoxsoappendandprependicon buttons are full height and vertically centered. (#6766)EuiComboBoxs. (#6768)Breaking changes
EuiFieldNumbernow defaults thestepprop to"any"(#6760)selectitems. (#6768)