Skip to content

Upgrade EUI to v80.0.0 #157939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkajtoch merged 5 commits into from
May 18, 2023
Merged

Upgrade EUI to v80.0.0 #157939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
130acff
Upgrade EUI to v80.0.0
tkajtoch May 16, 2023
3d60af6
Update FieldComponent snapshots to address EuiComboBox disabled state…
tkajtoch May 17, 2023
14c9ba7
Fix read ML access tests using the invalid 'comboBoxToggleListButton'…
tkajtoch May 17, 2023
91b1c13
Revert Fix maps location decimal degrees showing invalid state for de…
tkajtoch May 17, 2023
3e61f21
Merge branch 'main' into eui-v80.0
kibanamachine May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"@elastic/datemath": "5.0.3",
"@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@8.6.0-canary.3",
"@elastic/ems-client": "8.4.0",
"@elastic/eui": "79.0.1",
"@elastic/eui": "80.0.0",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "1.2.1",
"@elastic/numeral": "^2.5.1",
Expand Down
64 changes: 0 additions & 64 deletions ...s/kbn-securitysolution-autocomplete/src/field/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/dev/license_checker/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,6 @@ export const LICENSE_OVERRIDES = {
'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts
'@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint
'@elastic/ems-client@8.4.0': ['Elastic License 2.0'],
'@elastic/eui@79.0.1': ['SSPL-1.0 OR Elastic License 2.0'],
'@elastic/eui@80.0.0': ['SSPL-1.0 OR Elastic License 2.0'],
'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry
};
3 changes: 0 additions & 3 deletions ...aps/public/connected_components/toolbar_overlay/set_view_control/decimal_degrees_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ export class DecimalDegreesForm extends Component<Props, State> {
onChange={this._onLatChange}
isInvalid={isLatInvalid}
data-test-subj="latitudeInput"
step="any" // Browsers will validate decimals as invalid otherwise
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context for this reversion, EuiFieldNumber now defaults to step="any", so all decimal number inputs will no longer have invalid states (although you're still of course free to pass in your own custom step interval, e.g. step={0.5}

/>
</EuiFormRow>

Expand All @@ -108,7 +107,6 @@ export class DecimalDegreesForm extends Component<Props, State> {
onChange={this._onLonChange}
isInvalid={isLonInvalid}
data-test-subj="longitudeInput"
step="any" // Browsers will validate decimals as invalid otherwise
/>
</EuiFormRow>

Expand All @@ -126,7 +124,6 @@ export class DecimalDegreesForm extends Component<Props, State> {
onChange={this._onZoomChange}
isInvalid={isZoomInvalid}
data-test-subj="zoomInput"
step="any" // Browsers will validate decimals as invalid otherwise
/>
</EuiFormRow>

Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional/services/ml/settings_calendar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export function MachineLearningSettingsCalendarProvider(

async assertJobSelectionEnabled(expectedValue: boolean) {
const isEnabled = await testSubjects.isEnabled(
'mlCalendarJobSelection > comboBoxToggleListButton'
'mlCalendarJobSelection > comboBoxSearchInput'
);
expect(isEnabled).to.eql(
expectedValue,
Expand All @@ -159,7 +159,7 @@ export function MachineLearningSettingsCalendarProvider(

async assertJobGroupSelectionEnabled(expectedValue: boolean) {
const isEnabled = await testSubjects.isEnabled(
'mlCalendarJobGroupSelection > comboBoxToggleListButton'
'mlCalendarJobGroupSelection > comboBoxSearchInput'
);
expect(isEnabled).to.eql(
expectedValue,
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1543,10 +1543,10 @@
resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314"
integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ==

"@elastic/eui@79.0.1":
version "79.0.1"
resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-79.0.1.tgz#bb723c961f438df41f5b92292b59c204cd795558"
integrity sha512-xCB8a2DaiAIg1qsFgegmXT5niKhL6LKqhD0fCc1ut+BZDPq4XvqagwOdmYRvP9IpYDcS6sP+F89JVF0kaQsXXw==
"@elastic/eui@80.0.0":
version "80.0.0"
resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-80.0.0.tgz#33e1df8a3f193fb6a7a4f7e52a3028983856ba3a"
integrity sha512-0xWizIQ/kH9N2n9zOficqXPdRbVxCpHez2ZErnvISAEOneJ6401usI7fILGKrrvR+uyiYnNybfaP3H8HcgDa+g==
dependencies:
"@types/chroma-js" "^2.0.0"
"@types/lodash" "^4.14.160"
Expand Down