[EuiComboBox] Remove dropdown arrow when disabled; [EuiSelect] Remove Chrome opacity when disabled#6768
Merged
breehall merged 7 commits intoelastic:mainfrom May 12, 2023
Merged
Conversation
…n icon to be displayed if the form control is disabled.
breehall
commented
May 10, 2023
...cker/super_date_picker/quick_select_popover/__snapshots__/quick_select_popover.test.tsx.snap
Outdated
Show resolved
Hide resolved
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6768/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6768/ |
cee-chen
suggested changes
May 11, 2023
Contributor
There was a problem hiding this comment.
Rather than only fixing this for EuiSelect, we should be standardizing behavior across all components with dropdown icons. The list of these components are:
- EuiComboBox
- EuiSelect
- EuiSuperSelect
- EuiColorPicker
Based on the fact that Caroline made the decision fairly recently - last year- to hide the arrow for disabled components - I don't think the resolution here is to show the arrow, I think it's to hide it for the 1 outlier, EuiComboBox. The UX decision makes sense to me honestly - a dropdown arrow indicates interactivity, usually, so hiding it when disabled will lead fewer people to try and click on it.
The linked issue also notes the disabled border colors are different on EuiComboBox, that's also something that needs to be fixed.
… dropdown icon to be displayed if the form control is disabled." This reverts commit d7cb27a. Revert changes made to EuiSelect
…moving the dropdown icon when EuiComboBox is disabled.
…y to 1 when the select is disabled. Chrome applies an opinionated override that lowers the opacity
breehall
force-pushed
the
select/disabled-icon
branch
from
22336a7 to
7b5a9c1
Compare
cee-chen
reviewed
May 11, 2023
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Woohoo - this feels much cleaner all around :) I think my only comments are around the changelog and how we categorize these changes - lmk what you think!
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
breehall
added
the
breaking change
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6768/ |
cee-chen
approved these changes
May 12, 2023
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Fantastic! Thanks for this work Bree!
cee-chen
changed the title
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
May 18, 2023
## Summary `@elastic/eui@79.0.1` ⏩ `@elastic/eui@80.0.0` --- ## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0) - Improved the contrast ratio of meta labels within `EuiSelectableTemplateSitewide` to meet WCAG AA guidelines. ([#6761](elastic/eui#6761)) - Added `vulnerabilityManagementApp` glyph to `EuiIcon` ([#6762](elastic/eui#6762)) - Added `logoVulnerabilityManagement` icon to `EuiIcon` ([#6763](elastic/eui#6763)) - Added `onPanelChange` callback to `EuiContextMenu` to provide consumer access to `panelId` and `direction`. ([#6767](elastic/eui#6767)) **Bug fixes** - Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full height and vertically centered. ([#6766](elastic/eui#6766)) - Improved the uniformity of dropdown components by hiding the dropdown icon of disabled `EuiComboBox`s. ([#6768](elastic/eui#6768)) **Breaking changes** - `EuiFieldNumber` now defaults the `step` prop to `"any"` ([#6760](elastic/eui#6760)) - EUI now globally resets a default Chromium browser style that was decreasing the opacity of disabled `select` items. ([#6768](elastic/eui#6768)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
## Summary `@elastic/eui@79.0.1` ⏩ `@elastic/eui@80.0.0` --- ## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0) - Improved the contrast ratio of meta labels within `EuiSelectableTemplateSitewide` to meet WCAG AA guidelines. ([elastic#6761](elastic/eui#6761)) - Added `vulnerabilityManagementApp` glyph to `EuiIcon` ([elastic#6762](elastic/eui#6762)) - Added `logoVulnerabilityManagement` icon to `EuiIcon` ([elastic#6763](elastic/eui#6763)) - Added `onPanelChange` callback to `EuiContextMenu` to provide consumer access to `panelId` and `direction`. ([elastic#6767](elastic/eui#6767)) **Bug fixes** - Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full height and vertically centered. ([elastic#6766](elastic/eui#6766)) - Improved the uniformity of dropdown components by hiding the dropdown icon of disabled `EuiComboBox`s. ([elastic#6768](elastic/eui#6768)) **Breaking changes** - `EuiFieldNumber` now defaults the `step` prop to `"any"` ([elastic#6760](elastic/eui#6760)) - EUI now globally resets a default Chromium browser style that was decreasing the opacity of disabled `select` items. ([elastic#6768](elastic/eui#6768)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6601
Summary
Increase uniformity of dropdown components by:
✅ Removing the dropdown icon for
EuiComboBoxwhen the component is disabled.✅ Updating the styling of
EuiSelectto match the visual likeness ofEuiComboBoxby applying a style override to ensure theopactiyis set to1when it's disabled.QA
EuiComboBoxexample in the PR Preview. When the select is disabled, we should not see the dropdown icon on the right hand side.EuiComboBoxandEuiSelectin dark mode and they should have the same border and appearance.General checklist