Fixes for the dark theme by panda01 · Pull Request #6767 · elastic/kibana

panda01 · 2016-04-04T19:11:09Z

Closes #6602.

…also made fixes to less to fix dark theme issues

rashidkpc · 2016-04-05T16:37:31Z

Button/placeholder alignment
Tab should join with body
Button isn't readable

rashidkpc · 2016-04-05T16:40:32Z

Rows should have alternating colors
Border around tabs is not consistent with the style of the rest of the application. Get rid of the border, use a different color for the body of the drop down and the tab content.

rashidkpc · 2016-04-05T16:49:53Z

Get rid of the bordered look on the panels,
See the color on the title bar? Use the same color for the body of the panel, and for the dashboard background.
Darken the buttons in the legend.

panda01 · 2016-04-05T16:56:40Z

@rashidkpc Hmm, I always thought it was just dashboard that had the dark theme. Perhaps i don't quite get what you mean.

rashidkpc · 2016-04-05T16:58:13Z

Ignore me, I'm being dumb, except on the comments with a screenshot :-) Stupid comment of stupidness deleted

panda01 · 2016-04-05T17:09:18Z

Hmm, well I thought of something similar, so, #6786.

…stent

panda01 · 2016-04-06T21:00:23Z

@rashidkpc addressed your concerns.

rashidkpc · 2016-04-07T17:45:36Z

@panda01 this largely looks good, although when you click one of the nav buttons they flash white on press. Fix that and go ahead and merge this

panda01 · 2016-04-07T18:42:09Z

Gotcha. Just fixed that, just want this build to pass even though it's CSS.

prashanttct07 · 2016-04-25T10:20:12Z

I am not able to switch dark/light theme in 5.0 alpha for the saved dashboard?

panda01 · 2016-04-25T12:32:36Z

I removed it accidentally, it's not in current 5.0
On Apr 25, 2016 06:20, "Prashant Agrawal" notifications@github.com wrote:

I am not able to find dark theme option in 5.0 alpha , where can I get
that option for Dashboard?

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#6767 (comment)

prashanttct07 · 2016-04-25T15:44:17Z

Oh oki , I think I already opened an issue for that so if no issue is opened already for that you can refer #7042

## Summary `@elastic/eui@79.0.1` ⏩ `@elastic/eui@80.0.0` --- ## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0) - Improved the contrast ratio of meta labels within `EuiSelectableTemplateSitewide` to meet WCAG AA guidelines. ([#6761](elastic/eui#6761)) - Added `vulnerabilityManagementApp` glyph to `EuiIcon` ([#6762](elastic/eui#6762)) - Added `logoVulnerabilityManagement` icon to `EuiIcon` ([#6763](elastic/eui#6763)) - Added `onPanelChange` callback to `EuiContextMenu` to provide consumer access to `panelId` and `direction`. ([#6767](elastic/eui#6767)) **Bug fixes** - Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full height and vertically centered. ([#6766](elastic/eui#6766)) - Improved the uniformity of dropdown components by hiding the dropdown icon of disabled `EuiComboBox`s. ([#6768](elastic/eui#6768)) **Breaking changes** - `EuiFieldNumber` now defaults the `step` prop to `"any"` ([#6760](elastic/eui#6760)) - EUI now globally resets a default Chromium browser style that was decreasing the opacity of disabled `select` items. ([#6768](elastic/eui#6768)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

## Summary `@elastic/eui@79.0.1` ⏩ `@elastic/eui@80.0.0` --- ## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0) - Improved the contrast ratio of meta labels within `EuiSelectableTemplateSitewide` to meet WCAG AA guidelines. ([elastic#6761](elastic/eui#6761)) - Added `vulnerabilityManagementApp` glyph to `EuiIcon` ([elastic#6762](elastic/eui#6762)) - Added `logoVulnerabilityManagement` icon to `EuiIcon` ([elastic#6763](elastic/eui#6763)) - Added `onPanelChange` callback to `EuiContextMenu` to provide consumer access to `panelId` and `direction`. ([elastic#6767](elastic/eui#6767)) **Bug fixes** - Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full height and vertically centered. ([elastic#6766](elastic/eui#6766)) - Improved the uniformity of dropdown components by hiding the dropdown icon of disabled `EuiComboBox`s. ([elastic#6768](elastic/eui#6768)) **Breaking changes** - `EuiFieldNumber` now defaults the `step` prop to `"any"` ([elastic#6760](elastic/eui#6760)) - EUI now globally resets a default Chromium browser style that was decreasing the opacity of disabled `select` items. ([elastic#6768](elastic/eui#6768)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[DarkTheme] Added back the options dropdown for toggling dark theme, …

3bd1758

…also made fixes to less to fix dark theme issues

panda01 self-assigned this Apr 4, 2016

panda01 added v5.0.0 bug Fixes for quality problems that affect the customer experience labels Apr 4, 2016

panda01 assigned rashidkpc and unassigned panda01 Apr 4, 2016

panda01 added the review label Apr 4, 2016

rashidkpc assigned panda01 and unassigned rashidkpc Apr 5, 2016

panda01 added 2 commits April 6, 2016 15:29

Merge remote-tracking branch 'upstream/master' into fix/darkTheme

6fda0d9

[DarkTheme] Fixing top nav colors, and making things a bit more consi…

4c18d63

…stent

panda01 assigned rashidkpc and unassigned panda01 Apr 6, 2016

panda01 force-pushed the fix/darkTheme branch from c2b842b to 4c18d63 Compare April 6, 2016 21:01

rashidkpc assigned panda01 and unassigned rashidkpc Apr 7, 2016

[DarkTheme] Fixing the active state of the kbntop nav buttons

30d44ee

rashidkpc merged commit 4e9e2ca into elastic:master Apr 7, 2016

rashidkpc mentioned this pull request Apr 13, 2016

Kibana 5.0.0-alpha1 Dark Mode Visibility Issue #6883

Closed

rashidkpc mentioned this pull request Apr 25, 2016

Not able to switch to light/dark theme for saved dashboard #7042

Closed

epixa added the v5.0.0-alpha2 label Apr 29, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for the dark theme#6767

Fixes for the dark theme#6767
rashidkpc merged 4 commits intoelastic:masterfrom
panda01:fix/darkTheme

panda01 commented Apr 4, 2016

Uh oh!

rashidkpc commented Apr 5, 2016

Uh oh!

rashidkpc commented Apr 5, 2016

Uh oh!

rashidkpc commented Apr 5, 2016

Uh oh!

panda01 commented Apr 5, 2016

Uh oh!

rashidkpc commented Apr 5, 2016

Uh oh!

panda01 commented Apr 5, 2016

Uh oh!

panda01 commented Apr 6, 2016

Uh oh!

rashidkpc commented Apr 7, 2016

Uh oh!

panda01 commented Apr 7, 2016

Uh oh!

prashanttct07 commented Apr 25, 2016 •

edited

Loading

Uh oh!

panda01 commented Apr 25, 2016

Uh oh!

prashanttct07 commented Apr 25, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

panda01 commented Apr 4, 2016

Uh oh!

rashidkpc commented Apr 5, 2016

Uh oh!

rashidkpc commented Apr 5, 2016

Uh oh!

rashidkpc commented Apr 5, 2016

Uh oh!

panda01 commented Apr 5, 2016

Uh oh!

rashidkpc commented Apr 5, 2016

Uh oh!

panda01 commented Apr 5, 2016

Uh oh!

panda01 commented Apr 6, 2016

Uh oh!

rashidkpc commented Apr 7, 2016

Uh oh!

panda01 commented Apr 7, 2016

Uh oh!

prashanttct07 commented Apr 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panda01 commented Apr 25, 2016

Uh oh!

prashanttct07 commented Apr 25, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

prashanttct07 commented Apr 25, 2016 •

edited

Loading