[EuiContextMenu] Added optional onPanelChange callback hook.#6767
Merged
1Copenut merged 5 commits intoelastic:mainfrom May 11, 2023
1Copenut:feature/eui-context-menu-onPanelChange
Merged
[EuiContextMenu] Added optional onPanelChange callback hook.#67671Copenut merged 5 commits intoelastic:mainfrom 1Copenut:feature/eui-context-menu-onPanelChange
onPanelChange callback hook.#67671Copenut merged 5 commits intoelastic:mainfrom
1Copenut:feature/eui-context-menu-onPanelChange
Conversation
Contributor
Author
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6767/ |
cee-chen
reviewed
May 10, 2023
cee-chen
reviewed
May 10, 2023
breehall
approved these changes
May 10, 2023
Contributor
breehall
left a comment
breehall
left a comment
There was a problem hiding this comment.
This is great Trevor and I can see this being helpful. I pulled the branch locally and implemented the callback in one of the Context Menu examples. I only have one suggestion about the naming of args. Feel free to pass on it if it makes more sense to you!
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Bree Hall <40739624+breehall@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6767/ |
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6767/ |
Contributor
Author
|
Jenkins test this |
1 similar comment
Contributor
Author
|
Jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6767/ |
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
May 18, 2023
## Summary `@elastic/eui@79.0.1` ⏩ `@elastic/eui@80.0.0` --- ## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0) - Improved the contrast ratio of meta labels within `EuiSelectableTemplateSitewide` to meet WCAG AA guidelines. ([#6761](elastic/eui#6761)) - Added `vulnerabilityManagementApp` glyph to `EuiIcon` ([#6762](elastic/eui#6762)) - Added `logoVulnerabilityManagement` icon to `EuiIcon` ([#6763](elastic/eui#6763)) - Added `onPanelChange` callback to `EuiContextMenu` to provide consumer access to `panelId` and `direction`. ([#6767](elastic/eui#6767)) **Bug fixes** - Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full height and vertically centered. ([#6766](elastic/eui#6766)) - Improved the uniformity of dropdown components by hiding the dropdown icon of disabled `EuiComboBox`s. ([#6768](elastic/eui#6768)) **Breaking changes** - `EuiFieldNumber` now defaults the `step` prop to `"any"` ([#6760](elastic/eui#6760)) - EUI now globally resets a default Chromium browser style that was decreasing the opacity of disabled `select` items. ([#6768](elastic/eui#6768)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
## Summary `@elastic/eui@79.0.1` ⏩ `@elastic/eui@80.0.0` --- ## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0) - Improved the contrast ratio of meta labels within `EuiSelectableTemplateSitewide` to meet WCAG AA guidelines. ([elastic#6761](elastic/eui#6761)) - Added `vulnerabilityManagementApp` glyph to `EuiIcon` ([elastic#6762](elastic/eui#6762)) - Added `logoVulnerabilityManagement` icon to `EuiIcon` ([elastic#6763](elastic/eui#6763)) - Added `onPanelChange` callback to `EuiContextMenu` to provide consumer access to `panelId` and `direction`. ([elastic#6767](elastic/eui#6767)) **Bug fixes** - Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full height and vertically centered. ([elastic#6766](elastic/eui#6766)) - Improved the uniformity of dropdown components by hiding the dropdown icon of disabled `EuiComboBox`s. ([elastic#6768](elastic/eui#6768)) **Breaking changes** - `EuiFieldNumber` now defaults the `step` prop to `"any"` ([elastic#6760](elastic/eui#6760)) - EUI now globally resets a default Chromium browser style that was decreasing the opacity of disabled `select` items. ([elastic#6768](elastic/eui#6768)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tonyghiani requested a callback to know when navigating into and out of nested panels in
EuiContextMenu. He specced out the feature for the EUI team in a Slack discussion. Cee and I discussed it and pair coded the solution presented here.QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles