Skip to content

[Behavioral Analytics] Remove feature flag to hide functionality#147429

Merged
joemcelroy merged 4 commits intoelastic:mainfrom
joemcelroy:remove-feature-flag-ba
Dec 14, 2022
Merged

[Behavioral Analytics] Remove feature flag to hide functionality#147429
joemcelroy merged 4 commits intoelastic:mainfrom
joemcelroy:remove-feature-flag-ba

Conversation

@joemcelroy
Copy link
Member

@joemcelroy joemcelroy commented Dec 13, 2022

Removing feature flag code from behavorial analytics. Behavorial Analytics is now accessible generally. This involves removing the feature flag from uiSettings.

@joemcelroy joemcelroy requested a review from a team December 13, 2022 11:12
@joemcelroy joemcelroy requested review from a team as code owners December 13, 2022 11:12
@joemcelroy joemcelroy added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:EnterpriseSearch v8.7.0 labels Dec 13, 2022
},
{
id: 'enterpiseSearchEngines',
id: 'enterpriseSearchEngines',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @TattdCodeMonkey fixed a typo whilst updating the tests

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1883 1882 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.0MB 2.0MB -352.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 29.5KB 29.2KB -303.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM

@joemcelroy joemcelroy merged commit e87e1ce into elastic:main Dec 14, 2022
@joemcelroy joemcelroy deleted the remove-feature-flag-ba branch December 14, 2022 11:52
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 14, 2022
* main: (21 commits)
  [Profiling] Remove link to 'Other' bucket (elastic#147523)
  [Synthetics UI] Add missing configuration options to the add/edit monitor forms (elastic#147265)
  [DOCS] Updates what's new pages (elastic#147483)
  [Fleet][Endpoint][RBAC V2] Update fleet router and config to allow API access via RBAC controls (elastic#145361)
  [Guided onboarding] Update guide IDs (elastic#147348)
  [Synthetics] Add synthetics settings alerting default (elastic#147339)
  [Security Solution][Endpoint] Fix Policy form being displayed as Read Only when displayed in Fleet pages (elastic#147212)
  [Cases] Save draft user comment (elastic#146327)
  [API Docs] Fix `--plugin` filter (elastic#147500)
  [Fleet] added a logic to use `destinationId` when tagging imported SOs (elastic#147439)
  Do not skip UPDATE_TARGET_MAPPINGS if upgrading to a newer stack version (elastic#147503)
  [Discover] Validate if Data View time field exists on Alert creation / editing (elastic#146324)
  [Discover] Fix Discover navigation from Lens embeddable (elastic#147000)
  Allow users to Update API Keys (elastic#146237)
  Update dependency xstate to ^4.35.0 (main) (elastic#147463)
  [Behavioral Analytics] Remove feature flag to hide functionality (elastic#147429)
  [Fleet] Add agent policy `inactivity_timeout`experimental setting (elastic#147432)
  [APM] Switching service groups from grid to flex layout (elastic#147448)
  [Fleet] Add missing endpoints to openApi specs (elastic#147452)
  [AO] Allow providing custom time range for Alert Summary Widget (elastic#147253)
  ...
nreese pushed a commit to nreese/kibana that referenced this pull request Dec 16, 2022
…stic#147429)

Removing feature flag code from behavorial analytics. Behavorial
Analytics is now accessible generally. This involves removing the
feature flag from uiSettings.

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants