Skip to content

[Synthetics] Add synthetics settings alerting default#147339

Merged
shahzad31 merged 9 commits intoelastic:mainfrom
shahzad31:alerting-default
Dec 14, 2022
Merged

[Synthetics] Add synthetics settings alerting default#147339
shahzad31 merged 9 commits intoelastic:mainfrom
shahzad31:alerting-default

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Dec 12, 2022 •
edited
Loading

Summary

Fixes #145402

image

@shahzad31 shahzad31 closed this Dec 12, 2022
@shahzad31 shahzad31 reopened this Dec 12, 2022
@shahzad31 shahzad31 changed the title added alerting tab [Synthetics] Add synthetics settings alerting default Dec 13, 2022
@shahzad31 shahzad31 marked this pull request as ready for review December 13, 2022 09:36
@shahzad31 shahzad31 requested review from a team as code owners December 13, 2022 09:36
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Dec 13, 2022
afgomez
afgomez reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the code and it works correctly. I found some minor things in the code but nothing noteworthy.

...hetics/public/apps/synthetics/components/settings/alerting_defaults/add_connector_flyout.tsx Outdated
featureId: 'uptime',
}),
// eslint-disable-next-line react-hooks/exhaustive-deps
[]
Copy link
Contributor

@afgomez afgomez Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need focusInput here.

Suggested change
[]
[focusInput]

focusInput is a prop and we cannot guarantee that the consumers will always pass a stable function.

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Dec 13, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 13, 2022

Pinging @elastic/uptime (Team:uptime)

shahzad31 and others added 8 commits December 13, 2022 11:57
@shahzad31 @afgomez
Update x-pack/plugins/stack_connectors/public/connector_types/stack/e…
fa13f19 
…mail/email_params.tsx

Co-authored-by: Alejandro Fernández Gómez <antarticonorte@gmail.com>
@shahzad31 @afgomez
Update x-pack/plugins/stack_connectors/public/connector_types/stack/e…
7c40ab7 
…mail/email_params.tsx

Co-authored-by: Alejandro Fernández Gómez <antarticonorte@gmail.com>
@shahzad31 @afgomez
Update x-pack/plugins/stack_connectors/public/connector_types/stack/e…
b6f3e20 
…mail/email_params.tsx

Co-authored-by: Alejandro Fernández Gómez <antarticonorte@gmail.com>
@shahzad31 @afgomez
Update x-pack/plugins/synthetics/public/apps/synthetics/components/se…
d5a55cd 
…ttings/alerting_defaults/validation.ts

Co-authored-by: Alejandro Fernández Gómez <antarticonorte@gmail.com>
@shahzad31
Merge branch 'main' of github.com:elastic/kibana into alerting-default
f3f5c77
@shahzad31
PR feedback
14db6e2
@shahzad31
Merge branch 'alerting-default' of github.com:shahzad31/kibana into a…
0b44fac 
…lerting-default
@shahzad31
Merge branch 'main' into alerting-default
46256fc
@kibana-ci
Copy link

kibana-ci commented Dec 13, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1116 1128 +12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
triggersActionsUi 503 505 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 415.7KB 415.8KB +45.0B
synthetics 1.2MB 1.2MB +9.5KB
total +9.5KB
Unknown metric groups

API count

id before after diff
triggersActionsUi 532 534 +2

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
synthetics 65 67 +2
total +22

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
synthetics 71 73 +2
total +23

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 requested a review from afgomez December 14, 2022 10:19
afgomez
afgomez approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ymao1
ymao1 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response Ops changes LGTM

@shahzad31 shahzad31 merged commit edc8624 into elastic:main Dec 14, 2022
@shahzad31 shahzad31 deleted the alerting-default branch December 14, 2022 14:41
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Dec 14, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 14, 2022
@jloleysens
Merge branch 'main' into only-migrate-if-needed-KBNA-4488
60d2987 
* main: (21 commits)
  [Profiling] Remove link to 'Other' bucket (elastic#147523)
  [Synthetics UI] Add missing configuration options to the add/edit monitor forms (elastic#147265)
  [DOCS] Updates what's new pages (elastic#147483)
  [Fleet][Endpoint][RBAC V2] Update fleet router and config to allow API access via RBAC controls (elastic#145361)
  [Guided onboarding] Update guide IDs (elastic#147348)
  [Synthetics] Add synthetics settings alerting default (elastic#147339)
  [Security Solution][Endpoint] Fix Policy form being displayed as Read Only when displayed in Fleet pages (elastic#147212)
  [Cases] Save draft user comment (elastic#146327)
  [API Docs] Fix `--plugin` filter (elastic#147500)
  [Fleet] added a logic to use `destinationId` when tagging imported SOs (elastic#147439)
  Do not skip UPDATE_TARGET_MAPPINGS if upgrading to a newer stack version (elastic#147503)
  [Discover] Validate if Data View time field exists on Alert creation / editing (elastic#146324)
  [Discover] Fix Discover navigation from Lens embeddable (elastic#147000)
  Allow users to Update API Keys (elastic#146237)
  Update dependency xstate to ^4.35.0 (main) (elastic#147463)
  [Behavioral Analytics] Remove feature flag to hide functionality (elastic#147429)
  [Fleet] Add agent policy `inactivity_timeout`experimental setting (elastic#147432)
  [APM] Switching service groups from grid to flex layout (elastic#147448)
  [Fleet] Add missing endpoints to openApi specs (elastic#147452)
  [AO] Allow providing custom time range for Alert Summary Widget (elastic#147253)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ymao1 ymao1 ymao1 approved these changes

+1 more reviewer

@afgomez afgomez afgomez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Synthetics] Settings page alerting defaults tab

6 participants

@shahzad31 @elasticmachine @kibana-ci @afgomez @ymao1 @kibanamachine