Skip to content

[Synthetics UI] Add missing configuration options to the add/edit monitor forms#147265

Merged
afgomez merged 5 commits intoelastic:mainfrom
afgomez:147182-add-missing-monitor-config
Dec 14, 2022
Merged

[Synthetics UI] Add missing configuration options to the add/edit monitor forms#147265
afgomez merged 5 commits intoelastic:mainfrom
afgomez:147182-add-missing-monitor-config

Conversation

@afgomez
Copy link
Contributor

@afgomez afgomez commented Dec 8, 2022

Summary

Part of #147182.

Implemented

  • Parameters (this is not under advanced, but the main configuration, in Uptime)
  • Ignore HTTPS errors (under advanced)
  • Synthetics args (under advanced)

Not implemented

  • Throttling. This is pending clarification from @drewpost

@afgomez afgomez added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Dec 8, 2022
@afgomez afgomez force-pushed the 147182-add-missing-monitor-config branch from 228fe8c to 3cbed98 Compare December 8, 2022 16:31
@afgomez afgomez marked this pull request as ready for review December 12, 2022 14:03
@afgomez afgomez requested a review from a team as a code owner December 12, 2022 14:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@afgomez afgomez enabled auto-merge (squash) December 14, 2022 14:55
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB +2.1KB
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit 39d8c7e into elastic:main Dec 14, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Dec 14, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 14, 2022
* main: (21 commits)
  [Profiling] Remove link to 'Other' bucket (elastic#147523)
  [Synthetics UI] Add missing configuration options to the add/edit monitor forms (elastic#147265)
  [DOCS] Updates what's new pages (elastic#147483)
  [Fleet][Endpoint][RBAC V2] Update fleet router and config to allow API access via RBAC controls (elastic#145361)
  [Guided onboarding] Update guide IDs (elastic#147348)
  [Synthetics] Add synthetics settings alerting default (elastic#147339)
  [Security Solution][Endpoint] Fix Policy form being displayed as Read Only when displayed in Fleet pages (elastic#147212)
  [Cases] Save draft user comment (elastic#146327)
  [API Docs] Fix `--plugin` filter (elastic#147500)
  [Fleet] added a logic to use `destinationId` when tagging imported SOs (elastic#147439)
  Do not skip UPDATE_TARGET_MAPPINGS if upgrading to a newer stack version (elastic#147503)
  [Discover] Validate if Data View time field exists on Alert creation / editing (elastic#146324)
  [Discover] Fix Discover navigation from Lens embeddable (elastic#147000)
  Allow users to Update API Keys (elastic#146237)
  Update dependency xstate to ^4.35.0 (main) (elastic#147463)
  [Behavioral Analytics] Remove feature flag to hide functionality (elastic#147429)
  [Fleet] Add agent policy `inactivity_timeout`experimental setting (elastic#147432)
  [APM] Switching service groups from grid to flex layout (elastic#147448)
  [Fleet] Add missing endpoints to openApi specs (elastic#147452)
  [AO] Allow providing custom time range for Alert Summary Widget (elastic#147253)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants