Skip to content

[Lens] Datatable expression types improvement.#144173

Merged
Kuznietsov merged 10 commits intoelastic:mainfrom
Kuznietsov:lens-expressions-types-improvement-datatable
Nov 1, 2022
Merged

[Lens] Datatable expression types improvement.#144173
Kuznietsov merged 10 commits intoelastic:mainfrom
Kuznietsov:lens-expressions-types-improvement-datatable

Conversation

@Kuznietsov
Copy link
Contributor

Summary

Completes part of #140555

Changed types for Datatable toExpression function in Lens.

@Kuznietsov Kuznietsov added the WIP Work in progress label Oct 28, 2022
@Kuznietsov Kuznietsov requested a review from alexwizp October 28, 2022 14:59
@Kuznietsov Kuznietsov self-assigned this Oct 28, 2022
@Kuznietsov Kuznietsov changed the title [Lens] Gauge expression types improvement. [Lens] Datatable expression types improvement. Oct 28, 2022
@Kuznietsov Kuznietsov added loe:small Small Level of Effort Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. backport:skip This PR does not require backporting v8.6.0 labels Oct 28, 2022
@Kuznietsov Kuznietsov force-pushed the lens-expressions-types-improvement-datatable branch 2 times, most recently from e6a3bed to 894afdb Compare October 31, 2022 10:28
@Kuznietsov Kuznietsov removed the WIP Work in progress label Oct 31, 2022
@Kuznietsov Kuznietsov marked this pull request as ready for review October 31, 2022 12:25
@Kuznietsov Kuznietsov requested a review from a team as a code owner October 31, 2022 12:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

…ion.test.tsx

Co-authored-by: Andrew Tate <drewctate@gmail.com>
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB -127.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 443 +4
total +17

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 520 +4
total +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov merged commit 74829e5 into elastic:main Nov 1, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 1, 2022
* main: (43 commits)
  [Synthetics] Step details page screenshot (elastic#143452)
  [Lens] Datatable expression types improvement. (elastic#144173)
  [packages/kbn-journeys] start apm after browser start and stop after browser is closed (elastic#144267)
  [Files] Make files namespace agnostic (elastic#144019)
  Implement base browser-side logging system (elastic#144107)
  Correct wrong multiplier for byte conversion (elastic#143751)
  [Monaco] Add JSON syntax support to the Monaco editor (elastic#143739)
  CCS Smoke Test for Remote Clusters and Index Management  (elastic#142423)
  [api-docs] Daily api_docs build (elastic#144294)
  chore(NA): include progress on Bazel tasks (elastic#144275)
  [RAM] Allow users to see event logs from all spaces they have access to (elastic#140449)
  [APM] Show recommended minimum size when going below 5 minutes (elastic#144170)
  [typecheck] delete temporary target_types dirs in packages (elastic#144271)
  [Security Solution][Endpoint] adds new alert loading utility and un-skip FTR test for endpoint (elastic#144133)
  [performance/journeys] revert data_stress_test_lens.ts journey step (elastic#144261)
  [TIP] Use search strategies in Threat Intelligence (elastic#143267)
  Optimize react-query dependencies (elastic#144206)
  [babel/node] invalidate cache when synth pkg map is updated (elastic#144258)
  [APM] AWS lambda estimated cost (elastic#143986)
  [Maps] layer group wizard (elastic#144129)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants